Generate IPC serialization for WebCore::WheelEventTestMonitor::DeferReason #20161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdobersek
added
the
New Bugs
|
EWS run on previous version of this PR (hash 6a3a2ef)
|
zdobersek
force-pushed
the
eng/Generate-IPC-serialization-for-WebCoreWheelEventTestMonitorDeferReason
branch
from
6a3a2ef
to
dd99cca
Compare
|
EWS run on previous version of this PR (hash dd99cca)
|
webkit-ews-buildbot
added
the
merging-blocked
zdobersek
added
merge-queue
zdobersek
force-pushed
the
eng/Generate-IPC-serialization-for-WebCoreWheelEventTestMonitorDeferReason
branch
from
dd99cca
to
e974d40
Compare
|
EWS run on current version of this PR (hash e974d40)
|
…eason https://bugs.webkit.org/show_bug.cgi?id=264405 Reviewed by Chris Dumez. Move the WheelEventTestMonitor::DeferReason enum outside the WheelEventTestMonitor class and turn it into an enumerated scope, providing a type alias inside the WheelEventTestMonitor class and updating the uses of the enumeration values. This enables specifying IPC serialization for this enumeration, avoiding listing all the enumeration values in the EnumTraits specialization that can now be removed. The two messages in the RemoteScrollingCoordinator IPC interface are updated to handle these enumeration values as OptionSets, also requiring to adjust the deferForReason and removeDeferralForReason methods on the WheelEventTestMonitor class to work with OptionSet parameters. * Source/WebCore/page/WheelEventTestMonitor.cpp: (WebCore::WheelEventTestMonitor::deferForReason): (WebCore::WheelEventTestMonitor::removeDeferralForReason): (WebCore::operator<<): * Source/WebCore/page/WheelEventTestMonitor.h: (): Deleted. * Source/WebCore/page/scrolling/ThreadedScrollingCoordinator.cpp: (WebCore::ThreadedScrollingCoordinator::handleWheelEventForScrolling): * Source/WebCore/page/scrolling/ThreadedScrollingTree.cpp: (WebCore::ThreadedScrollingTree::scrollingTreeNodeDidScroll): * Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm: (WebCore::ScrollingTreeScrollingNodeDelegateMac::handleWheelEvent): * Source/WebCore/page/scrolling/nicosia/ScrollingTreeScrollingNodeDelegateNicosia.cpp: (WebCore::ScrollingTreeScrollingNodeDelegateNicosia::handleWheelEvent): * Source/WebCore/platform/ScrollingEffectsController.cpp: (WebCore::ScrollingEffectsController::startScrollSnapAnimation): (WebCore::ScrollingEffectsController::stopScrollSnapAnimation): (WebCore::ScrollingEffectsController::scrollAnimationWillStart): (WebCore::ScrollingEffectsController::scrollAnimationDidEnd): * Source/WebCore/platform/mac/ScrollbarsControllerMac.mm: (WebCore::ScrollbarsControllerMac::didBeginScrollGesture): (WebCore::ScrollbarsControllerMac::didEndScrollGesture): (WebCore::ScrollbarsControllerMac::sendContentAreaScrolledTimerFired): (WebCore::ScrollbarsControllerMac::sendContentAreaScrolledSoon): * Source/WebCore/platform/mac/ScrollingEffectsController.mm: (WebCore::ScrollingEffectsController::willStartRubberBandAnimation): (WebCore::ScrollingEffectsController::didStopRubberBandAnimation): (WebCore::ScrollingEffectsController::scheduleDiscreteScrollSnap): (WebCore::ScrollingEffectsController::discreteSnapTransitionTimerFired): * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.h: * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.messages.in: * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm: (WebKit::RemoteScrollingCoordinator::startDeferringScrollingTestCompletionForNode): (WebKit::RemoteScrollingCoordinator::stopDeferringScrollingTestCompletionForNode): Canonical link: https://commits.webkit.org/270514@main
webkit-commit-queue
force-pushed
the
eng/Generate-IPC-serialization-for-WebCoreWheelEventTestMonitorDeferReason
branch
from
e974d40
to
a6c2467
Compare
|
Committed 270514@main (a6c2467): https://commits.webkit.org/270514@main Reviewed commits have been landed. Closing PR #20161 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
zdobersek
deleted the
eng/Generate-IPC-serialization-for-WebCoreWheelEventTestMonitorDeferReason
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a6c2467
e974d40
🧪 wpe-wk2🧪 ios-wk2-wpt🧪 gtk-wk2🧪 mac-wk2