Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webkitbot should accept commit identifier (Follow-up fix) #2019

Merged
merged 1 commit into from Jul 1, 2022
Merged

webkitbot should accept commit identifier (Follow-up fix) #2019

merged 1 commit into from Jul 1, 2022

Conversation

JonWBedard
Copy link
Member

@JonWBedard JonWBedard commented Jul 1, 2022 •
edited by webkit-commit-queue

90ac25f

webkitbot should accept commit identifier (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=224063
<rdar://76114559>

Unreviewed follow-up fix.

* Tools/WebKitBot/src/WebKitBot.mjs: Do not convert all revisions to integers,
support variety of hash lengths.

Canonical link: https://commits.webkit.org/252080@main

@JonWBedard JonWBedard self-assigned this Jul 1, 2022
@JonWBedard JonWBedard added Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases WebKit Nightly Build labels Jul 1, 2022
@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label Jul 1, 2022
@JonWBedard JonWBedard added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Jul 1, 2022
@JonWBedard
webkitbot should accept commit identifier (Follow-up fix)
90ac25f 
https://bugs.webkit.org/show_bug.cgi?id=224063
<rdar://76114559>

Unreviewed follow-up fix.

* Tools/WebKitBot/src/WebKitBot.mjs: Do not convert all revisions to integers,
support variety of hash lengths.

Canonical link: https://commits.webkit.org/252080@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/webkitbot-should-accept-commit-identifier branch from 1526a09 to 90ac25f Compare July 1, 2022 23:56
@webkit-commit-queue
Copy link
Collaborator

Committed 252080@main (90ac25f): https://commits.webkit.org/252080@main

Reviewed commits have been landed. Closing PR #2019 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 90ac25f into WebKit:main Jul 1, 2022
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jul 1, 2022
@JonWBedard JonWBedard deleted the eng/webkitbot-should-accept-commit-identifier branch July 12, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JonWBedard JonWBedard

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
3 participants
@JonWBedard @webkit-commit-queue @webkit-early-warning-system