Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SIMD in HasConstantValue() in BiquadDSPKernel #20233

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

@cdumez cdumez self-assigned this Nov 9, 2023
@cdumez cdumez added the Web Audio Bugs against the Web Audio API label Nov 9, 2023
@cdumez cdumez marked this pull request as ready for review November 9, 2023 17:32
Copy link
Member

@jyavenard jyavenard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have test coverage for this?

@cdumez
Copy link
Contributor Author

cdumez commented Nov 13, 2023

Do we have test coverage for this?

It gets called many times when running the web audio layout tests and the tests are still passing.

@cdumez cdumez added merge-queue Applied to send a pull request to merge-queue unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merge-queue Applied to send a pull request to merge-queue labels Nov 13, 2023
https://bugs.webkit.org/show_bug.cgi?id=264488

Reviewed by Jean-Yves Avenard.

Cherry-pick the following optimization from Blink:
https://chromium-review.googlesource.com/c/chromium/src/+/4605295

Original patch by Ho Cheung.

* Source/WebCore/Modules/webaudio/BiquadDSPKernel.cpp:
(WebCore::hasConstantValue):

Canonical link: https://commits.webkit.org/270669@main
@webkit-commit-queue
Copy link
Collaborator

Committed 270669@main (0a313d9): https://commits.webkit.org/270669@main

Reviewed commits have been landed. Closing PR #20233 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 0a313d9 into WebKit:main Nov 13, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Web Audio Bugs against the Web Audio API
Projects
None yet
4 participants