Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using Vector::unsafeAppendWithoutCapacityCheck() in ThreadSafeWeakHashSet::values() #20281

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Avoid using Vector::unsafeAppendWithoutCapacityCheck() in ThreadSafeWeakHashSet::values() #20281

merged 1 commit into from
Nov 10, 2023

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Nov 10, 2023 •
edited by webkit-early-warning-system
Loading

f870891

Avoid using Vector::unsafeAppendWithoutCapacityCheck() in ThreadSafeWeakHashSet::values()
https://bugs.webkit.org/show_bug.cgi?id=264545

Reviewed by Darin Adler.

Use WTF::compactMap() instead.

* Source/WTF/wtf/ThreadSafeWeakHashSet.h:

Canonical link: https://commits.webkit.org/270529@main

a972043

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@cdumez cdumez self-assigned this Nov 10, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 10, 2023 •
edited
Loading

EWS run on current version of this PR (hash a972043)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@cdumez cdumez marked this pull request as ready for review November 10, 2023 06:17
@cdumez cdumez added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 10, 2023
@cdumez
Avoid using Vector::unsafeAppendWithoutCapacityCheck() in ThreadSafeW…
f870891 
…eakHashSet::values()

https://bugs.webkit.org/show_bug.cgi?id=264545

Reviewed by Darin Adler.

Use WTF::compactMap() instead.

* Source/WTF/wtf/ThreadSafeWeakHashSet.h:

Canonical link: https://commits.webkit.org/270529@main
@webkit-commit-queue webkit-commit-queue force-pushed the 264545_ThreadSafeWeakHashSet_no_unsafeAppend branch from a972043 to f870891 Compare November 10, 2023 15:11
@webkit-commit-queue
Copy link
Collaborator

Committed 270529@main (f870891): https://commits.webkit.org/270529@main

Reviewed commits have been landed. Closing PR #20281 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit f870891 into WebKit:main Nov 10, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darinadler darinadler darinadler approved these changes

@achristensen07 achristensen07 Awaiting requested review from achristensen07

@rniwa rniwa Awaiting requested review from rniwa

Assignees

@cdumez cdumez

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@cdumez @webkit-early-warning-system @webkit-commit-queue @darinadler