Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using Vector::unsafeAppendWithoutCapacityCheck() in JSC::intlAvailableTimeZones() #20282

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Stop using Vector::unsafeAppendWithoutCapacityCheck() in JSC::intlAvailableTimeZones() #20282

merged 1 commit into from
Nov 10, 2023

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Nov 10, 2023 •
edited by webkit-early-warning-system
Loading

8aaa6aa

Stop using Vector::unsafeAppendWithoutCapacityCheck() in JSC::intlAvailableTimeZones()
https://bugs.webkit.org/show_bug.cgi?id=264546

Reviewed by Darin Adler.

* Source/JavaScriptCore/runtime/IntlObject.cpp:
(JSC::intlAvailableTimeZones):

Canonical link: https://commits.webkit.org/270528@main

220bcba

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@cdumez cdumez self-assigned this Nov 10, 2023
@cdumez cdumez added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Nov 10, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 10, 2023 •
edited
Loading

EWS run on current version of this PR (hash 220bcba)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@cdumez cdumez marked this pull request as ready for review November 10, 2023 06:18
@cdumez cdumez requested a review from a team as a code owner November 10, 2023 06:18
@cdumez cdumez added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 10, 2023
@cdumez
Stop using Vector::unsafeAppendWithoutCapacityCheck() in JSC::intlAva…
8aaa6aa 
…ilableTimeZones()

https://bugs.webkit.org/show_bug.cgi?id=264546

Reviewed by Darin Adler.

* Source/JavaScriptCore/runtime/IntlObject.cpp:
(JSC::intlAvailableTimeZones):

Canonical link: https://commits.webkit.org/270528@main
@webkit-commit-queue webkit-commit-queue force-pushed the 264546_intlAvailableTimeZones_no_unsafeAppend branch from 220bcba to 8aaa6aa Compare November 10, 2023 15:10
@webkit-commit-queue
Copy link
Collaborator

Committed 270528@main (8aaa6aa): https://commits.webkit.org/270528@main

Reviewed commits have been landed. Closing PR #20282 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 8aaa6aa into WebKit:main Nov 10, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darinadler darinadler darinadler approved these changes

@Constellation Constellation Awaiting requested review from Constellation

@rniwa rniwa Awaiting requested review from rniwa

Assignees

@cdumez cdumez

Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Milestone
No milestone
4 participants
@cdumez @webkit-early-warning-system @webkit-commit-queue @darinadler