Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GStreamer][VideoCapture] do not call reconfigure() in settingsDidChange unless size or framerate sucessfully changes #2032

Merged
merged 1 commit into from Jul 3, 2022
Merged

[GStreamer][VideoCapture] do not call reconfigure() in settingsDidChange unless size or framerate sucessfully changes #2032

merged 1 commit into from Jul 3, 2022

Conversation

jameshilliard
Copy link
Contributor

@jameshilliard jameshilliard commented Jul 2, 2022 •
edited by webkit-commit-queue

c8d60e9

[GStreamer][VideoCapture] do not call reconfigure() in settingsDidChange unless size or framerate sucessfully changes
https://bugs.webkit.org/show_bug.cgi?id=242291

Reviewed by Philippe Normand.

This appears to eliminate a redundant reconfigure call during stream shutdown.

* Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp:
(WebCore::GStreamerVideoCaptureSource::settingsDidChange):

Canonical link: https://commits.webkit.org/252102@main

@philn philn added the merge-queue Applied to send a pull request to merge-queue label Jul 3, 2022
@jameshilliard @philn
[GStreamer][VideoCapture] do not call reconfigure() in settingsDidCha…
c8d60e9 
…nge unless size or framerate sucessfully changes

https://bugs.webkit.org/show_bug.cgi?id=242291

Reviewed by Philippe Normand.

This appears to eliminate a redundant reconfigure call during stream shutdown.

* Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp:
(WebCore::GStreamerVideoCaptureSource::settingsDidChange):

Canonical link: https://commits.webkit.org/252102@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/GStreamerVideoCapture-do-not-call-reconfigure-in-settingsDidChange-unless-size-or-framerate-sucessfully-changes branch from 2d1d644 to c8d60e9 Compare July 3, 2022 18:03
@webkit-commit-queue
Copy link
Collaborator

Committed 252102@main (c8d60e9): https://commits.webkit.org/252102@main

Reviewed commits have been landed. Closing PR #2032 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit c8d60e9 into WebKit:main Jul 3, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philn philn philn approved these changes

@calvaris calvaris Awaiting requested review from calvaris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@jameshilliard @webkit-commit-queue @philn @webkit-early-warning-system