Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GPU][macOS] Allow semaphore related syscalls #20369

Merged
merged 1 commit into from
Nov 13, 2023
Merged

[GPU][macOS] Allow semaphore related syscalls #20369

merged 1 commit into from
Nov 13, 2023

Conversation

pvollan
Copy link
Contributor

@pvollan pvollan commented Nov 11, 2023 •
edited by webkit-early-warning-system
Loading

@pvollan pvollan self-assigned this Nov 11, 2023
@pvollan pvollan added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Nov 11, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 11, 2023 •
edited
Loading

EWS run on current version of this PR (hash 4b36e7a)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

brentfulgham
brentfulgham approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@brentfulgham brentfulgham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! r=me

@brentfulgham brentfulgham added the merge-queue Applied to send a pull request to merge-queue label Nov 13, 2023
@webkit-commit-queue webkit-commit-queue force-pushed the eng/GPUmacOS-Allow-semaphore-related-syscalls branch from 4b36e7a to fc7f361 Compare November 13, 2023 22:41
@pvollan
[GPU][macOS] Allow semaphore related syscalls
8ac33ec 
https://bugs.webkit.org/show_bug.cgi?id=264677
rdar://116431329

Reviewed by Brent Fulgham.

* Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:

Canonical link: https://commits.webkit.org/270676@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/GPUmacOS-Allow-semaphore-related-syscalls branch from fc7f361 to 8ac33ec Compare November 13, 2023 22:44
@webkit-commit-queue
Copy link
Collaborator

Committed 270676@main (8ac33ec): https://commits.webkit.org/270676@main

Reviewed commits have been landed. Closing PR #20369 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 8ac33ec into WebKit:main Nov 13, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentfulgham brentfulgham brentfulgham approved these changes

@cdumez cdumez Awaiting requested review from cdumez

@szewai szewai Awaiting requested review from szewai

Assignees

@pvollan pvollan

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
4 participants
@pvollan @webkit-early-warning-system @webkit-commit-queue @brentfulgham