Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GStreamer][VideoCapture] Fix video/x-raw mime-type format check #2041

Conversation

jameshilliard
Copy link
Contributor

@jameshilliard jameshilliard commented Jul 3, 2022

f05c325

[GStreamer][VideoCapture] Fix video/x-raw mime-type format check
https://bugs.webkit.org/show_bug.cgi?id=242296

Reviewed by Philippe Normand.

Should use gst_structure_has_field not gst_structure_has_name for this
check.

* Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp:
(WebCore::GStreamerVideoCapturer::reconfigure):

Canonical link: https://commits.webkit.org/252104@main

@philn philn added the merge-queue Applied to send a pull request to merge-queue label Jul 3, 2022
https://bugs.webkit.org/show_bug.cgi?id=242296

Reviewed by Philippe Normand.

Should use gst_structure_has_field not gst_structure_has_name for this
check.

* Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp:
(WebCore::GStreamerVideoCapturer::reconfigure):

Canonical link: https://commits.webkit.org/252104@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/GStreamerVideoCapture-Fix-videox-raw-mime-type-format-check branch from 440bc85 to f05c325 Compare July 3, 2022 18:47
@webkit-commit-queue
Copy link
Collaborator

Committed 252104@main (f05c325): https://commits.webkit.org/252104@main

Reviewed commits have been landed. Closing PR #2041 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit f05c325 into WebKit:main Jul 3, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 3, 2022
@jameshilliard jameshilliard deleted the eng/GStreamerVideoCapture-Fix-videox-raw-mime-type-format-check branch July 3, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants