iOS: click event doesn't get dispatched when there is a click event listener on ShadowRoot #2043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rniwa
added
Safari 14
UI Events
whsieh
approved these changes
Jul 3, 2022
Sure, we can do that. |
…istener on ShadowRoot https://bugs.webkit.org/show_bug.cgi?id=218923 Reviewed by Wenson Hsieh. The bug was caused by WebPage::commitPotentialTap falsely treating ShadowRoot as an invalid tap target because it doesn't have a renderer. Fixed the bug by checking the shadow host's renderer instead much like http://commits.webkit.org/r246404 for display: contents. * Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::commitPotentialTap): Fixed the bug. * LayoutTests/fast/shadow-dom/click-eventlistener-on-shadow-root-expected.txt: Added. * LayoutTests/fast/shadow-dom/click-eventlistener-on-shadow-root.html: Added. Canonical link: https://commits.webkit.org/252107@main
webkit-early-warning-system
force-pushed
the
fix218923
branch
from
b04cef1
to
b01e405
Compare
|
Committed 252107@main (b01e405): https://commits.webkit.org/252107@main Reviewed commits have been landed. Closing PR #2043 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b01e405