Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port the VTT enums to the new IPC serialization format #20435

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Port the VTT enums to the new IPC serialization format #20435

merged 1 commit into from
Nov 14, 2023

Conversation

csaavedra
Copy link
Member

@csaavedra csaavedra commented Nov 13, 2023 •
edited by webkit-early-warning-system
Loading

dfde53f

Port the VTT enums to the new IPC serialization format
https://bugs.webkit.org/show_bug.cgi?id=264768

Reviewed by Chris Dumez.

Remove the EnumTraits enums in favor of the new IPC serialization
format.

Needed to pull a few headers included from VTTCue.h to the private
headers for this to work. Also added an alias to the last item
in two of the enums, for convenience when doing static-asserts.

* Source/WebCore/Headers.cmake:
* Source/WebCore/html/track/VTTCue.cpp:
* Source/WebCore/html/track/VTTCue.h:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/270698@main

f6a6c4f

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@csaavedra csaavedra self-assigned this Nov 13, 2023
@csaavedra csaavedra added the Media Bugs related to the HTML 5 Media elements. label Nov 13, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 13, 2023 •
edited
Loading

EWS run on previous version of this PR (hash a9289d3)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style   🛠 ios ⏳ 🛠 mac   🛠 wpe ⏳ 🛠 wincairo
  🧪 bindings   🛠 ios-sim ⏳ 🛠 mac-AS-debug   🧪 wpe-wk2
  🧪 webkitperl   🧪 ios-wk2 ⏳ 🧪 api-mac ⏳ 🛠 gtk
⏳ 🧪 webkitpy   🧪 ios-wk2-wpt ⏳ 🧪 mac-wk1 ⏳ 🧪 gtk-wk2
  🧪 api-ios ⏳ 🧪 mac-wk2 ⏳ 🧪 api-gtk
⏳ 🛠 tv ⏳ 🧪 mac-AS-debug-wk2
⏳ 🛠 tv-sim ⏳ 🧪 mac-wk2-stress
⏳ 🛠 watch
⏳ 🛠 watch-sim

@csaavedra csaavedra force-pushed the eng/Port-the-VTT-enums-to-the-new-IPC-serialization-format branch from a9289d3 to f06ccbf Compare November 13, 2023 20:55
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 13, 2023 •
edited
Loading

EWS run on previous version of this PR (hash f06ccbf)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios ❌ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🧪 api-mac ✅ 🛠 gtk
❌ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ⏳ 🧪 gtk-wk2
❌ 🧪 api-ios ❌ 🧪 mac-wk2 ⏳ 🧪 api-gtk
❌ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
❌ 🛠 tv-sim ❌ 🧪 mac-wk2-stress
❌ 🛠 watch
❌ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 13, 2023
@csaavedra csaavedra removed the merging-blocked Applied to prevent a change from being merged label Nov 13, 2023
@csaavedra csaavedra force-pushed the eng/Port-the-VTT-enums-to-the-new-IPC-serialization-format branch from f06ccbf to f6a6c4f Compare November 13, 2023 22:42
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 13, 2023 •
edited
Loading

EWS run on current version of this PR (hash f6a6c4f)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@csaavedra
Copy link
Member Author

Please review the xcode project changes, I'm not familiar with this.

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 14, 2023
@csaavedra csaavedra added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Nov 14, 2023
@csaavedra
Port the VTT enums to the new IPC serialization format
dfde53f 
https://bugs.webkit.org/show_bug.cgi?id=264768

Reviewed by Chris Dumez.

Remove the EnumTraits enums in favor of the new IPC serialization
format.

Needed to pull a few headers included from VTTCue.h to the private
headers for this to work. Also added an alias to the last item
in two of the enums, for convenience when doing static-asserts.

* Source/WebCore/Headers.cmake:
* Source/WebCore/html/track/VTTCue.cpp:
* Source/WebCore/html/track/VTTCue.h:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/270698@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Port-the-VTT-enums-to-the-new-IPC-serialization-format branch from f6a6c4f to dfde53f Compare November 14, 2023 08:47
@webkit-commit-queue
Copy link
Collaborator

Committed 270698@main (dfde53f): https://commits.webkit.org/270698@main

Reviewed commits have been landed. Closing PR #20435 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit dfde53f into WebKit:main Nov 14, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 14, 2023
@csaavedra csaavedra deleted the eng/Port-the-VTT-enums-to-the-new-IPC-serialization-format branch December 12, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rniwa rniwa Awaiting requested review from rniwa rniwa is a code owner

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

Assignees

@csaavedra csaavedra

Labels
Media Bugs related to the HTML 5 Media elements.
Projects
None yet
Milestone
No milestone
5 participants
@csaavedra @webkit-early-warning-system @webkit-commit-queue @cdumez @webkit-ews-buildbot