[webkitscmpy] Add commit status to pull-request #20494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonWBedard
added
the
Tools / Tests
|
EWS run on previous version of this PR (hash 35a5117) |
|
Trying to help unblock #18037 by landing this part independently, since it ended up being a bigger change than @gsnedders and I expected. |
emw-apple
approved these changes
Nov 14, 2023
JonWBedard
force-pushed
the
eng/webkitscmpy-Add-commit-status-to-pull-request
branch
from
35a5117
to
352bbfe
Compare
JonWBedard
added
the
unsafe-merge-queue
|
EWS run on current version of this PR (hash 352bbfe)
|
webkit-commit-queue
force-pushed
the
eng/webkitscmpy-Add-commit-status-to-pull-request
branch
from
352bbfe
to
7b62099
Compare
https://bugs.webkit.org/show_bug.cgi?id=264827 rdar://118406906 Reviewed by Elliott Williams. Add commit status and associated mock support to webkitscmpy for future use. * Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/bitbucket.py: (BitBucket.__init__): Add "statuses" dictionary. (BitBucket.request): Respond with mock commit status. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py: (GitHub.__init__): Add "statuses" dictionary. (GitHub._commit_response): Repond with mock commit status. (GitHub.request): Handle commit URLs with trailing path arguments. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/pull_request.py: (PullRequest.Status): Added. (PullRequest.Status.Encoder): Added JSON decoder. (PullRequest.statuses): Return all commit statuses on the current pull-request object. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/bitbucket.py: (BitBucket.PRGenerator.statuses): Populate commit statuses in pull-request object. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py: (GitHub.PRGenerator.statuses): Ditto. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/scm.py: (Scm.PRGenerator.statuses): * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py: Canonical link: https://commits.webkit.org/270736@main
webkit-commit-queue
force-pushed
the
eng/webkitscmpy-Add-commit-status-to-pull-request
branch
from
7b62099
to
fca112b
Compare
|
Committed 270736@main (fca112b): https://commits.webkit.org/270736@main Reviewed commits have been landed. Closing PR #20494 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
JonWBedard
deleted the
eng/webkitscmpy-Add-commit-status-to-pull-request
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fca112b
352bbfe
🛠 ios🛠 wpe🛠 wincairo🛠 ios-sim🛠 mac-AS-debug🧪 wpe-wk2🧪 ios-wk2🧪 api-mac🛠 gtk🧪 webkitpy🧪 ios-wk2-wpt🧪 mac-wk1🧪 gtk-wk2🧪 api-ios🧪 mac-wk2🧪 api-gtk🛠 tv🧪 mac-AS-debug-wk2🛠 tv-sim🛠 watch🛠 watch-sim