Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[resultsdb] Expose reported flakiness information in the UI #2051

Conversation

aoikonomopoulos
Copy link
Contributor

@aoikonomopoulos aoikonomopoulos commented Jul 4, 2022

654dea1

[resultsdb] Expose reported flakiness information in the UI
https://bugs.webkit.org/show_bug.cgi?id=238809

Reviewed by Jonathan Bedard.

Aggregate the number of flaky tests in an upload. In the suites view,
provide a 'Show number of flaky tests' toggle. In the search view,
provide a 'Show test flakiness' toggle. Make the per-dot tag into an
array of information. Toggling all possible tag values on at once will
certainly result in text overlap).

* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/model/suite_context.py:
(SuiteContext.register):
(SuiteContext.register.callback):
* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/timeline.js:
(TimelineFromEndpoint.const.options.prototype.renderFactory):
(result.div.label.Show.test.flakiness.label.label):
(result.div.label.Number.of.flakes.label.label):
* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/templates/search.html:
* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/templates/suite_results.html:

Canonical link: https://commits.webkit.org/252114@main

@aoikonomopoulos aoikonomopoulos self-assigned this Jul 4, 2022
@aoikonomopoulos aoikonomopoulos added New Bugs Unclassified bugs are placed in this component until the correct component can be determined. WebKit Nightly Build merge-queue Applied to send a pull request to merge-queue labels Jul 4, 2022
https://bugs.webkit.org/show_bug.cgi?id=238809

Reviewed by Jonathan Bedard.

Aggregate the number of flaky tests in an upload. In the suites view,
provide a 'Show number of flaky tests' toggle. In the search view,
provide a 'Show test flakiness' toggle. Make the per-dot tag into an
array of information. Toggling all possible tag values on at once will
certainly result in text overlap).

* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/model/suite_context.py:
(SuiteContext.register):
(SuiteContext.register.callback):
* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/timeline.js:
(TimelineFromEndpoint.const.options.prototype.renderFactory):
(result.div.label.Show.test.flakiness.label.label):
(result.div.label.Number.of.flakes.label.label):
* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/templates/search.html:
* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/templates/suite_results.html:

Canonical link: https://commits.webkit.org/252114@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/resultsdb-Expose-reported-flakiness-information-in-the-UI branch from 40a529e to 654dea1 Compare July 4, 2022 12:18
@webkit-commit-queue
Copy link
Collaborator

Committed 252114@main (654dea1): https://commits.webkit.org/252114@main

Reviewed commits have been landed. Closing PR #2051 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 654dea1 into WebKit:main Jul 4, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 4, 2022
@aoikonomopoulos aoikonomopoulos deleted the eng/resultsdb-Expose-reported-flakiness-information-in-the-UI branch July 4, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
3 participants