SourceBufferPrivateClient/MediaSourcePrivateClient should use NativePromise #20513

jyavenard · 2023-11-15T01:29:20Z

`f15fc78`

SourceBufferPrivateClient/MediaSourcePrivateClient should use NativePromise
https://bugs.webkit.org/show_bug.cgi?id=264847
rdar://problem/118426574

Reviewed by Youenn Fablet.

By using NativePromise, the SourceBufferPrivate and MediaSourcePrivate can be made to run on any threads
as NativePromise let you control on which thread the result of an operation should be delivered.

We make all internal SourceBufferPrivate/MediaSourcePrivate methods communicate via their respective
SourceBufferPrivateClient/MediaSourcePrivateClient using NativePromise instead of CompletionHandler.

It also allows to more explicitly handle errors.

The communication between SourceBuffer and SourceBufferPrivate will also be made to use NativePromise
in a follow-up change.

No change in behaviour in WK2, in WK1 some asynchronicity introduced which makes the behaviour more similar
to WK2

* LayoutTests/media/media-source/media-source-restrictions.html: Update test as we've introduced more asynchronicity,
and in WK1 events are fired in a different order (but still per spec). So ensure the events are still fired but
don't log them.
* Source/WebCore/Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::waitForTarget):
(WebCore::MediaSource::completeSeek):
(WebCore::MediaSource::seekToTime):
(WebCore::MediaSource::detachFromElement):
(WebCore::MediaSource::stop):
(WebCore::MediaSource::onReadyStateChange):
* Source/WebCore/Modules/mediasource/MediaSource.h:
* Source/WebCore/Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::computeSeekTime):
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment):
(WebCore::SourceBuffer::sourceBufferPrivateDurationChanged):
(WebCore::SourceBuffer::sourceBufferPrivateBufferedChanged):
* Source/WebCore/Modules/mediasource/SourceBuffer.h:
* Source/WebCore/Modules/webaudio/BaseAudioContext.cpp:
(WebCore::BaseAudioContext::decodeAudioData):
* Source/WebCore/platform/audio/cocoa/AudioFileReaderCocoa.cpp:
(WebCore::AudioFileReader::demuxWebMData const):
* Source/WebCore/platform/graphics/MediaSourcePrivate.h:
* Source/WebCore/platform/graphics/MediaSourcePrivateClient.h:
* Source/WebCore/platform/graphics/SourceBufferPrivate.cpp:
(WebCore::SourceBufferPrivate::setBufferedRanges):
(WebCore::SourceBufferPrivate::updateBufferedFromTrackBuffers):
(WebCore::SourceBufferPrivate::processAppendCompletedOperation):
(WebCore::SourceBufferPrivate::computeSeekTime):
(WebCore::SourceBufferPrivate::removeCodedFrames):
(WebCore::SourceBufferPrivate::didReceiveInitializationSegment):
(WebCore::SourceBufferPrivate::didUpdateFormatDescriptionForTrackId):
(WebCore::SourceBufferPrivate::processPendingOperations):
(WebCore::SourceBufferPrivate::abortPendingOperations):
(WebCore::SourceBufferPrivate::processInitOperation):
(WebCore::SourceBufferPrivate::appendCompleted): Deleted.
* Source/WebCore/platform/graphics/SourceBufferPrivate.h:
(WebCore::SourceBufferPrivate::precheckInitialisationSegment):
(WebCore::SourceBufferPrivate::processInitialisationSegment):
(WebCore::SourceBufferPrivate::processFormatDescriptionForTrackId):
(WebCore::SourceBufferPrivate::updateBufferedFromTrackBuffers): Deleted.
(WebCore::SourceBufferPrivate::setBufferedRanges): Deleted.
* Source/WebCore/platform/graphics/SourceBufferPrivateClient.h:
(WebCore::SourceBufferPrivateClient::isAsync const): Deleted.
* Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekInternal):
* Source/WebCore/platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h:
* Source/WebCore/platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:
(WebCore::MediaSourcePrivateAVFObjC::waitForTarget):
(WebCore::MediaSourcePrivateAVFObjC::seekToTime):
* Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.h:
* Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.mm:
(WebCore::SourceBufferParserAVFObjC::appendData):
(WebCore::SourceBufferParserAVFObjC::didFailToParseStreamDataWithError):
* Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
* Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::setTrackChangeCallbacks):
(WebCore::SourceBufferPrivateAVFObjC::didParseInitializationData):
(WebCore::SourceBufferPrivateAVFObjC::precheckInitialisationSegment):
(WebCore::SourceBufferPrivateAVFObjC::processInitialisationSegment):
(WebCore::SourceBufferPrivateAVFObjC::processFormatDescriptionForTrackId):
(WebCore::SourceBufferPrivateAVFObjC::appendInternal):
(WebCore::SourceBufferPrivateAVFObjC::appendCompleted):
(WebCore::SourceBufferPrivateAVFObjC::didEncounterErrorDuringParsing): Deleted.
(WebCore::SourceBufferPrivateAVFObjC::didUpdateFormatDescriptionForTrackId): Deleted.
* Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.h:
* Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm:
(WebCore::MediaPlayerPrivateWebM::~MediaPlayerPrivateWebM):
(WebCore::MediaPlayerPrivateWebM::append):
(WebCore::MediaPlayerPrivateWebM::didEncounterErrorDuringParsing): Deleted.
(WebCore::MediaPlayerPrivateWebM::abort): Deleted.
* Source/WebCore/platform/graphics/cocoa/SourceBufferParser.h:
* Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp:
(WebCore::SourceBufferParserWebM::appendData):
* Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.h:
(WebCore::SourceBufferParserWebM::appendData): Deleted.
* Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
(WebCore::MediaPlayerPrivateGStreamerMSE::doSeek):
* Source/WebCore/platform/graphics/gstreamer/mse/MediaSourcePrivateGStreamer.cpp:
(WebCore::MediaSourcePrivateGStreamer::waitForTarget):
(WebCore::MediaSourcePrivateGStreamer::seekToTime):
* Source/WebCore/platform/graphics/gstreamer/mse/MediaSourcePrivateGStreamer.h:
* Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:
(WebCore::SourceBufferPrivateGStreamer::appendInternal):
(WebCore::SourceBufferPrivateGStreamer::didReceiveInitializationSegment):
(WebCore::SourceBufferPrivateGStreamer::precheckInitialisationSegment):
(WebCore::SourceBufferPrivateGStreamer::processInitialisationSegment):
(WebCore::SourceBufferPrivateGStreamer::didReceiveAllPendingSamples):
(WebCore::SourceBufferPrivateGStreamer::appendParsingFailed):
* Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h:
* Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:
(WebCore::MockMediaPlayerMediaSource::seekToTarget):
* Source/WebCore/platform/mock/mediasource/MockMediaSourcePrivate.cpp:
(WebCore::MockMediaSourcePrivate::waitForTarget):
(WebCore::MockMediaSourcePrivate::seekToTime):
* Source/WebCore/platform/mock/mediasource/MockMediaSourcePrivate.h:
* Source/WebCore/platform/mock/mediasource/MockSourceBufferPrivate.cpp:
(WebCore::MockSourceBufferPrivate::appendInternal):
(WebCore::MockSourceBufferPrivate::didReceiveInitializationSegment):
* Source/WebCore/platform/mock/mediasource/MockSourceBufferPrivate.h:
* Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.cpp:
(WebKit::RemoteMediaSourceProxy::waitForTarget):
(WebKit::RemoteMediaSourceProxy::seekToTime):
* Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.h:
* Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.cpp:
(WebKit::RemoteSourceBufferProxy::sourceBufferPrivateDidReceiveInitializationSegment):
(WebKit::RemoteSourceBufferProxy::sourceBufferPrivateDurationChanged):
(WebKit::RemoteSourceBufferProxy::sourceBufferPrivateBufferedChanged):
(WebKit::RemoteSourceBufferProxy::computeSeekTime):
* Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.h:
* Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.messages.in:
* Source/WebKit/WebProcess/GPU/media/MediaSourcePrivateRemote.cpp:
(WebKit::MediaSourcePrivateRemote::waitForTarget):
(WebKit::MediaSourcePrivateRemote::proxyWaitForTarget):
(WebKit::MediaSourcePrivateRemote::seekToTime):
(WebKit::MediaSourcePrivateRemote::proxySeekToTime):
* Source/WebKit/WebProcess/GPU/media/MediaSourcePrivateRemote.h:
* Source/WebKit/WebProcess/GPU/media/MediaSourcePrivateRemote.messages.in:
* Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.cpp:
(WebKit::SourceBufferPrivateRemote::appendInternal):
(WebKit::SourceBufferPrivateRemote::removeCodedFrames):
(WebKit::SourceBufferPrivateRemote::computeSeekTime):
(WebKit::SourceBufferPrivateRemote::sourceBufferPrivateDidReceiveInitializationSegment):
(WebKit::SourceBufferPrivateRemote::sourceBufferPrivateDurationChanged):
(WebKit::SourceBufferPrivateRemote::sourceBufferPrivateBufferedChanged):
* Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.h:
* Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.messages.in:

Canonical link: https://commits.webkit.org/270788@main

cbf4e77

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-11-15T01:31:10Z

EWS run on previous version of this PR (hash 47d30c7)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

jyavenard · 2023-11-15T06:23:37Z

unrelated build failure ```
accessibility/display-contents/aria-grid.html, animations/3d/animate-to-transform-perpective-to-none.html

youennf · 2023-11-15T08:12:44Z

Source/WebCore/Modules/mediasource/MediaSource.cpp

-            , completionHandler(WTFMove(completionHandler))
-        {
-            ASSERT(this->completionHandler);
+    Ref<MediaTimePromise> promise = SourceBuffer::ComputeSeekPromise::all(RunLoop::main(), WTF::map(*m_activeSourceBuffers, [&](auto&& sourceBuffer) {


We usually only use RunLoop::main() on WK2 code since there is the web thread on WK1.
RunLoop::current() might be better.
Ditto elsewhere probably

The aim here will be to set the thread where we will run as a class member. Right now it's the main thread. MaybE I should use WorkQueue::main() instead

FYI: RunLoop::main() will be the main thread, even on iOS WK1. WorkQueue::main() will also be the main thread. callOnMainThread() will run on the Web Thread (not the main thread, or the UI thread).

youennf · 2023-11-15T08:22:17Z

Source/WebCore/Modules/mediasource/MediaSource.cpp

-        m_seekCompletedHandler(MediaTime::invalidTime());
+    if (m_seekTargetPromise)
+        m_seekTargetPromise->reject(-1);
+    m_seekTargetPromise.reset();


You could reset in the if block.

youennf · 2023-11-15T08:23:49Z

Source/WebCore/Modules/mediasource/SourceBuffer.cpp

@@ -697,12 +696,10 @@ void SourceBuffer::setActive(bool active)
        m_source->sourceBufferDidChangeActiveState(*this, active);
 }

-void SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment(InitializationSegment&& segment, CompletionHandler<void(ReceiveResult)>&& completionHandler)
+auto SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment(InitializationSegment&& segment) -> Ref<ReceiveResultPromise>


Why auto for sourceBufferPrivateDidReceiveInitializationSegment and not for computeSeekTime (or the reverse)?

Because it makes for a shorter writing :)

Otherwise I have to write the fully qualified type name

youennf · 2023-11-15T08:24:41Z

Source/WebCore/Modules/mediasource/MediaSource.cpp

-        return;
-    }
+    if (isClosed())
+        return MediaTimePromise::createAndReject(-1);


Should we define a constant instead?

I'm replacing this with a constant in part 4 with a PlatformMediaError

youennf · 2023-11-15T08:28:31Z

Source/WebCore/platform/audio/cocoa/AudioFileReaderCocoa.cpp

-    if (!track || error)
+    auto promise = parser->appendData(WTFMove(segment));
+    ASSERT(promise->isSettled());
+    if (!track || !promise->isResolved())


Why a promise if it should be resolved synchronously? The previous code seems better.

The SourceBufferParser has two mode of operations. One synchronous like here. And one as used by the SourceBuffer where you define the thread on which the callbacks will be called. That is asynchronous.

We should make the webaudio decoder fully asynchronous too. But it was out of scope for this change.

I've made SourceBufferParser::appendData return an Expected<void, int> instead so that it can be used synchronously. Will migrate in a follow-up change

youennf · 2023-11-15T08:32:52Z

Source/WebCore/platform/graphics/SourceBufferPrivate.cpp

+            // duration set to the maximum of the current duration and the group end timestamp.
+            promises.append(m_client->sourceBufferPrivateDurationChanged(m_groupEndTimestamp));
+        }
+        m_client->sourceBufferPrivateReportExtraMemoryCost(totalTrackBufferSizeInBytes());


There's a change of timing, we are now calling this synchronously, while before it could be called asynchronously.
Is this right?

Sending the report to how much memory is used can be done at any time. Previously we serialised the operation, now we run them in parallel because Native Promise::all allows to conveniently do so.
The order of operation here doesn't matter. We only need them to happen before we complete the appendBuffer operation

youennf · 2023-11-15T08:38:25Z

Source/WebCore/platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm

-    m_client->seekToTime(time, WTFMove(completionHandler));
+    if (!m_client)
+        return GenericPromise::createAndReject(-1);
+    return m_client->seekToTime(time);


One liner ?

youennf · 2023-11-15T08:38:37Z

Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.mm

+
+    if (m_lastErrorCode)
+        return GenericPromise::createAndReject(m_lastErrorCode.value());
+    return GenericPromise::createAndResolve();


one liner ?

youennf · 2023-11-15T08:48:12Z

Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm

-            });
-        });
+    return invokeAsync(m_appendQueue, [data = WTFMove(data), parser = m_parser]() mutable {
+        return parser->appendData(WTFMove(data));


Ah I see why you changed to a promise.
If it is the only use of a promise, maybe you could promisify the synchronous result directly?

No. All the callbacks are called asynchronously too

youennf · 2023-11-15T08:53:49Z

Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.cpp

-        return;
-    }
+    if (!m_remoteMediaPlayerProxy)
+        ReceiveResultPromise::createAndReject(ReceiveResult::ClientDisconnected);


Shouldn't we return here?

oh, good spotting, thanks

webkit-early-warning-system · 2023-11-15T12:22:20Z

EWS run on previous version of this PR (hash 148c357)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	✅ 🛠 gtk
	⏳ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🧪 api-gtk~~
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	~~🧪 mac-wk2-stress~~
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-11-15T12:35:05Z

EWS run on current version of this PR (hash cbf4e77)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
⏳ 🧪 style	🛠 ios	🛠 mac	🛠 wpe	🛠 wincairo
🧪 bindings	🛠 ios-sim	🛠 mac-AS-debug	🧪 wpe-wk2
🧪 webkitperl	🧪 ios-wk2	🧪 api-mac	🛠 gtk
	🧪 ios-wk2-wpt	🧪 mac-wk1	🧪 gtk-wk2
	🧪 api-ios	🧪 mac-wk2	🧪 api-gtk
	⏳ 🛠 tv	🧪 mac-AS-debug-wk2
🧪 services	🛠 tv-sim	🧪 mac-wk2-stress
	⏳ 🛠 watch
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2023-11-15T12:35:06Z

EWS run on current version of this PR (hash cbf4e77)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

…romise https://bugs.webkit.org/show_bug.cgi?id=264847 rdar://problem/118426574 Reviewed by Youenn Fablet. By using NativePromise, the SourceBufferPrivate and MediaSourcePrivate can be made to run on any threads as NativePromise let you control on which thread the result of an operation should be delivered. We make all internal SourceBufferPrivate/MediaSourcePrivate methods communicate via their respective SourceBufferPrivateClient/MediaSourcePrivateClient using NativePromise instead of CompletionHandler. It also allows to more explicitly handle errors. The communication between SourceBuffer and SourceBufferPrivate will also be made to use NativePromise in a follow-up change. No change in behaviour in WK2, in WK1 some asynchronicity introduced which makes the behaviour more similar to WK2 * LayoutTests/media/media-source/media-source-restrictions.html: Update test as we've introduced more asynchronicity, and in WK1 events are fired in a different order (but still per spec). So ensure the events are still fired but don't log them. * Source/WebCore/Modules/mediasource/MediaSource.cpp: (WebCore::MediaSource::waitForTarget): (WebCore::MediaSource::completeSeek): (WebCore::MediaSource::seekToTime): (WebCore::MediaSource::detachFromElement): (WebCore::MediaSource::stop): (WebCore::MediaSource::onReadyStateChange): * Source/WebCore/Modules/mediasource/MediaSource.h: * Source/WebCore/Modules/mediasource/SourceBuffer.cpp: (WebCore::SourceBuffer::computeSeekTime): (WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment): (WebCore::SourceBuffer::sourceBufferPrivateDurationChanged): (WebCore::SourceBuffer::sourceBufferPrivateBufferedChanged): * Source/WebCore/Modules/mediasource/SourceBuffer.h: * Source/WebCore/Modules/webaudio/BaseAudioContext.cpp: (WebCore::BaseAudioContext::decodeAudioData): * Source/WebCore/platform/audio/cocoa/AudioFileReaderCocoa.cpp: (WebCore::AudioFileReader::demuxWebMData const): * Source/WebCore/platform/graphics/MediaSourcePrivate.h: * Source/WebCore/platform/graphics/MediaSourcePrivateClient.h: * Source/WebCore/platform/graphics/SourceBufferPrivate.cpp: (WebCore::SourceBufferPrivate::setBufferedRanges): (WebCore::SourceBufferPrivate::updateBufferedFromTrackBuffers): (WebCore::SourceBufferPrivate::processAppendCompletedOperation): (WebCore::SourceBufferPrivate::computeSeekTime): (WebCore::SourceBufferPrivate::removeCodedFrames): (WebCore::SourceBufferPrivate::didReceiveInitializationSegment): (WebCore::SourceBufferPrivate::didUpdateFormatDescriptionForTrackId): (WebCore::SourceBufferPrivate::processPendingOperations): (WebCore::SourceBufferPrivate::abortPendingOperations): (WebCore::SourceBufferPrivate::processInitOperation): (WebCore::SourceBufferPrivate::appendCompleted): Deleted. * Source/WebCore/platform/graphics/SourceBufferPrivate.h: (WebCore::SourceBufferPrivate::precheckInitialisationSegment): (WebCore::SourceBufferPrivate::processInitialisationSegment): (WebCore::SourceBufferPrivate::processFormatDescriptionForTrackId): (WebCore::SourceBufferPrivate::updateBufferedFromTrackBuffers): Deleted. (WebCore::SourceBufferPrivate::setBufferedRanges): Deleted. * Source/WebCore/platform/graphics/SourceBufferPrivateClient.h: (WebCore::SourceBufferPrivateClient::isAsync const): Deleted. * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekInternal): * Source/WebCore/platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h: * Source/WebCore/platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm: (WebCore::MediaSourcePrivateAVFObjC::waitForTarget): (WebCore::MediaSourcePrivateAVFObjC::seekToTime): * Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.h: * Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.mm: (WebCore::SourceBufferParserAVFObjC::appendData): (WebCore::SourceBufferParserAVFObjC::didFailToParseStreamDataWithError): * Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h: * Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm: (WebCore::SourceBufferPrivateAVFObjC::setTrackChangeCallbacks): (WebCore::SourceBufferPrivateAVFObjC::didParseInitializationData): (WebCore::SourceBufferPrivateAVFObjC::precheckInitialisationSegment): (WebCore::SourceBufferPrivateAVFObjC::processInitialisationSegment): (WebCore::SourceBufferPrivateAVFObjC::processFormatDescriptionForTrackId): (WebCore::SourceBufferPrivateAVFObjC::appendInternal): (WebCore::SourceBufferPrivateAVFObjC::appendCompleted): (WebCore::SourceBufferPrivateAVFObjC::didEncounterErrorDuringParsing): Deleted. (WebCore::SourceBufferPrivateAVFObjC::didUpdateFormatDescriptionForTrackId): Deleted. * Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.h: * Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm: (WebCore::MediaPlayerPrivateWebM::~MediaPlayerPrivateWebM): (WebCore::MediaPlayerPrivateWebM::append): (WebCore::MediaPlayerPrivateWebM::didEncounterErrorDuringParsing): Deleted. (WebCore::MediaPlayerPrivateWebM::abort): Deleted. * Source/WebCore/platform/graphics/cocoa/SourceBufferParser.h: * Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp: (WebCore::SourceBufferParserWebM::appendData): * Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.h: (WebCore::SourceBufferParserWebM::appendData): Deleted. * Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp: (WebCore::MediaPlayerPrivateGStreamerMSE::doSeek): * Source/WebCore/platform/graphics/gstreamer/mse/MediaSourcePrivateGStreamer.cpp: (WebCore::MediaSourcePrivateGStreamer::waitForTarget): (WebCore::MediaSourcePrivateGStreamer::seekToTime): * Source/WebCore/platform/graphics/gstreamer/mse/MediaSourcePrivateGStreamer.h: * Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp: (WebCore::SourceBufferPrivateGStreamer::appendInternal): (WebCore::SourceBufferPrivateGStreamer::didReceiveInitializationSegment): (WebCore::SourceBufferPrivateGStreamer::precheckInitialisationSegment): (WebCore::SourceBufferPrivateGStreamer::processInitialisationSegment): (WebCore::SourceBufferPrivateGStreamer::didReceiveAllPendingSamples): (WebCore::SourceBufferPrivateGStreamer::appendParsingFailed): * Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h: * Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.cpp: (WebCore::MockMediaPlayerMediaSource::seekToTarget): * Source/WebCore/platform/mock/mediasource/MockMediaSourcePrivate.cpp: (WebCore::MockMediaSourcePrivate::waitForTarget): (WebCore::MockMediaSourcePrivate::seekToTime): * Source/WebCore/platform/mock/mediasource/MockMediaSourcePrivate.h: * Source/WebCore/platform/mock/mediasource/MockSourceBufferPrivate.cpp: (WebCore::MockSourceBufferPrivate::appendInternal): (WebCore::MockSourceBufferPrivate::didReceiveInitializationSegment): * Source/WebCore/platform/mock/mediasource/MockSourceBufferPrivate.h: * Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.cpp: (WebKit::RemoteMediaSourceProxy::waitForTarget): (WebKit::RemoteMediaSourceProxy::seekToTime): * Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.h: * Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.cpp: (WebKit::RemoteSourceBufferProxy::sourceBufferPrivateDidReceiveInitializationSegment): (WebKit::RemoteSourceBufferProxy::sourceBufferPrivateDurationChanged): (WebKit::RemoteSourceBufferProxy::sourceBufferPrivateBufferedChanged): (WebKit::RemoteSourceBufferProxy::computeSeekTime): * Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.h: * Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.messages.in: * Source/WebKit/WebProcess/GPU/media/MediaSourcePrivateRemote.cpp: (WebKit::MediaSourcePrivateRemote::waitForTarget): (WebKit::MediaSourcePrivateRemote::proxyWaitForTarget): (WebKit::MediaSourcePrivateRemote::seekToTime): (WebKit::MediaSourcePrivateRemote::proxySeekToTime): * Source/WebKit/WebProcess/GPU/media/MediaSourcePrivateRemote.h: * Source/WebKit/WebProcess/GPU/media/MediaSourcePrivateRemote.messages.in: * Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.cpp: (WebKit::SourceBufferPrivateRemote::appendInternal): (WebKit::SourceBufferPrivateRemote::removeCodedFrames): (WebKit::SourceBufferPrivateRemote::computeSeekTime): (WebKit::SourceBufferPrivateRemote::sourceBufferPrivateDidReceiveInitializationSegment): (WebKit::SourceBufferPrivateRemote::sourceBufferPrivateDurationChanged): (WebKit::SourceBufferPrivateRemote::sourceBufferPrivateBufferedChanged): * Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.h: * Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.messages.in: Canonical link: https://commits.webkit.org/270788@main

webkit-commit-queue · 2023-11-15T21:55:35Z

Committed 270788@main (f15fc78): https://commits.webkit.org/270788@main

Reviewed commits have been landed. Closing PR #20513 and removing active labels.

jyavenard requested review from philn and cdumez as code owners November 15, 2023 01:29

jyavenard self-assigned this Nov 15, 2023

jyavenard added the Media Bugs related to the HTML 5 Media elements. label Nov 15, 2023

jyavenard requested review from jernoble and youennf November 15, 2023 01:29

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 15, 2023

youennf approved these changes Nov 15, 2023

View reviewed changes

jyavenard removed the merging-blocked Applied to prevent a change from being merged label Nov 15, 2023

jyavenard force-pushed the bz/264847_SourceBufferPrivateClient/MediaSourcePrivateClient_should_use_NativePromise branch from 47d30c7 to 148c357 Compare November 15, 2023 12:21

jyavenard added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Nov 15, 2023

jyavenard force-pushed the bz/264847_SourceBufferPrivateClient/MediaSourcePrivateClient_should_use_NativePromise branch from 148c357 to cbf4e77 Compare November 15, 2023 12:34

webkit-commit-queue force-pushed the bz/264847_SourceBufferPrivateClient/MediaSourcePrivateClient_should_use_NativePromise branch from cbf4e77 to 57f069d Compare November 15, 2023 21:51

webkit-commit-queue force-pushed the bz/264847_SourceBufferPrivateClient/MediaSourcePrivateClient_should_use_NativePromise branch from 57f069d to f15fc78 Compare November 15, 2023 21:55

webkit-commit-queue merged commit f15fc78 into WebKit:main Nov 15, 2023

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SourceBufferPrivateClient/MediaSourcePrivateClient should use NativePromise #20513

SourceBufferPrivateClient/MediaSourcePrivateClient should use NativePromise #20513

jyavenard commented Nov 15, 2023 •

edited by webkit-early-warning-system

Loading

webkit-early-warning-system commented Nov 15, 2023 •

edited

Loading

jyavenard commented Nov 15, 2023

youennf Nov 15, 2023

jyavenard Nov 15, 2023 •

edited

Loading

jyavenard Nov 15, 2023

jernoble Nov 15, 2023

youennf Nov 15, 2023

youennf Nov 15, 2023

jyavenard Nov 15, 2023

youennf Nov 15, 2023

jyavenard Nov 15, 2023

youennf Nov 15, 2023

jyavenard Nov 15, 2023

jyavenard Nov 15, 2023

youennf Nov 15, 2023

jyavenard Nov 15, 2023 •

edited

Loading

youennf Nov 15, 2023

youennf Nov 15, 2023

youennf Nov 15, 2023

jyavenard Nov 15, 2023

youennf Nov 15, 2023

jyavenard Nov 15, 2023

webkit-early-warning-system commented Nov 15, 2023 •

edited

Loading

webkit-early-warning-system commented Nov 15, 2023 •

edited

Loading

webkit-early-warning-system commented Nov 15, 2023 •

edited

Loading

webkit-commit-queue commented Nov 15, 2023

SourceBufferPrivateClient/MediaSourcePrivateClient should use NativePromise #20513

SourceBufferPrivateClient/MediaSourcePrivateClient should use NativePromise #20513

Conversation

jyavenard commented Nov 15, 2023 • edited by webkit-early-warning-system Loading

webkit-early-warning-system commented Nov 15, 2023 • edited Loading

jyavenard commented Nov 15, 2023

Choose a reason for hiding this comment

jyavenard Nov 15, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jyavenard Nov 15, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

webkit-early-warning-system commented Nov 15, 2023 • edited Loading

webkit-early-warning-system commented Nov 15, 2023 • edited Loading

webkit-early-warning-system commented Nov 15, 2023 • edited Loading

webkit-commit-queue commented Nov 15, 2023

jyavenard commented Nov 15, 2023 •

edited by webkit-early-warning-system

Loading

webkit-early-warning-system commented Nov 15, 2023 •

edited

Loading

jyavenard Nov 15, 2023 •

edited

Loading

jyavenard Nov 15, 2023 •

edited

Loading

webkit-early-warning-system commented Nov 15, 2023 •

edited

Loading

webkit-early-warning-system commented Nov 15, 2023 •

edited

Loading

webkit-early-warning-system commented Nov 15, 2023 •

edited

Loading