Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FreeType] Add an implementation for FontPlatformData::familyName() #2053

Merged
merged 1 commit into from Jul 5, 2022
Merged

[FreeType] Add an implementation for FontPlatformData::familyName() #2053

merged 1 commit into from Jul 5, 2022

Conversation

carlosgcampos
Copy link
Contributor

@carlosgcampos carlosgcampos commented Jul 4, 2022 •
edited by webkit-commit-queue

3db5943

[FreeType] Add an implementation for FontPlatformData::familyName()
https://bugs.webkit.org/show_bug.cgi?id=242310

Reviewed by Michael Catanzaro.

This will make the font name to be shown in the inspector.

* Source/WebCore/platform/graphics/FontPlatformData.cpp:
* Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp:
(WebCore::FontPlatformData::familyName const):

Canonical link: https://commits.webkit.org/252129@main

@carlosgcampos carlosgcampos self-assigned this Jul 4, 2022
@carlosgcampos carlosgcampos added Platform Portability improvements and other general platform improvements not driven directly by site bugs. WebKit Nightly Build labels Jul 4, 2022
@carlosgcampos carlosgcampos changed the title [FreeType] Add an implementation for Font name not shown in the inspector [FreeType] Add an implementation for FontPlatformData::familyName() Jul 4, 2022
@carlosgcampos carlosgcampos added the merge-queue Applied to send a pull request to merge-queue label Jul 5, 2022
@carlosgcampos
[FreeType] Add an implementation for FontPlatformData::familyName()
3db5943 
https://bugs.webkit.org/show_bug.cgi?id=242310

Reviewed by Michael Catanzaro.

This will make the font name to be shown in the inspector.

* Source/WebCore/platform/graphics/FontPlatformData.cpp:
* Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp:
(WebCore::FontPlatformData::familyName const):

Canonical link: https://commits.webkit.org/252129@main
@webkit-commit-queue
Copy link
Collaborator

Committed 252129@main (3db5943): https://commits.webkit.org/252129@main

Reviewed commits have been landed. Closing PR #2053 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 3db5943 into WebKit:main Jul 5, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 5, 2022
@carlosgcampos carlosgcampos deleted the inspector-font-name branch July 5, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcatanzaro mcatanzaro mcatanzaro approved these changes

@aperezdc aperezdc Awaiting requested review from aperezdc

Assignees

@carlosgcampos carlosgcampos

Labels
Platform Portability improvements and other general platform improvements not driven directly by site bugs.
Projects
None yet
Milestone
No milestone
4 participants
@carlosgcampos @webkit-commit-queue @mcatanzaro @webkit-early-warning-system