Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alternate WebM Player] Allow device sleep during playback #2059

Merged
merged 1 commit into from Jul 4, 2022
Merged

[Alternate WebM Player] Allow device sleep during playback #2059

merged 1 commit into from Jul 4, 2022

Conversation

youssefsoli
Copy link
Contributor

@youssefsoli youssefsoli commented Jul 4, 2022 •
edited by webkit-commit-queue

f7c86d5

[Alternate WebM Player] Allow device sleep during playback
https://bugs.webkit.org/show_bug.cgi?id=242317

Reviewed by Jer Noble.

Currently the AVSampleBufferDisplayLayer will prevent the display from
sleeping by default. However, in order to improve battery life on devices,
the display should be able to sleep regardless of whether or not a video
is playing within the layer.

* Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm:
(WebCore::MediaPlayerPrivateWebM::ensureLayer):

Canonical link: https://commits.webkit.org/252123@main

@youssefsoli youssefsoli added Media Bugs related to the HTML 5 Media elements. WebKit Nightly Build labels Jul 4, 2022
@youssefsoli youssefsoli self-assigned this Jul 4, 2022
jernoble
jernoble approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@jernoble jernoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@youssefsoli youssefsoli added the merge-queue Applied to send a pull request to merge-queue label Jul 4, 2022
@youssefsoli
[Alternate WebM Player] Allow device sleep during playback
f7c86d5 
https://bugs.webkit.org/show_bug.cgi?id=242317

Reviewed by Jer Noble.

Currently the AVSampleBufferDisplayLayer will prevent the display from
sleeping by default. However, in order to improve battery life on devices,
the display should be able to sleep regardless of whether or not a video
is playing within the layer.

* Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm:
(WebCore::MediaPlayerPrivateWebM::ensureLayer):

Canonical link: https://commits.webkit.org/252123@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Alternate-WebM-Player-Allow-device-sleep-during-playback branch from 14a4c36 to f7c86d5 Compare July 4, 2022 19:19
@webkit-commit-queue
Copy link
Collaborator

Committed 252123@main (f7c86d5): https://commits.webkit.org/252123@main

Reviewed commits have been landed. Closing PR #2059 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit f7c86d5 into WebKit:main Jul 4, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jernoble jernoble jernoble approved these changes

@jyavenard jyavenard Awaiting requested review from jyavenard

@eric-carlson eric-carlson Awaiting requested review from eric-carlson

Assignees

@youssefsoli youssefsoli

Labels
Media Bugs related to the HTML 5 Media elements.
Projects
None yet
Milestone
No milestone
4 participants
@youssefsoli @webkit-commit-queue @jernoble @webkit-early-warning-system