[GStreamer][WebRTC] Additional data-channel improvements and initial layout tests coverage #2060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philn
added
Platform
calvaris
approved these changes
Jul 5, 2022
…layout tests coverage https://bugs.webkit.org/show_bug.cgi?id=242177 Reviewed by Xabier Rodriguez-Calvar. This patch improves logging support in the data-channel handler, cleans up the data-channel creation code, bringing it on-par with the libwebrtc backend and includes various bugfixes needed for layout tests compliance. The most significant feature gaps in the data-channel handler are now: - Incomplete stats reporting - DTLS 1.2 certificates support missing - ICE candidates filtering unimplemented * LayoutTests/platform/glib/TestExpectations: * LayoutTests/webrtc/datachannel/bufferedAmountLowThreshold.html: * Source/WebCore/Modules/mediastream/gstreamer/GStreamerDataChannelHandler.cpp: (WebCore::GStreamerDataChannelHandler::GStreamerDataChannelHandler): (WebCore::GStreamerDataChannelHandler::~GStreamerDataChannelHandler): (WebCore::GStreamerDataChannelHandler::dataChannelInit const): (WebCore::GStreamerDataChannelHandler::label const): (WebCore::GStreamerDataChannelHandler::setClient): (WebCore::GStreamerDataChannelHandler::sendStringData): (WebCore::GStreamerDataChannelHandler::sendRawData): (WebCore::GStreamerDataChannelHandler::close): (WebCore::GStreamerDataChannelHandler::checkState): (WebCore::GStreamerDataChannelHandler::bufferedAmountChanged): (WebCore::GStreamerDataChannelHandler::onMessageData): (WebCore::GStreamerDataChannelHandler::onMessageString): (WebCore::GStreamerDataChannelHandler::onClose): (WebCore::GStreamerDataChannelHandler::createDataChannelEvent): Deleted. * Source/WebCore/Modules/mediastream/gstreamer/GStreamerDataChannelHandler.h: * Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp: (WebCore::GStreamerMediaEndpoint::initializePipeline): (WebCore::GStreamerMediaEndpoint::prepareDataChannel): (WebCore::GStreamerMediaEndpoint::findOrCreateIncomingChannelHandler): (WebCore::GStreamerMediaEndpoint::onDataChannel): (WebCore::GStreamerMediaEndpoint::close): (WebCore::GStreamerMediaEndpoint::~GStreamerMediaEndpoint): Deleted. * Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.h: * Source/WebCore/Modules/mediastream/gstreamer/GStreamerSctpTransportBackend.cpp: (WebCore::GStreamerSctpTransportBackend::GStreamerSctpTransportBackend): (WebCore::GStreamerSctpTransportBackend::stateChanged): Canonical link: https://commits.webkit.org/252131@main
webkit-early-warning-system
force-pushed
the
eng/242177
branch
from
9e4768f
to
5e8ab8c
Compare
|
Committed 252131@main (5e8ab8c): https://commits.webkit.org/252131@main Reviewed commits have been landed. Closing PR #2060 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5e8ab8c