-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WASM-Function-References] Improve type printing for reference types #20611
[WASM-Function-References] Improve type printing for reference types #20611
Conversation
EWS run on previous version of this PR (hash c566707) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me
c566707
to
55cb9c0
Compare
EWS run on current version of this PR (hash 55cb9c0) |
Safe-Merge-Queue: Build #3920. |
55cb9c0
to
6655c50
Compare
https://bugs.webkit.org/show_bug.cgi?id=247746 Reviewed by Justin Michaud. Print reftypes when typed funcrefs are enabled in (ref null? kind) format where `kind` is either a heap type (e.g., `i31`, `struct`) or a concrete type index (e.g., `<struct:0>`, `<func:3>`). This printing is only used for validation errors for now, as it relies on being able to access the ModuleInformation. * JSTests/wasm/function-references/local_init.js: (async testLocalInit): * JSTests/wasm/function-references/ref_types.js: (async testNonNullExternrefIncompatible): (async testNonNullFuncrefIncompatible): * JSTests/wasm/gc/any.js: (testValidation): (testNullfuncref): (testNullexternref): * JSTests/wasm/gc/arrays.js: (testArrayDeclaration): * JSTests/wasm/gc/casts.js: (testFunctionCasts): (testEqCasts): * JSTests/wasm/gc/const-exprs.js: (async testInvalidConstExprs): * JSTests/wasm/gc/i31.js: (testI31Get): * JSTests/wasm/gc/rec.js: (testRecDeclaration): * JSTests/wasm/gc/structs.js: (testStructDeclaration): * JSTests/wasm/gc/sub.js: (testSubDeclaration): * Source/JavaScriptCore/wasm/WasmFormat.h: (JSC::Wasm::heapTypeKindAsString): * Source/JavaScriptCore/wasm/WasmFunctionParser.h: (JSC::Wasm::FunctionParser::validationFail const): (JSC::Wasm::FunctionParser::validationFailHelper const): (JSC::Wasm::FunctionParser::typeToStringModuleRelative const): Canonical link: https://commits.webkit.org/270988@main
6655c50
to
fd12481
Compare
Committed 270988@main (fd12481): https://commits.webkit.org/270988@main Reviewed commits have been landed. Closing PR #20611 and removing active labels. |
fd12481
55cb9c0