SharedVideoFrameWriter can hang on its semaphore in case of bad CVPixelBuffers #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youennf
added
Media
eric-carlson
approved these changes
Jul 5, 2022
…elBuffers https://bugs.webkit.org/show_bug.cgi?id=242334 rdar://95326241 Reviewed by Eric Carlson. Before writing to shared memory, the writer is waiting on its counterpart reader to signal that memory can be written. This works fine except if the writer fails to write data, in which case the reader will not notify that memory can be written. Write failure for instance happens if data cannot be read from the pixel buffer. To fix this, the writer will signal its semaphore that it does not need to wait in case of write failure. * Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.cpp: (WebKit::SharedVideoFrameWriter::wait): (WebKit::SharedVideoFrameWriter::prepareWriting): (WebKit::SharedVideoFrameWriter::writeBuffer): (WebKit::SharedVideoFrameWriter::signalInCaseOfError): * Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.h: Canonical link: https://commits.webkit.org/252136@main
webkit-early-warning-system
force-pushed
the
eng/SharedVideoFrameWriter-can-hang-on-its-semaphore-in-case-of-bad-CVPixelBuffers
branch
from
5a6a6a7
to
688b368
Compare
|
Committed 252137@main (b823acb): https://commits.webkit.org/252137@main Reviewed commits have been landed. Closing PR #2072 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
688b368