Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FontFace with data: URI crashes Worker #20742

Conversation

youennf
Copy link
Contributor

@youennf youennf commented Nov 20, 2023

b1f4d81

FontFace with data: URI crashes Worker
https://bugs.webkit.org/show_bug.cgi?id=265000
rdar://118546120

Reviewed by Alex Christensen.

Make sure to reject the promise when font loading fails in a worker.
Align implementation with spec on data URL font loading by allowing them.

* LayoutTests/http/wpt/workers/font-loading-error.any-expected.txt: Added.
* LayoutTests/http/wpt/workers/font-loading-error.any.html: Added.
* LayoutTests/http/wpt/workers/font-loading-error.any.js: Added.
(promise_test.async return):
(promise_test):
* LayoutTests/http/wpt/workers/font-loading-error.any.worker-expected.txt: Added.
* LayoutTests/http/wpt/workers/font-loading-error.any.worker.html: Added.
* Source/WebCore/dom/DocumentFontLoader.cpp:
(WebCore::DocumentFontLoader::cachedFont):
* Source/WebCore/workers/WorkerFontLoadRequest.cpp:
(WebCore::WorkerFontLoadRequest::load):
(WebCore::WorkerFontLoadRequest::didFail):

Canonical link: https://commits.webkit.org/271213@main

f8fecd2

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ api-wpe
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ›  gtk
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-wk2-stress
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@youennf youennf self-assigned this Nov 20, 2023
@youennf youennf added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Nov 20, 2023
@youennf youennf added the merge-queue Applied to send a pull request to merge-queue label Nov 28, 2023
https://bugs.webkit.org/show_bug.cgi?id=265000
rdar://118546120

Reviewed by Alex Christensen.

Make sure to reject the promise when font loading fails in a worker.
Align implementation with spec on data URL font loading by allowing them.

* LayoutTests/http/wpt/workers/font-loading-error.any-expected.txt: Added.
* LayoutTests/http/wpt/workers/font-loading-error.any.html: Added.
* LayoutTests/http/wpt/workers/font-loading-error.any.js: Added.
(promise_test.async return):
(promise_test):
* LayoutTests/http/wpt/workers/font-loading-error.any.worker-expected.txt: Added.
* LayoutTests/http/wpt/workers/font-loading-error.any.worker.html: Added.
* Source/WebCore/dom/DocumentFontLoader.cpp:
(WebCore::DocumentFontLoader::cachedFont):
* Source/WebCore/workers/WorkerFontLoadRequest.cpp:
(WebCore::WorkerFontLoadRequest::load):
(WebCore::WorkerFontLoadRequest::didFail):

Canonical link: https://commits.webkit.org/271213@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/FontFace-with-data-URI-crashes-Worker branch from f8fecd2 to b1f4d81 Compare November 28, 2023 15:43
@webkit-commit-queue
Copy link
Collaborator

Committed 271213@main (b1f4d81): https://commits.webkit.org/271213@main

Reviewed commits have been landed. Closing PR #20742 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit b1f4d81 into WebKit:main Nov 28, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
4 participants