Remove IOSFormControlRefreshEnabled preference (and IOS_FORM_CONTROL_REFRESH) #20746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
added
the
WebCore Misc.
This comment was marked as outdated.
This comment was marked as outdated.
webkit-ews-buildbot
added
the
merging-blocked
annevk
added
skip-ews
annevk
force-pushed
the
eng/Remove-IOSFormControlRefreshEnabled-preference-and-IOS_FORM_CONTROL_REFRESH
branch
from
68cfc1d
to
7d5f875
Compare
This comment was marked as outdated.
This comment was marked as outdated.
webkit-ews-buildbot
added
the
merging-blocked
annevk
force-pushed
the
eng/Remove-IOSFormControlRefreshEnabled-preference-and-IOS_FORM_CONTROL_REFRESH
branch
from
7d5f875
to
821bd70
Compare
|
EWS run on current version of this PR (hash 821bd70) |
hortont424
approved these changes
Nov 22, 2023
webkit-commit-queue
force-pushed
the
eng/Remove-IOSFormControlRefreshEnabled-preference-and-IOS_FORM_CONTROL_REFRESH
branch
from
821bd70
to
d4ec6fe
Compare
…REFRESH) https://bugs.webkit.org/show_bug.cgi?id=265132 Reviewed by Tim Horton. This preference has outlived its usefulness. Apart from the UIProcess code this change has considered the preference to always be true and generally cleaned up the code around it as a result of that fact. In the UIProcess this change preserves _formControlRefreshEnabled in particular as it was not solely controlled by this preference. ENABLE(IOS_FORM_CONTROL_REFRESH) has been replaced by PLATFORM(IOS_FAMILY) where it was not already nested. Removed tests were testing a dead code path and could not be trivially adjusted. * LayoutTests/fast/forms/ios/choose-select-option-expected.txt: Removed. * LayoutTests/fast/forms/ios/choose-select-option.html: Removed. * LayoutTests/fast/forms/ios/disabled-options-in-multi-select-picker-expected.txt: Removed. * LayoutTests/fast/forms/ios/disabled-options-in-multi-select-picker.html: Removed. * LayoutTests/fast/forms/ios/form-control-refresh/button/button-type-submit-expected.html: * LayoutTests/fast/forms/ios/form-control-refresh/button/button-type-submit.html: * LayoutTests/fast/forms/ios/form-control-refresh/checkbox/border-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/checkbox/border.html: * LayoutTests/fast/forms/ios/form-control-refresh/checkbox/checked-appearance-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/checkbox/checked-appearance.html: * LayoutTests/fast/forms/ios/form-control-refresh/checkbox/ignored-properties-expected.html: * LayoutTests/fast/forms/ios/form-control-refresh/checkbox/ignored-properties.html: * LayoutTests/fast/forms/ios/form-control-refresh/checkbox/indeterminate-appearance-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/checkbox/indeterminate-appearance.html: * LayoutTests/fast/forms/ios/form-control-refresh/checkbox/subpixel-clipping-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/checkbox/subpixel-clipping.html: * LayoutTests/fast/forms/ios/form-control-refresh/checkbox/width-height-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/checkbox/width-height.html: * LayoutTests/fast/forms/ios/form-control-refresh/color/background-color-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/color/background-color.html: * LayoutTests/fast/forms/ios/form-control-refresh/color/border-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/color/border-radius-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/color/border-radius.html: * LayoutTests/fast/forms/ios/form-control-refresh/color/border.html: * LayoutTests/fast/forms/ios/form-control-refresh/color/paint-within-box-expected.html: * LayoutTests/fast/forms/ios/form-control-refresh/color/paint-within-box.html: * LayoutTests/fast/forms/ios/form-control-refresh/color/width-height-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/color/width-height.html: * LayoutTests/fast/forms/ios/form-control-refresh/meter/border-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/meter/border.html: * LayoutTests/fast/forms/ios/form-control-refresh/meter/even-less-good-appearance-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/meter/even-less-good-appearance.html: * LayoutTests/fast/forms/ios/form-control-refresh/meter/optimal-appearance-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/meter/optimal-appearance.html: * LayoutTests/fast/forms/ios/form-control-refresh/meter/suboptimal-appearance-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/meter/suboptimal-appearance.html: * LayoutTests/fast/forms/ios/form-control-refresh/meter/width-height-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/meter/width-height.html: * LayoutTests/fast/forms/ios/form-control-refresh/progress/filled-appearance-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/progress/filled-appearance.html: * LayoutTests/fast/forms/ios/form-control-refresh/progress/indeterminate-appearance-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/progress/indeterminate-appearance.html: * LayoutTests/fast/forms/ios/form-control-refresh/progress/rtl-appearance-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/progress/rtl-appearance.html: * LayoutTests/fast/forms/ios/form-control-refresh/progress/style-height-expected.html: * LayoutTests/fast/forms/ios/form-control-refresh/progress/style-height.html: * LayoutTests/fast/forms/ios/form-control-refresh/progress/style-width-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/progress/style-width.html: * LayoutTests/fast/forms/ios/form-control-refresh/radio/border-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/radio/border.html: * LayoutTests/fast/forms/ios/form-control-refresh/radio/checked-appearance-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/radio/checked-appearance.html: * LayoutTests/fast/forms/ios/form-control-refresh/radio/disabled-appearance-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/radio/disabled-appearance.html: * LayoutTests/fast/forms/ios/form-control-refresh/radio/ignored-properties-expected.html: * LayoutTests/fast/forms/ios/form-control-refresh/radio/ignored-properties.html: * LayoutTests/fast/forms/ios/form-control-refresh/radio/subpixel-clipping-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/radio/subpixel-clipping.html: * LayoutTests/fast/forms/ios/form-control-refresh/radio/width-height-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/radio/width-height.html: * LayoutTests/fast/forms/ios/form-control-refresh/range/background-color-expected.html: * LayoutTests/fast/forms/ios/form-control-refresh/range/background-color.html: * LayoutTests/fast/forms/ios/form-control-refresh/range/border-expected.html: * LayoutTests/fast/forms/ios/form-control-refresh/range/border.html: * LayoutTests/fast/forms/ios/form-control-refresh/range/datalist-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/range/datalist.html: * LayoutTests/fast/forms/ios/form-control-refresh/range/rtl-appearance-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/range/rtl-appearance.html: * LayoutTests/fast/forms/ios/form-control-refresh/range/style-height-expected.html: * LayoutTests/fast/forms/ios/form-control-refresh/range/style-height.html: * LayoutTests/fast/forms/ios/form-control-refresh/range/style-width-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/range/style-width.html: * LayoutTests/fast/forms/ios/form-control-refresh/range/value-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/range/value.html: * LayoutTests/fast/forms/ios/form-control-refresh/search/background-color-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/search/background-color.html: * LayoutTests/fast/forms/ios/form-control-refresh/search/border-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/search/border.html: * LayoutTests/fast/forms/ios/form-control-refresh/search/font-size-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/search/font-size.html: * LayoutTests/fast/forms/ios/form-control-refresh/search/results-attribute-expected.html: * LayoutTests/fast/forms/ios/form-control-refresh/search/results-attribute.html: * LayoutTests/fast/forms/ios/form-control-refresh/search/search-decoration-appearance-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/search/search-decoration-appearance.html: * LayoutTests/fast/forms/ios/form-control-refresh/search/textfield-appearance-background-styled.html: * LayoutTests/fast/forms/ios/form-control-refresh/search/textfield-appearance-background.html: * LayoutTests/fast/forms/ios/form-control-refresh/search/width-height-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/search/width-height.html: * LayoutTests/fast/forms/ios/form-control-refresh/select/all-options-in-single-optgroup.html: * LayoutTests/fast/forms/ios/form-control-refresh/select/background-color-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/select/background-color.html: * LayoutTests/fast/forms/ios/form-control-refresh/select/border-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/select/border-radius-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/select/border-radius.html: * LayoutTests/fast/forms/ios/form-control-refresh/select/border.html: * LayoutTests/fast/forms/ios/form-control-refresh/select/choose-select-option.html: * LayoutTests/fast/forms/ios/form-control-refresh/select/decoration-color-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/select/decoration-color.html: * LayoutTests/fast/forms/ios/form-control-refresh/select/focus-select-after-textfield.html: * LayoutTests/fast/forms/ios/form-control-refresh/select/focus-select-in-touchend.html: * LayoutTests/fast/forms/ios/form-control-refresh/select/multiple-appearance-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/select/multiple-appearance.html: * LayoutTests/fast/forms/ios/form-control-refresh/select/no-stale-checked-items-in-select-picker.html: * LayoutTests/fast/forms/ios/form-control-refresh/select/rtl-appearance-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/select/rtl-appearance.html: * LayoutTests/fast/forms/ios/form-control-refresh/select/select-multiple-picker.html: * LayoutTests/fast/forms/ios/form-control-refresh/select/text-color-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/select/text-color.html: * LayoutTests/fast/forms/ios/form-control-refresh/select/width-height-expected-mismatch.html: * LayoutTests/fast/forms/ios/form-control-refresh/select/width-height.html: * LayoutTests/fast/forms/ios/no-stale-checked-items-in-select-picker-expected.txt: Removed. * LayoutTests/fast/forms/ios/no-stale-checked-items-in-select-picker.html: Removed. * LayoutTests/fast/forms/ios/select-picker-change-and-focus-another-select-expected.txt: Removed. * LayoutTests/fast/forms/ios/select-picker-change-and-focus-another-select-programmatically-expected.txt: Removed. * LayoutTests/fast/forms/ios/select-picker-change-and-focus-another-select-programmatically.html: Removed. * LayoutTests/fast/forms/ios/select-picker-change-and-focus-another-select.html: Removed. * LayoutTests/platform/ipad/fast/forms/choose-select-option-expected.txt: Removed. * LayoutTests/platform/ipad/fast/forms/choose-select-option.html: Removed. * LayoutTests/platform/ipad/fast/forms/select-with-title-expected.txt: Removed. * LayoutTests/platform/ipad/fast/forms/select-with-title.html: Removed. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WTF/wtf/PlatformEnable.h: * Source/WTF/wtf/PlatformEnableCocoa.h: * Source/WebCore/DerivedSources-input.xcfilelist: * Source/WebCore/DerivedSources.make: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/css/legacyFormControlsIOS.css: Removed. * Source/WebCore/html/HTMLMeterElement.cpp: (WebCore::HTMLMeterElement::createElementRenderer): * Source/WebCore/html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::handleFocusEvent): (WebCore::TextFieldInputType::handleBlurEvent): (WebCore::TextFieldInputType::didSetValueByUserEdit): (WebCore::TextFieldInputType::dataListMayHaveChanged): (WebCore::TextFieldInputType::shouldOnlyShowDataListDropdownButtonWhenFocusedOrEdited const): Deleted. * Source/WebCore/html/TextFieldInputType.h: * Source/WebCore/page/Quirks.cpp: (WebCore::Quirks::shouldHideSearchFieldResultsButton const): * Source/WebCore/rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::adjustInnerStyle): * Source/WebCore/rendering/RenderTheme.cpp: (WebCore::RenderTheme::paintDecorations): (WebCore::RenderTheme::colorInputStyleSheet const): (WebCore::RenderTheme::paintColorWellDecorations): Deleted. * Source/WebCore/rendering/RenderTheme.h: (WebCore::RenderTheme::popupInternalPaddingBox const): (WebCore::RenderTheme::supportsMeter const): (WebCore::RenderTheme::paintColorWellDecorations): (WebCore::RenderTheme::paintSliderThumb): (WebCore::RenderTheme::paintCheckboxDecorations): Deleted. (WebCore::RenderTheme::paintRadioDecorations): Deleted. (WebCore::RenderTheme::paintButtonDecorations): Deleted. (WebCore::RenderTheme::paintSliderThumbDecorations): Deleted. * Source/WebCore/rendering/RenderThemeAdwaita.cpp: (WebCore::RenderThemeAdwaita::popupInternalPaddingBox const): * Source/WebCore/rendering/RenderThemeAdwaita.h: * Source/WebCore/rendering/RenderThemeIOS.h: * Source/WebCore/rendering/RenderThemeIOS.mm: (WebCore::RenderThemeIOS::paintTextFieldDecorations): (WebCore::RenderThemeIOS::popupInternalPaddingBox const): (WebCore::canAdjustBorderRadiusForAppearance): (WebCore::adjustInputElementButtonStyle): (WebCore::RenderThemeIOS::paintMenuListButtonDecorations): (WebCore::RenderThemeIOS::paintSliderTrack): (WebCore::RenderThemeIOS::paintProgressBar): (WebCore::RenderThemeIOS::adjustButtonLikeControlStyle const): (WebCore::RenderThemeIOS::paintCheckbox): (WebCore::RenderThemeIOS::paintRadio): (WebCore::RenderThemeIOS::animationRepeatIntervalForProgressBar const): (WebCore::RenderThemeIOS::supportsMeter const): (WebCore::RenderThemeIOS::paintMeter): (WebCore::RenderThemeIOS::paintSliderTicks): (WebCore::RenderThemeIOS::colorInputStyleSheet const): (WebCore::RenderThemeIOS::adjustColorWellStyle const): (WebCore::RenderThemeIOS::paintColorWell): (WebCore::RenderThemeIOS::paintColorWellDecorations): (WebCore::RenderThemeIOS::adjustSearchFieldDecorationPartStyle const): (WebCore::RenderThemeIOS::paintSearchFieldDecorationPart): (WebCore::IOSGradient::IOSGradient): Deleted. (WebCore::interpolateLinearGradient): Deleted. (WebCore::interpolateExponentialGradient): Deleted. (WebCore::getSharedFunctionRef): Deleted. (WebCore::drawAxialGradient): Deleted. (WebCore::drawRadialGradient): Deleted. (WebCore::getInsetGradient): Deleted. (WebCore::getShineGradient): Deleted. (WebCore::getShadeGradient): Deleted. (WebCore::getConvexGradient): Deleted. (WebCore::getConcaveGradient): Deleted. (WebCore::getSliderTrackGradient): Deleted. (WebCore::getReadonlySliderTrackGradient): Deleted. (WebCore::getSliderThumbOpaquePressedGradient): Deleted. (WebCore::gradientWithName): Deleted. (WebCore::shortened): Deleted. (WebCore::drawJoinedLines): Deleted. (WebCore::RenderThemeIOS::canPaint const): Deleted. (WebCore::RenderThemeIOS::paintCheckboxDecorations): Deleted. (WebCore::RenderThemeIOS::paintRadioDecorations): Deleted. (WebCore::RenderThemeIOS::paintSliderThumbDecorations): Deleted. (WebCore::RenderThemeIOS::paintButtonDecorations): Deleted. (WebCore::shouldUseConvexGradient): Deleted. (WebCore::RenderThemeIOS::paintPushButtonDecorations): Deleted. (WebCore::RenderThemeIOS::paintProgressBarWithFormControlRefresh): Deleted. (WebCore::RenderThemeIOS::paintSliderTrackWithFormControlRefresh): Deleted. (WebCore::RenderThemeIOS::paintMenuListButtonDecorationsWithFormControlRefresh): Deleted. * Source/WebCore/rendering/RenderThemeMac.h: * Source/WebCore/rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::supportsMeter const): (WebCore::RenderThemeMac::popupInternalPaddingBox const): * Source/WebCore/style/InspectorCSSOMWrappers.cpp: (WebCore::Style::InspectorCSSOMWrappers::collectDocumentWrappers): * Source/WebCore/style/UserAgentStyle.cpp: (WebCore::Style::UserAgentStyle::ensureDefaultStyleSheetsForElement): * Source/WebCore/style/UserAgentStyle.h: * Source/WebKit/UIProcess/ios/WKContentViewInteraction.h: * Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _shouldShowAutomaticKeyboardUIIgnoringInputMode]): (-[WKContentView _elementTypeRequiresAccessoryView:]): (-[WKContentView _formControlRefreshEnabled]): (-[WKContentView _shouldUseContextMenusForFormControls]): * Source/WebKit/UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm: (WebKit::WebDataListSuggestionsDropdownIOS::show): * Source/WebKit/UIProcess/ios/forms/WKFormSelectControl.mm: (-[WKFormSelectControl initWithView:]): * Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.h: * Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptControllerIOS::isShowingDataListSuggestions const): Canonical link: https://commits.webkit.org/271063@main
webkit-commit-queue
force-pushed
the
eng/Remove-IOSFormControlRefreshEnabled-preference-and-IOS_FORM_CONTROL_REFRESH
branch
from
d4ec6fe
to
5e8bfc3
Compare
|
Committed 271063@main (5e8bfc3): https://commits.webkit.org/271063@main Reviewed commits have been landed. Closing PR #20746 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
annevk
deleted the
eng/Remove-IOSFormControlRefreshEnabled-preference-and-IOS_FORM_CONTROL_REFRESH
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5e8bfc3
821bd70