Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RemoteRealtimeMediaSourceProxy should use latest successful constraints when creating the remote source #20812

Conversation

youennf
Copy link
Contributor

@youennf youennf commented Nov 22, 2023

6abef00

RemoteRealtimeMediaSourceProxy should use latest successful constraints when creating the remote source
https://bugs.webkit.org/show_bug.cgi?id=265232
rdar://118708700

Reviewed by Eric Carlson and Jean-Yves Avenard.

In case of GPUProcess crash, we are recreating a remote source by calling RemoteRealtimeMediaSourceProxy::createRemoteMediaSource.
createRemoteMediaSource is currently using the constraints used initially (via getUserMedia).
But it should in fact use the last successful constraints applied to the previous remote source (via applyConstraints).
Update the code accordingly and update API test to cover that case.

Canonical link: https://commits.webkit.org/271074@main

d833815

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ api-wpe
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ›  gtk
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv-sim
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@youennf youennf requested a review from cdumez as a code owner November 22, 2023 08:00
@youennf youennf self-assigned this Nov 22, 2023
@youennf youennf added the WebRTC For bugs in WebRTC label Nov 22, 2023
@youennf youennf added the merge-queue Applied to send a pull request to merge-queue label Nov 23, 2023
…ts when creating the remote source

https://bugs.webkit.org/show_bug.cgi?id=265232
rdar://118708700

Reviewed by Eric Carlson and Jean-Yves Avenard.

In case of GPUProcess crash, we are recreating a remote source by calling RemoteRealtimeMediaSourceProxy::createRemoteMediaSource.
createRemoteMediaSource is currently using the constraints used initially (via getUserMedia).
But it should in fact use the last successful constraints applied to the previous remote source (via applyConstraints).
Update the code accordingly and update API test to cover that case.

Canonical link: https://commits.webkit.org/271074@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/RemoteRealtimeMediaSourceProxy-should-use-latest-successful-constraints-when-creating-the-remote-source branch from d833815 to 6abef00 Compare November 23, 2023 10:48
@webkit-commit-queue
Copy link
Collaborator

Committed 271074@main (6abef00): https://commits.webkit.org/271074@main

Reviewed commits have been landed. Closing PR #20812 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 6abef00 into WebKit:main Nov 23, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebRTC For bugs in WebRTC
Projects
None yet
5 participants