Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust VM heap growth factor #2082

Merged
merged 1 commit into from Jul 6, 2022
Merged

Adjust VM heap growth factor #2082

merged 1 commit into from Jul 6, 2022

Conversation

hyjorc1
Copy link
Contributor

@hyjorc1 hyjorc1 commented Jul 5, 2022 •
edited by webkit-commit-queue

34d0653

Adjust VM heap growth factor
https://bugs.webkit.org/show_bug.cgi?id=242347

Reviewed by Yusuke Suzuki.

We adjust VM heap growth factor to gain 0.5% RAMification progression.

* Source/JavaScriptCore/runtime/OptionsList.h:

Canonical link: https://commits.webkit.org/252169@main

@hyjorc1 hyjorc1 requested a review from a team as a code owner July 5, 2022 17:53
@hyjorc1 hyjorc1 self-assigned this Jul 5, 2022
@hyjorc1 hyjorc1 added JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. WebKit Nightly Build labels Jul 5, 2022
Constellation
Constellation approved these changes Jul 5, 2022
View reviewed changes
Copy link
Member

@Constellation Constellation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me if watch-cli.js is neutral.
Let's measure non-JIT watch-cli.js JetStream2 score to ensure that we do not introduce significant regression.
And let's paste the result data to commit message.

@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label Jul 5, 2022
@Constellation Constellation removed the merging-blocked Applied to prevent a change from being merged label Jul 6, 2022
@hyjorc1
Copy link
Contributor Author

hyjorc1 commented Jul 6, 2022 •
edited

Performed an AABB NoJIT test (10 iterations) in minimode locally. It seems the results are neutral based on the computed pvalue of t-test, where the result is attached.

score 0: 62.008 with options: ['/Volumes/WebKit/mac/OpenSource/WebKitBuild/Release/jsc', '--useJIT=0', 'watch-cli.js']
score 1: 61.652 with options: ['/Volumes/WebKit/mac/OpenSource/WebKitBuild/Release/jsc', '--useJIT=0', 'watch-cli.js']
score 2: 62.167 with options: ['/Volumes/WebKit/mac/OpenSource/WebKitBuild/Release/jsc', '--useJIT=0', 'watch-cli.js']
score 3: 60.868 with options: ['/Volumes/WebKit/mac/OpenSource/WebKitBuild/Release/jsc', '--useJIT=0', 'watch-cli.js']
score 4: 62.989 with options: ['/Volumes/WebKit/mac/OpenSource/WebKitBuild/Release/jsc', '--useJIT=0', 'watch-cli.js']
score 5: 62.624 with options: ['/Volumes/WebKit/mac/OpenSource/WebKitBuild/Release/jsc', '--useJIT=0', 'watch-cli.js']
score 6: 62.983 with options: ['/Volumes/WebKit/mac/OpenSource/WebKitBuild/Release/jsc', '--useJIT=0', 'watch-cli.js']
score 7: 62.557 with options: ['/Volumes/WebKit/mac/OpenSource/WebKitBuild/Release/jsc', '--useJIT=0', 'watch-cli.js']
score 8: 63.59 with options: ['/Volumes/WebKit/mac/OpenSource/WebKitBuild/Release/jsc', '--useJIT=0', 'watch-cli.js']
score 9: 58.28 with options: ['/Volumes/WebKit/mac/OpenSource/WebKitBuild/Release/jsc', '--useJIT=0', 'watch-cli.js']

score 0: 60.111 with options: ['/Volumes/WebKit/mac/OpenSource/WebKitBuild/Release/jsc', '--useJIT=0', '--validateOptions=1', '--largeHeapGrowthFactor=1.20', '--miniVMHeapGrowthFactor=1.20', 'watch-cli.js']
score 1: 62.637 with options: ['/Volumes/WebKit/mac/OpenSource/WebKitBuild/Release/jsc', '--useJIT=0', '--validateOptions=1', '--largeHeapGrowthFactor=1.20', '--miniVMHeapGrowthFactor=1.20', 'watch-cli.js']
score 2: 62.673 with options: ['/Volumes/WebKit/mac/OpenSource/WebKitBuild/Release/jsc', '--useJIT=0', '--validateOptions=1', '--largeHeapGrowthFactor=1.20', '--miniVMHeapGrowthFactor=1.20', 'watch-cli.js']
score 3: 63.095 with options: ['/Volumes/WebKit/mac/OpenSource/WebKitBuild/Release/jsc', '--useJIT=0', '--validateOptions=1', '--largeHeapGrowthFactor=1.20', '--miniVMHeapGrowthFactor=1.20', 'watch-cli.js']
score 4: 60.344 with options: ['/Volumes/WebKit/mac/OpenSource/WebKitBuild/Release/jsc', '--useJIT=0', '--validateOptions=1', '--largeHeapGrowthFactor=1.20', '--miniVMHeapGrowthFactor=1.20', 'watch-cli.js']
score 5: 62.217 with options: ['/Volumes/WebKit/mac/OpenSource/WebKitBuild/Release/jsc', '--useJIT=0', '--validateOptions=1', '--largeHeapGrowthFactor=1.20', '--miniVMHeapGrowthFactor=1.20', 'watch-cli.js']
score 6: 61.849 with options: ['/Volumes/WebKit/mac/OpenSource/WebKitBuild/Release/jsc', '--useJIT=0', '--validateOptions=1', '--largeHeapGrowthFactor=1.20', '--miniVMHeapGrowthFactor=1.20', 'watch-cli.js']
score 7: 62.673 with options: ['/Volumes/WebKit/mac/OpenSource/WebKitBuild/Release/jsc', '--useJIT=0', '--validateOptions=1', '--largeHeapGrowthFactor=1.20', '--miniVMHeapGrowthFactor=1.20', 'watch-cli.js']
score 8: 62.578 with options: ['/Volumes/WebKit/mac/OpenSource/WebKitBuild/Release/jsc', '--useJIT=0', '--validateOptions=1', '--largeHeapGrowthFactor=1.20', '--miniVMHeapGrowthFactor=1.20', 'watch-cli.js']
score 9: 62.984 with options: ['/Volumes/WebKit/mac/OpenSource/WebKitBuild/Release/jsc', '--useJIT=0', '--validateOptions=1', '--largeHeapGrowthFactor=1.20', '--miniVMHeapGrowthFactor=1.20', 'watch-cli.js']

base mean: 61.972, config mean: 62.116, prog: 0.23%, sig: False, options: ['--validateOptions=1', '--largeHeapGrowthFactor=1.20', '--miniVMHeapGrowthFactor=1.20']

@hyjorc1 hyjorc1 added the merge-queue Applied to send a pull request to merge-queue label Jul 6, 2022
Adjust VM heap growth factor
34d0653 
https://bugs.webkit.org/show_bug.cgi?id=242347

Reviewed by Yusuke Suzuki.

We adjust VM heap growth factor to gain 0.5% RAMification progression.

* Source/JavaScriptCore/runtime/OptionsList.h:

Canonical link: https://commits.webkit.org/252169@main
@webkit-commit-queue
Copy link
Collaborator

Committed 252169@main (34d0653): https://commits.webkit.org/252169@main

Reviewed commits have been landed. Closing PR #2082 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 34d0653 into WebKit:main Jul 6, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 6, 2022
@hyjorc1 hyjorc1 deleted the eng/heap branch July 6, 2022 15:47
@hyjorc1 hyjorc1 mentioned this pull request Jul 27, 2022
Merged
webkit-early-warning-system pushed a commit to hyjorc1/WebKit that referenced this pull request Jul 27, 2022
Revert tuning large heap growth factor
63e2973 
https://bugs.webkit.org/show_bug.cgi?id=243235

Reviewed by Justin Michaud.

Lowering large heap growth factor might lead to the regression
in benchmark PLUM3. So, we should revert that change applied in
the previous commit(WebKit#2082).

* Source/JavaScriptCore/runtime/OptionsList.h:

Canonical link: https://commits.webkit.org/252860@main
Jarred-Sumner pushed a commit to oven-sh/WebKit that referenced this pull request Jul 27, 2022
@Jarred-Sumner
Revert tuning large heap growth factor
7f116a2 
https://bugs.webkit.org/show_bug.cgi?id=243235

Reviewed by Justin Michaud.

Lowering large heap growth factor might lead to the regression
in benchmark PLUM3. So, we should revert that change applied in
the previous commit(WebKit#2082).

* Source/JavaScriptCore/runtime/OptionsList.h:

Canonical link: https://commits.webkit.org/252860@main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Constellation Constellation Constellation approved these changes

Assignees

@hyjorc1 hyjorc1

Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Milestone
No milestone
4 participants
@hyjorc1 @webkit-commit-queue @Constellation @webkit-early-warning-system