[LFC] Revert bad rename for Layout::Box::isRubyBase() #20826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on current version of this PR (hash 62915f4)
|
anttijk
added
the
Layout and Rendering
https://bugs.webkit.org/show_bug.cgi?id=265253 Reviewed by Alan Baradlay. For some reason (search-replace?) https://commits.webkit.org/270396@main renamed it to isRenderRubyBase(). * Source/WebCore/layout/formattingContexts/inline/InlineLevelBoxInlines.h: * Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp: (WebCore::Layout::Line::Run::isContentfulOrHasDecoration): * Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp: (WebCore::Layout::LineBoxBuilder::setVerticalPropertiesForInlineLevelBox const): * Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp: (WebCore::Layout::LineBuilder::candidateContentForLine): * Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp: (WebCore::Layout::InlineDisplayContentBuilder::appendInlineBoxDisplayBox): (WebCore::Layout::InlineDisplayContentBuilder::appendSpanningInlineBoxDisplayBox): (WebCore::Layout::InlineDisplayContentBuilder::handleInlineBoxEnd): (WebCore::Layout::InlineDisplayContentBuilder::appendRubyAnnotationBox): (WebCore::Layout::InlineDisplayContentBuilder::applyRubyOverhang): * Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp: (WebCore::Layout::nextWrapOpportunityWithinRubyContainer): (WebCore::Layout::RubyFormattingContext::placeRubyContent): (WebCore::Layout::RubyFormattingContext::placeAnnotationBox): (WebCore::Layout::RubyFormattingContext::sizeAnnotationBox): (WebCore::Layout::RubyFormattingContext::applyAnnotationContributionToLayoutBounds const): (WebCore::Layout::RubyFormattingContext::nextWrapOpportunity): (WebCore::Layout::RubyFormattingContext::annotationOverlapCheck const): (WebCore::Layout::RubyFormattingContext::logicaWidthForRubyRange const): * Source/WebCore/layout/layouttree/LayoutBox.h: (WebCore::Layout::Box::isRubyBase const): (WebCore::Layout::Box::isRenderRubyBase const): Deleted. Canonical link: https://commits.webkit.org/271061@main
webkit-commit-queue
force-pushed
the
ruby-base-rename-revert
branch
from
62915f4
to
e6ad074
Compare
|
Committed 271061@main (e6ad074): https://commits.webkit.org/271061@main Reviewed commits have been landed. Closing PR #20826 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e6ad074
62915f4
🧪 wpe-wk2🧪 ios-wk2-wpt🧪 gtk-wk2🧪 mac-AS-debug-wk2