-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intruduce concept of render tree rebuild root #20846
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EWS run on previous version of this PR (hash 7252b82) |
7252b82
to
e877284
Compare
EWS run on previous version of this PR (hash e877284) |
e877284
to
870d8a9
Compare
EWS run on current version of this PR (hash 870d8a9) |
alanbaradlay
approved these changes
Nov 23, 2023
https://bugs.webkit.org/show_bug.cgi?id=265284 rdar://118744369 Reviewed by Alan Baradlay. Add mechanism to rebuild render subtree starting from an ancestor of the changed element. We can simplify render tree mutations if some complex cases are handled by tearing down a larger structure with all the associated anonymous boxes and rebuilding them. Use the mechanism for <ruby> subtrees when style-based ruby is enabled. This gets tested by fast/ruby/rubyDOM-insert-rt-block-1.html fast/ruby/rubyDOM-insert-rt-block-2.html fast/ruby/rubyDOM-insert-rt-block-3.html fast/ruby/rubyDOM-remove-rt-block-1.html fast/ruby/rubyDOM-remove-rt-block-2.html fast/ruby/rubyDOM-remove-rt-block-3.html * Source/WebCore/dom/Document.cpp: (WebCore::Document::updateRenderTree): * Source/WebCore/dom/Document.h: * Source/WebCore/rendering/updating/RenderTreeBuilder.cpp: (WebCore::RenderTreeBuilder::isRebuildRootForChildren): Test if a given renderer is rebuild root for its children. For now this only tests for ruby. * Source/WebCore/rendering/updating/RenderTreeBuilder.h: * Source/WebCore/rendering/updating/RenderTreeUpdater.cpp: (WebCore::findRenderingAncestor): (WebCore::findRenderingRoot): (WebCore::RenderTreeUpdater::commit): (WebCore::RenderTreeUpdater::updateRebuildRoots): In the beginning of a commit check if any of the rebuild roots need a wider rebuild. Add all the new elements that will get rebuild to the style update. * Source/WebCore/rendering/updating/RenderTreeUpdater.h: * Source/WebCore/style/StyleUpdate.cpp: (WebCore::Style::Update::addElement): (WebCore::Style::Update::addPossibleRebuildRoot): Keep track of the rebuild roots. * Source/WebCore/style/StyleUpdate.h: (WebCore::Style::Update::rebuildRoots const): Canonical link: https://commits.webkit.org/271082@main
870d8a9
to
c7578c8
Compare
Committed 271082@main (c7578c8): https://commits.webkit.org/271082@main Reviewed commits have been landed. Closing PR #20846 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c7578c8
870d8a9