[iOS] "A problem repeatedly occurred" error page when safari resuming from background #2085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdumez
force-pushed
the
242352_problem_repeatedly_occurred
branch
from
d4365e9
to
ffb6b19
Compare
darinadler
approved these changes
Jul 5, 2022
webkit-early-warning-system
added
the
merging-blocked
cdumez
added
merge-queue
… from background https://bugs.webkit.org/show_bug.cgi?id=242352 Reviewed by Darin Adler. Follow-up to 252108@main to take care of more cases where we might try to reuse a terminated WebProcess during crash recovery, because we have not received the crash notification for the back up process yet. 252108@main took care of processes reused from a related WKWebView. This patch takes care of processes taken from the WebProcess cache or from a suspended page in the back/forward list. * Source/WebKit/UIProcess/SuspendedPageProxy.cpp: (WebKit::SuspendedPageProxy::findReusableSuspendedPageProcess): * Source/WebKit/UIProcess/WebProcessCache.cpp: (WebKit::WebProcessCache::takeProcess): * Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: (-[PSONNavigationDelegate webViewWebContentProcessDidTerminate:]): Canonical link: https://commits.webkit.org/252177@main
webkit-early-warning-system
force-pushed
the
242352_problem_repeatedly_occurred
branch
from
ffb6b19
to
5798b62
Compare
|
Committed 252177@main (5798b62): https://commits.webkit.org/252177@main Reviewed commits have been landed. Closing PR #2085 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5798b62