Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GStreamer] GStreamerTest.harnessDecodeMP4Video API test is flaky #20865

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

philn
Copy link
Member

@philn philn commented Nov 24, 2023

a83fbf4

[GStreamer] GStreamerTest.harnessDecodeMP4Video API test is flaky
https://bugs.webkit.org/show_bug.cgi?id=265303

Reviewed by Xabier Rodriguez-Calvar.

multiqueue forwards the flush-stop event before stopping its single queues flushes. The harness
blocks its flush operation until it received flush-stop, so this was a source of flakyness on the
test. To workaround this issue we disable internal buffering on the multiqueue created by
decodebin3.

* Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GstElementHarness.cpp:
(TestWebKitAPI::TEST_F):

Canonical link: https://commits.webkit.org/271098@main

875fc2a

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac ❌ πŸ§ͺ api-wpe
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ›  gtk
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv-sim
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@philn philn self-assigned this Nov 24, 2023
@philn philn added the Platform Portability improvements and other general platform improvements not driven directly by site bugs. label Nov 24, 2023
@philn philn requested a review from calvaris November 24, 2023 11:40
@philn philn added the merge-queue Applied to send a pull request to merge-queue label Nov 24, 2023
https://bugs.webkit.org/show_bug.cgi?id=265303

Reviewed by Xabier Rodriguez-Calvar.

multiqueue forwards the flush-stop event before stopping its single queues flushes. The harness
blocks its flush operation until it received flush-stop, so this was a source of flakyness on the
test. To workaround this issue we disable internal buffering on the multiqueue created by
decodebin3.

* Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GstElementHarness.cpp:
(TestWebKitAPI::TEST_F):

Canonical link: https://commits.webkit.org/271098@main
@webkit-commit-queue
Copy link
Collaborator

Committed 271098@main (a83fbf4): https://commits.webkit.org/271098@main

Reviewed commits have been landed. Closing PR #20865 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit a83fbf4 into WebKit:main Nov 24, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 24, 2023
@philn philn deleted the eng/265303 branch November 24, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform Portability improvements and other general platform improvements not driven directly by site bugs.
Projects
None yet
4 participants