Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setting for WebKit process management #20889

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Add setting for WebKit process management #20889

merged 1 commit into from
Nov 28, 2023

Conversation

pvollan
Copy link
Contributor

@pvollan pvollan commented Nov 25, 2023 •
edited by webkit-early-warning-system
Loading

8a3ec59

Add setting for WebKit process management
https://bugs.webkit.org/show_bug.cgi?id=265337
rdar://118789596

Reviewed by Brent Fulgham.

Add setting to manage WebKit processes as extensions. This setting is not enabled by default.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp:
* Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitialize):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:

Canonical link: https://commits.webkit.org/271181@main

a1b61d1

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
  🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2   🧪 gtk-wk2
✅ 🛠 🧪 jsc-arm64   🛠 tv ✅ 🧪 mac-AS-debug-wk2   🧪 api-gtk
✅ 🛠 tv-sim ✅ 🛠 jsc-armv7
✅ 🛠 🧪 merge   🛠 watch ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch-sim

@pvollan pvollan requested a review from cdumez as a code owner November 25, 2023 16:09
@pvollan pvollan self-assigned this Nov 25, 2023
@pvollan pvollan added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Nov 25, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 25, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 25ba47d)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🛠 jsc-armv7
✅ 🛠 watch ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch-sim

@pvollan pvollan force-pushed the eng/Add-setting-for-WebKit-process-management branch from 25ba47d to 0605f24 Compare November 25, 2023 18:32
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 25, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 0605f24)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
✅ 🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 🧪 jsc   🧪 api-ios   🧪 mac-wk2   🧪 gtk-wk2
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv   🧪 mac-AS-debug-wk2   🧪 api-gtk
✅ 🛠 tv-sim ✅ 🛠 jsc-armv7
✅ 🛠 watch ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch-sim

@pvollan pvollan force-pushed the eng/Add-setting-for-WebKit-process-management branch from 0605f24 to 5919a8b Compare November 25, 2023 18:47
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 25, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 5919a8b)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🛠 jsc-armv7
✅ 🛠 watch ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch-sim

@pvollan pvollan force-pushed the eng/Add-setting-for-WebKit-process-management branch from 5919a8b to 783aa65 Compare November 27, 2023 17:57
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 27, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 783aa65)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ❌ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🛠 jsc-armv7
✅ 🛠 watch ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch-sim

@pvollan pvollan force-pushed the eng/Add-setting-for-WebKit-process-management branch from 783aa65 to a1b61d1 Compare November 27, 2023 22:52
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 27, 2023 •
edited
Loading

EWS run on current version of this PR (hash a1b61d1)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
  🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2   🧪 gtk-wk2
✅ 🛠 🧪 jsc-arm64   🛠 tv ✅ 🧪 mac-AS-debug-wk2   🧪 api-gtk
✅ 🛠 tv-sim ✅ 🛠 jsc-armv7
✅ 🛠 🧪 merge   🛠 watch ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch-sim

@pvollan pvollan requested a review from aestes November 27, 2023 22:53
brentfulgham
brentfulgham approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@brentfulgham brentfulgham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. r=me

@pvollan
Copy link
Contributor Author

pvollan commented Nov 28, 2023

LGTM. r=me

Thanks for reviewing!

@pvollan pvollan added the merge-queue Applied to send a pull request to merge-queue label Nov 28, 2023
@pvollan
Add setting for WebKit process management
8a3ec59 
https://bugs.webkit.org/show_bug.cgi?id=265337
rdar://118789596

Reviewed by Brent Fulgham.

Add setting to manage WebKit processes as extensions. This setting is not enabled by default.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp:
* Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitialize):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:

Canonical link: https://commits.webkit.org/271181@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Add-setting-for-WebKit-process-management branch from a1b61d1 to 8a3ec59 Compare November 28, 2023 01:09
@webkit-commit-queue webkit-commit-queue merged commit 8a3ec59 into WebKit:main Nov 28, 2023
@webkit-commit-queue
Copy link
Collaborator

Committed 271181@main (8a3ec59): https://commits.webkit.org/271181@main

Reviewed commits have been landed. Closing PR #20889 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentfulgham brentfulgham brentfulgham approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@aestes aestes Awaiting requested review from aestes

Assignees

@pvollan pvollan

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
4 participants
@pvollan @webkit-early-warning-system @webkit-commit-queue @brentfulgham