Remove the CSSIndividualTransformPropertiesEnabled flag #20900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash cee9da2) |
webkit-ews-buildbot
added
the
merging-blocked
graouts
force-pushed
the
remove-individual-transform-properties-flag
branch
from
cee9da2
to
52401b6
Compare
|
EWS run on previous version of this PR (hash 52401b6) |
graouts
removed
the
merging-blocked
annevk
reviewed
Nov 26, 2023
Comment on lines
3069
to
3068
| - (BOOL)CSSIndividualTransformPropertiesEnabled | ||
| { | ||
| return [self _boolValueForKey:WebKitCSSIndividualTransformPropertiesEnabledPreferenceKey]; | ||
| } | ||
|
|
||
| - (void)setCSSIndividualTransformPropertiesEnabled:(BOOL)flag | ||
| { | ||
| [self _setBoolValue:flag forKey:WebKitCSSIndividualTransformPropertiesEnabledPreferenceKey]; | ||
| } | ||
|
|
There was a problem hiding this comment.
You have to noop these and move them to the end of the file. Unless you want to deal with binary compatibility fallout as I understand it.
There was a problem hiding this comment.
See #20896 as an example of how bincompat can be preserved.
There was a problem hiding this comment.
I guess you could do a codesearch to see if anyone used them. I doubt it in this case, but you never know.
There was a problem hiding this comment.
Do we have a policy for the removal of such private preferences provided we don't find any internal clients (as is the case here)?
grorg
approved these changes
Nov 26, 2023
graouts
force-pushed
the
remove-individual-transform-properties-flag
branch
from
52401b6
to
33ace21
Compare
|
EWS run on current version of this PR (hash 33ace21) |
graouts
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=217899 rdar://70434096 Reviewed by Dean Jackson. This flag has been on by default for years and is ripe for removal. * LayoutTests/fast/css/rotate-invalidate-if-disabled-expected.txt: Removed. * LayoutTests/fast/css/rotate-invalidate-if-disabled.html: Removed. * LayoutTests/fast/css/scale-invalidate-if-disabled-expected.txt: Removed. * LayoutTests/fast/css/scale-invalidate-if-disabled.html: Removed. * LayoutTests/fast/css/translate-invalidate-if-disabled-expected.txt: Removed. * LayoutTests/fast/css/translate-invalidate-if-disabled.html: Removed. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/css/CSSProperties.json: * Source/WebCore/css/parser/CSSParserContext.cpp: (WebCore::CSSParserContext::CSSParserContext): * Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h: * Source/WebKitLegacy/mac/WebView/WebPreferences.mm: (-[WebPreferences CSSIndividualTransformPropertiesEnabled]): Deleted. (-[WebPreferences setCSSIndividualTransformPropertiesEnabled:]): Deleted. Canonical link: https://commits.webkit.org/271133@main
webkit-commit-queue
force-pushed
the
remove-individual-transform-properties-flag
branch
from
33ace21
to
3635c66
Compare
|
Committed 271133@main (3635c66): https://commits.webkit.org/271133@main Reviewed commits have been landed. Closing PR #20900 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
nt1m
reviewed
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3635c66
33ace21
🧪 wpe-wk2🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🧪 mac-wk1🧪 api-ios🧪 mac-wk2🧪 gtk-wk2🧪 mac-AS-debug-wk2🧪 api-gtk🧪 jsc-armv7-tests