Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WPE][GTK] API test TestCookieManager /webkit/WebKitCookieManager/long-expires is a constant failure #20932

Merged
merged 1 commit into from
Nov 28, 2023
Merged

[WPE][GTK] API test TestCookieManager /webkit/WebKitCookieManager/long-expires is a constant failure #20932

merged 1 commit into from
Nov 28, 2023

Conversation

obyknovenius
Copy link
Contributor

@obyknovenius obyknovenius commented Nov 27, 2023 •
edited by webkit-early-warning-system
Loading

1c1eb7d

[WPE][GTK] API test `TestCookieManager` `/webkit/WebKitCookieManager/long-expires` is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=265379

Reviewed by Michael Catanzaro.

Since https://gitlab.gnome.org/GNOME/libsoup/-/merge_requests/348,
libsoup rejects SameSite=None cookies by default.

* Tools/TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
(testCookieManagerLongExpires):

Canonical link: https://commits.webkit.org/271198@main

4d12469

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@obyknovenius obyknovenius requested a review from a team as a code owner November 27, 2023 15:42
@obyknovenius obyknovenius self-assigned this Nov 27, 2023
@obyknovenius obyknovenius added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Nov 27, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 27, 2023 •
edited
Loading

EWS run on current version of this PR (hash 4d12469)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@obyknovenius obyknovenius added the merge-queue Applied to send a pull request to merge-queue label Nov 28, 2023
@obyknovenius
[WPE][GTK] API test TestCookieManager `/webkit/WebKitCookieManager/…
1c1eb7d 
…long-expires` is a constant failure

https://bugs.webkit.org/show_bug.cgi?id=265379

Reviewed by Michael Catanzaro.

Since https://gitlab.gnome.org/GNOME/libsoup/-/merge_requests/348,
libsoup rejects SameSite=None cookies by default.

* Tools/TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
(testCookieManagerLongExpires):

Canonical link: https://commits.webkit.org/271198@main
@webkit-commit-queue webkit-commit-queue force-pushed the fix/glib/api-tests/WebKitCookieManager/long-expires branch from 4d12469 to 1c1eb7d Compare November 28, 2023 11:36
@webkit-commit-queue
Copy link
Collaborator

Committed 271198@main (1c1eb7d): https://commits.webkit.org/271198@main

Reviewed commits have been landed. Closing PR #20932 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 1c1eb7d into WebKit:main Nov 28, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 28, 2023
@obyknovenius obyknovenius deleted the fix/glib/api-tests/WebKitCookieManager/long-expires branch December 13, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcatanzaro mcatanzaro mcatanzaro approved these changes

Assignees

@obyknovenius obyknovenius

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
4 participants
@obyknovenius @webkit-early-warning-system @webkit-commit-queue @mcatanzaro