Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REGRESSION (249800@main): Cannot edit compose body field on outlook.com #2094

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

REGRESSION (249800@main): Cannot edit compose body field on outlook.com #2094

wants to merge 1 commit into from

Conversation

nt1m
Copy link
Member

@nt1m nt1m commented Jul 5, 2022

295e194

REGRESSION (249800@main): Cannot edit compose body field on outlook.com
https://bugs.webkit.org/show_bug.cgi?id=242006
<rdar://94619119>

Reviewed by NOBODY (OOPS!).

- Stop supporting unprefixed user-select: all on old SDKs and preserve old editability behavior on it
- Support unprefixed user-select: all on new SDKs with new editability behavior

* Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.cpp:
(WTF::computeSDKAlignedBehaviors):
* Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h:
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* Source/WebCore/css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):
* Source/WebCore/dom/Node.cpp:
(WebCore::computeEditabilityFromComputedStyle):

@nt1m
REGRESSION (249800@main): Cannot edit compose body field on outlook.com
295e194 
https://bugs.webkit.org/show_bug.cgi?id=242006
<rdar://94619119>

Reviewed by NOBODY (OOPS!).

- Stop supporting unprefixed user-select: all on old SDKs and preserve old editability behavior on it
- Support unprefixed user-select: all on new SDKs with new editability behavior

* Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.cpp:
(WTF::computeSDKAlignedBehaviors):
* Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h:
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* Source/WebCore/css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):
* Source/WebCore/dom/Node.cpp:
(WebCore::computeEditabilityFromComputedStyle):
@nt1m nt1m requested a review from graouts as a code owner July 5, 2022 20:58
@nt1m nt1m self-assigned this Jul 5, 2022
@nt1m nt1m added HTML Editing For bugs in HTML editing support (including designMode and contentEditable). WebKit Nightly Build labels Jul 5, 2022
@nt1m nt1m marked this pull request as draft October 16, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graouts graouts Awaiting requested review from graouts graouts is a code owner

@rniwa rniwa Awaiting requested review from rniwa rniwa will be requested when the pull request is marked ready for review rniwa is a code owner

@cdumez cdumez Awaiting requested review from cdumez cdumez will be requested when the pull request is marked ready for review cdumez is a code owner

Assignees

@nt1m nt1m

Labels
HTML Editing For bugs in HTML editing support (including designMode and contentEditable).
Projects
None yet
Milestone
No milestone
2 participants
@nt1m @xeenon