Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The CookieChangeEvent should not be exposed when the cookie store API is disabled #21005

Merged
merged 1 commit into from
Nov 28, 2023
Merged

The CookieChangeEvent should not be exposed when the cookie store API is disabled #21005

merged 1 commit into from
Nov 28, 2023

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Nov 28, 2023 •
edited by webkit-early-warning-system
Loading

e805c44

The CookieChangeEvent should not be exposed when the cookie store API is disabled
https://bugs.webkit.org/show_bug.cgi?id=265463

Reviewed by Brent Fulgham.

Move the CookieChangeEvent behind the runtime flag.

* Source/WebCore/Modules/cookie-store/CookieChangeEvent.idl:

Canonical link: https://commits.webkit.org/271243@main

2f956c3

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez self-assigned this Nov 28, 2023
@cdumez cdumez added the Bindings For bugs related to the DOM bindings label Nov 28, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 28, 2023 •
edited
Loading

EWS run on current version of this PR (hash 2f956c3)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

brentfulgham
brentfulgham approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@brentfulgham brentfulgham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! Thank you for catching that. r=me

@cdumez cdumez added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Nov 28, 2023
@webkit-ews-buildbot webkit-ews-buildbot added merge-queue Applied to send a pull request to merge-queue and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Nov 28, 2023
@webkit-ews-buildbot
Copy link
Collaborator

Safe-Merge-Queue: Build #4692.

@cdumez
The CookieChangeEvent should not be exposed when the cookie store API…
e805c44 
… is disabled

https://bugs.webkit.org/show_bug.cgi?id=265463

Reviewed by Brent Fulgham.

Move the CookieChangeEvent behind the runtime flag.

* Source/WebCore/Modules/cookie-store/CookieChangeEvent.idl:

Canonical link: https://commits.webkit.org/271243@main
@webkit-commit-queue webkit-commit-queue merged commit e805c44 into WebKit:main Nov 28, 2023
@webkit-commit-queue
Copy link
Collaborator

Committed 271243@main (e805c44): https://commits.webkit.org/271243@main

Reviewed commits have been landed. Closing PR #21005 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentfulgham brentfulgham brentfulgham approved these changes

@rniwa rniwa Awaiting requested review from rniwa

@szewai szewai Awaiting requested review from szewai

Assignees

@cdumez cdumez

Labels
Bindings For bugs related to the DOM bindings
Projects
None yet
Milestone
No milestone
5 participants
@cdumez @webkit-early-warning-system @webkit-ews-buildbot @webkit-commit-queue @brentfulgham