Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UnifiedPDF] (regression) Rotated (landscape) pages are drawn not-rotated #21060

Merged
merged 1 commit into from
Nov 29, 2023
Merged

[UnifiedPDF] (regression) Rotated (landscape) pages are drawn not-rotated #21060

merged 1 commit into from
Nov 29, 2023

Conversation

hortont424
Copy link
Contributor

@hortont424 hortont424 commented Nov 29, 2023 •
edited by webkit-early-warning-system
Loading

62d5014

[UnifiedPDF] (regression) Rotated (landscape) pages are drawn not-rotated
https://bugs.webkit.org/show_bug.cgi?id=265534
rdar://118940171

Reviewed by Simon Fraser.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::paintContents):
PDFKit handles the page transform itself.

Canonical link: https://commits.webkit.org/271297@main

f1ed470

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🛠 gtk
✅ 🧪 api-ios   🧪 mac-wk2   🧪 gtk-wk2
  🛠 tv   🧪 mac-AS-debug-wk2   🧪 api-gtk
  🛠 tv-sim
✅ 🛠 🧪 merge   🛠 watch
✅ 🛠 watch-sim

@hortont424 hortont424 self-assigned this Nov 29, 2023
@hortont424 hortont424 added the PDF For bugs in WebKit's built-in PDF support. label Nov 29, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 29, 2023 •
edited
Loading

EWS run on current version of this PR (hash f1ed470)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🛠 gtk
✅ 🧪 api-ios   🧪 mac-wk2   🧪 gtk-wk2
  🛠 tv   🧪 mac-AS-debug-wk2   🧪 api-gtk
  🛠 tv-sim
✅ 🛠 🧪 merge   🛠 watch
✅ 🛠 watch-sim

@hortont424 hortont424 added the merge-queue Applied to send a pull request to merge-queue label Nov 29, 2023
@webkit-commit-queue webkit-commit-queue force-pushed the eng/UnifiedPDF-regression-Rotated-landscape-pages-are-drawn-not-rotated branch from f1ed470 to 2b79137 Compare November 29, 2023 20:39
@hortont424
[UnifiedPDF] (regression) Rotated (landscape) pages are drawn not-rot…
62d5014 
…ated

https://bugs.webkit.org/show_bug.cgi?id=265534
rdar://118940171

Reviewed by Simon Fraser.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::paintContents):
PDFKit handles the page transform itself.

Canonical link: https://commits.webkit.org/271297@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/UnifiedPDF-regression-Rotated-landscape-pages-are-drawn-not-rotated branch from 2b79137 to 62d5014 Compare November 29, 2023 20:42
@webkit-commit-queue
Copy link
Collaborator

Committed 271297@main (62d5014): https://commits.webkit.org/271297@main

Reviewed commits have been landed. Closing PR #21060 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 62d5014 into WebKit:main Nov 29, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smfr smfr smfr approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

Assignees

@hortont424 hortont424

Labels
PDF For bugs in WebKit's built-in PDF support.
Projects
None yet
Milestone
No milestone
4 participants
@hortont424 @webkit-early-warning-system @webkit-commit-queue @smfr