Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference being taken to SourceBufferPrivateAVFObjC in destructor #21085

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Reference being taken to SourceBufferPrivateAVFObjC in destructor #21085

merged 1 commit into from
Nov 30, 2023

Conversation

jyavenard
Copy link
Member

@jyavenard jyavenard commented Nov 30, 2023 •
edited by webkit-early-warning-system
Loading

0769c44

Reference being taken to SourceBufferPrivateAVFObjC in destructor
https://bugs.webkit.org/show_bug.cgi?id=265557
rdar://118957859

Reviewed by Andy Estes.

[WebAVSampleBufferListener invalidate] is called from the SourceBufferPrivateAVFObjC destructor, and as such we can't
take a strong reference to its parent.

* Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(-[WebAVSampleBufferListener invalidate]):

Canonical link: https://commits.webkit.org/271325@main

55ddc2e

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
  🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge   🛠 watch
✅ 🛠 watch-sim

@jyavenard jyavenard self-assigned this Nov 30, 2023
@jyavenard jyavenard added the Media Bugs related to the HTML 5 Media elements. label Nov 30, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 30, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 316297f)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ⏳ 🛠 mac ⏳ 🛠 wpe ⏳ 🛠 wincairo
✅ 🧪 bindings ⏳ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2 ⏳ 🧪 api-mac ⏳ 🧪 api-wpe
⏳ 🧪 ios-wk2-wpt ⏳ 🧪 mac-wk1 ⏳ 🛠 gtk
⏳ 🛠 🧪 jsc ⏳ 🧪 api-ios ⏳ 🧪 mac-wk2 ⏳ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc-arm64 ⏳ 🛠 tv ⏳ 🧪 mac-AS-debug-wk2 ⏳ 🧪 api-gtk
⏳ 🛠 tv-sim ⏳ 🧪 mac-wk2-stress ⏳ 🛠 jsc-armv7
⏳ 🛠 watch ⏳ 🧪 jsc-armv7-tests
⏳ 🛠 watch-sim

aestes
aestes approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@aestes aestes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please add a radar to the commit message.

Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm Show resolved Hide resolved
@jyavenard jyavenard force-pushed the eng/Reference-being-taken-to-SourceBufferPrivateAVFObjC-in-destructor branch from 316297f to 55ddc2e Compare November 30, 2023 01:13
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 30, 2023 •
edited
Loading

EWS run on current version of this PR (hash 55ddc2e)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
  🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge   🛠 watch
✅ 🛠 watch-sim

@jyavenard jyavenard added the merge-queue Applied to send a pull request to merge-queue label Nov 30, 2023
@jyavenard
Reference being taken to SourceBufferPrivateAVFObjC in destructor
0769c44 
https://bugs.webkit.org/show_bug.cgi?id=265557
rdar://118957859

Reviewed by Andy Estes.

[WebAVSampleBufferListener invalidate] is called from the SourceBufferPrivateAVFObjC destructor, and as such we can't
take a strong reference to its parent.

* Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(-[WebAVSampleBufferListener invalidate]):

Canonical link: https://commits.webkit.org/271325@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Reference-being-taken-to-SourceBufferPrivateAVFObjC-in-destructor branch from 55ddc2e to 0769c44 Compare November 30, 2023 04:25
@webkit-commit-queue
Copy link
Collaborator

Committed 271325@main (0769c44): https://commits.webkit.org/271325@main

Reviewed commits have been landed. Closing PR #21085 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 0769c44 into WebKit:main Nov 30, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 30, 2023
@jyavenard jyavenard deleted the eng/Reference-being-taken-to-SourceBufferPrivateAVFObjC-in-destructor branch December 3, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aestes aestes aestes approved these changes

Assignees

@jyavenard jyavenard

Labels
Media Bugs related to the HTML 5 Media elements.
Projects
None yet
Milestone
No milestone
4 participants
@jyavenard @webkit-early-warning-system @webkit-commit-queue @aestes