-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Begin implementing back/forward cache for site isolation #21092
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
achristensen07:eng/Begin-implementing-backforward-cache-for-site-isolation
Dec 6, 2023
Merged
Begin implementing back/forward cache for site isolation #21092
webkit-commit-queue
merged 1 commit into
WebKit:main
from
achristensen07:eng/Begin-implementing-backforward-cache-for-site-isolation
Dec 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EWS run on previous version of this PR (hash ab75d5c) |
ab75d5c
to
4bdab2f
Compare
EWS run on previous version of this PR (hash 4bdab2f) |
pascoej
reviewed
Dec 5, 2023
pascoej
reviewed
Dec 5, 2023
pascoej
reviewed
Dec 5, 2023
pascoej
reviewed
Dec 5, 2023
4bdab2f
to
031e044
Compare
031e044
to
4152719
Compare
EWS run on previous version of this PR (hash 4152719)
|
4152719
to
b4b3d1e
Compare
EWS run on current version of this PR (hash b4b3d1e)
|
pascoej
approved these changes
Dec 6, 2023
https://bugs.webkit.org/show_bug.cgi?id=265561 rdar://118965412 Reviewed by Pascoe. My approach before was to terminate the iframe processes when we navigate away, which seems to match other browsers but doesn't match our existing behavior of being able to quickly navigate back to a fully functional page. We need to keep the processes alive and make CachedFrame able to handle RemoteFrames in order to keep that speed. If we get a memory pressure warning, we will remove back/forward cache entries, but if we have the memory let's keep the existing behavior. This is the first of at least two PRs to get back/forward navigation working with site isolation. I make CachedFrame able to handle RemoteFrames, I made HistoryController a non-nested class to be able to be owned by RemoteFrames (but I didn't change that ownership yet), and I swap RemotePageProxy state to a SuspendedPageProxy when suspending. * Source/WebCore/dom/Document.cpp: (WebCore::Document::attachToCachedFrame): * Source/WebCore/history/CachedFrame.cpp: (WebCore::CachedFrameBase::CachedFrameBase): (WebCore::CachedFrameBase::restore): (WebCore::CachedFrame::CachedFrame): (WebCore::CachedFrame::open): (WebCore::CachedFrame::destroy): * Source/WebCore/history/CachedFrame.h: (WebCore::CachedFrameBase::view const): * Source/WebCore/history/CachedPage.cpp: (WebCore::CachedPage::CachedPage): (WebCore::firePageShowEvent): (WebCore::CachedPage::restore): * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::open): * Source/WebKit/UIProcess/SuspendedPageProxy.cpp: (WebKit::SuspendedPageProxy::SuspendedPageProxy): * Source/WebKit/UIProcess/WebFrameProxy.cpp: (WebKit::WebFrameProxy::removeRemotePagesForSuspension): Deleted. * Source/WebKit/UIProcess/WebFrameProxy.h: * Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/271590@main
b4b3d1e
to
00dcbd8
Compare
Committed 271590@main (00dcbd8): https://commits.webkit.org/271590@main Reviewed commits have been landed. Closing PR #21092 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
00dcbd8
b4b3d1e
π§ͺ wpe-wk2π§ͺ ios-wk2-wptπ tvπ watch-sim