Move some WebKit code to WebKit framework #21140

pvollan · 2023-12-01T03:54:02Z

`676f48d`

Move some WebKit code to WebKit framework
https://bugs.webkit.org/show_bug.cgi?id=265324
rdar://118776213

Reviewed by Brent Fulgham.

Move some WebKit code related to WebKit process extensions to WebKit framework. This change enables
us to use new assertion API to take out an assertion on the Networking process when holding locked
files, which is also included in this patch.

* Source/WebKit/Configurations/BaseExtension.xcconfig:
* Source/WebKit/Configurations/WebKit.xcconfig:
* Source/WebKit/Modules/iOS_Private.modulemap:
* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::setIsHoldingLockedFiles):
* Source/WebKit/NetworkProcess/NetworkProcess.h:
* Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::aqcuireLockedFileGrant):
(WebKit::NetworkProcess::invalidateGrant):
(WebKit::NetworkProcess::hasAcquiredGrant const):
* Source/WebKit/Shared/AuxiliaryProcessExtensions/AuxiliaryProcessExtensionBridge.h:
* Source/WebKit/Shared/AuxiliaryProcessExtensions/NetworkingProcessExtension.swift:
(Grant.invalidate):
(NetworkingProcessExtension.grant(_:name:)):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/271478@main

7fc0483

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	❌ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~		✅ 🛠 gtk
	✅ 🧪 api-ios	~~🧪 mac-wk2~~	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-12-01T03:54:13Z

EWS run on previous version of this PR (hash 8295ff1)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	~~🧪 api-mac~~	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~		✅ 🛠 gtk
⏳ 🛠 🧪 jsc	✅ 🧪 api-ios	~~🧪 mac-wk2~~	~~🧪 gtk-wk2~~
	⏳ 🛠 tv	~~🧪 mac-AS-debug-wk2~~	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
	⏳ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-12-01T04:15:56Z

EWS run on previous version of this PR (hash 409ec4b)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
	❌ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt		✅ 🛠 gtk
	❌ 🧪 api-ios	✅ 🧪 mac-wk2	~~🧪 gtk-wk2~~
	❌ 🛠 tv	~~🧪 mac-AS-debug-wk2~~	✅ 🧪 api-gtk
	❌ 🛠 tv-sim
	❌ 🛠 watch
	❌ 🛠 watch-sim

webkit-early-warning-system · 2023-12-01T05:15:57Z

EWS run on previous version of this PR (hash 11531db)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt		✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-12-01T14:44:56Z

EWS run on previous version of this PR (hash f51acb3)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt		✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	~~🧪 gtk-wk2~~
	✅ 🛠 tv	~~🧪 mac-AS-debug-wk2~~	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-12-01T15:47:57Z

EWS run on previous version of this PR (hash 42987e4)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~		✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

brentfulgham

The code changes look good to me, but I'm less confident about the hard-coded iPhone OS release numbers. I'm approving, but would appreciate it if you could check with @emw-apple before landing.

brentfulgham · 2023-12-01T19:21:12Z

Source/WebKit/Configurations/BaseExtension.xcconfig

+SWIFT_OBJC_BRIDGING_HEADER_YES[sdk=iphone*17.0*] = ;
+SWIFT_OBJC_BRIDGING_HEADER_YES[sdk=iphone*17.1*] = ;
+SWIFT_OBJC_BRIDGING_HEADER_YES[sdk=iphone*17.2*] = ;
+SWIFT_OBJC_BRIDGING_HEADER_YES[sdk=iphone*17.3*] = ;


This pattern of hard-coding specific iOS releases seems unusual. I'd prefer for @emw-apple to review these bits.

This was my request, actually. We need to enable this functionality for all builds after iOS 17.3. The more normal thing to do is to use build setting macros from WebKitTargetConditionals.xcconfig, but we generally only define those for major OS releases.

webkit-early-warning-system · 2023-12-01T20:19:00Z

EWS run on previous version of this PR (hash 183187d)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	❌ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
	❌ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	~~🧪 api-mac~~	~~🧪 api-wpe~~
	❌ 🧪 ios-wk2-wpt		✅ 🛠 gtk
	❌ 🧪 api-ios	~~🧪 mac-wk2~~	~~🧪 gtk-wk2~~
	⏳ 🛠 tv	~~🧪 mac-AS-debug-wk2~~	~~🧪 api-gtk~~
	✅ 🛠 tv-sim
	✅ 🛠 watch
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2023-12-01T20:46:24Z

EWS run on previous version of this PR (hash 70e275a)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	⏳ 🛠 mac	~~🛠 wpe~~	⏳ 🛠 wincairo
	⏳ 🛠 ios-sim	⏳ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🧪 api-mac	~~🧪 api-wpe~~
	⏳ 🧪 ios-wk2-wpt	⏳ 🧪 mac-wk1	⏳ 🛠 gtk
⏳ 🛠 🧪 jsc	⏳ 🧪 api-ios	⏳ 🧪 mac-wk2	⏳ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc-arm64	⏳ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2	⏳ 🧪 api-gtk
	⏳ 🛠 tv-sim	⏳ 🧪 mac-wk2-stress
	⏳ 🛠 watch
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2023-12-01T20:52:14Z

EWS run on previous version of this PR (hash e2df860)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	⏳ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
	⏳ 🛠 ios-sim	⏳ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🧪 api-mac	~~🧪 api-wpe~~
	⏳ 🧪 ios-wk2-wpt	⏳ 🧪 mac-wk1	✅ 🛠 gtk
⏳ 🛠 🧪 jsc	⏳ 🧪 api-ios	⏳ 🧪 mac-wk2	~~🧪 gtk-wk2~~
	⏳ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2	⏳ 🧪 api-gtk
	⏳ 🛠 tv-sim	⏳ 🧪 mac-wk2-stress
	⏳ 🛠 watch
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2023-12-01T21:02:55Z

EWS run on previous version of this PR (hash 876f446)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	~~🧪 api-mac~~	✅ 🧪 api-wpe
	⏳ 🧪 ios-wk2-wpt		✅ 🛠 gtk
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🧪 gtk-wk2~~
	⏳ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2	~~🧪 api-gtk~~
	✅ 🛠 tv-sim
	⏳ 🛠 watch
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2023-12-01T21:29:55Z

EWS run on previous version of this PR (hash 49019d9)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	✅ 🧪 api-wpe
	⏳ 🧪 ios-wk2-wpt		✅ 🛠 gtk
⏳ 🛠 🧪 jsc	~~🧪 api-ios~~	~~🧪 mac-wk2~~	⏳ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc-arm64	⏳ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2	⏳ 🧪 api-gtk
	⏳ 🛠 tv-sim
	~~🛠 watch~~
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2023-12-01T21:59:09Z

EWS run on previous version of this PR (hash b7d9f6d)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	⏳ 🛠 mac	~~🛠 wpe~~	⏳ 🛠 wincairo
	✅ 🛠 ios-sim	⏳ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	⏳ 🧪 api-mac	~~🧪 api-wpe~~
	⏳ 🧪 ios-wk2-wpt	⏳ 🧪 mac-wk1	⏳ 🛠 gtk
⏳ 🛠 🧪 jsc	~~🧪 api-ios~~	⏳ 🧪 mac-wk2	⏳ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc-arm64	⏳ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2	⏳ 🧪 api-gtk
	⏳ 🛠 tv-sim	⏳ 🧪 mac-wk2-stress
	⏳ 🛠 watch
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2023-12-01T22:04:59Z

EWS run on previous version of this PR (hash 7421567)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	⏳ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
	✅ 🛠 ios-sim	⏳ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	⏳ 🧪 api-mac	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~	⏳ 🧪 mac-wk1	⏳ 🛠 gtk
⏳ 🛠 🧪 jsc	~~🧪 api-ios~~	⏳ 🧪 mac-wk2	⏳ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc-arm64	⏳ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2	⏳ 🧪 api-gtk
	⏳ 🛠 tv-sim	⏳ 🧪 mac-wk2-stress
	⏳ 🛠 watch
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2023-12-01T22:15:54Z

EWS run on previous version of this PR (hash e376dd9)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	⏳ 🧪 ios-wk2-wpt		✅ 🛠 gtk
	⏳ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

emw-apple · 2023-12-01T22:27:43Z

Source/WebKit/Configurations/BaseExtension.xcconfig

+SWIFT_OBJC_BRIDGING_HEADER_YES[sdk=iphone*17.0*] = ;
+SWIFT_OBJC_BRIDGING_HEADER_YES[sdk=iphone*17.1*] = ;
+SWIFT_OBJC_BRIDGING_HEADER_YES[sdk=iphone*17.2*] = ;
+SWIFT_OBJC_BRIDGING_HEADER_YES[sdk=iphone*17.3*] = ;


This was my request, actually. We need to enable this functionality for all builds after iOS 17.3. The more normal thing to do is to use build setting macros from WebKitTargetConditionals.xcconfig, but we generally only define those for major OS releases.

emw-apple · 2023-12-01T22:39:55Z

Source/WebKit/Shared/Cocoa/WKProcessExtension.mm

+
+- (void)setSharedInstance:(WKProcessExtension*)instance
+{
+    NSLog(@"WKProcessExtension setSharedInstance %@", instance);


nit: This and the other NSLog calls in this file feel like debugging statements to me, that probably shouldn't make it to production and will only cause log spam. What do you think?

Fixed.

Thanks for reviewing!

emw-apple · 2023-12-01T23:17:17Z

Source/WebKit/Shared/AuxiliaryProcessExtensions/NetworkingProcessExtension.swift

+    override func grant(_ domain: String, name: String) -> Any {
+        do {
+            let grant = try self._request(capabilities: _Capabilities.assertion(domain, name))
+            return Grant(inner: grant)
+        } catch {
+            return WKGrant()
+        }
+    }


Instead of having an abstract -[WKProcessExtension grant:name:] method that you override from Swift, you could declare this extension method as @objc. Then, from NetworkProcessCocoa.mm, you could do a respondsToSelector(@selector(grant:name:)) to check that the method exists (assertion-failing if it does not), then call it.

That might be easier to follow than the abstract method, which should never be called, but has to be written nonetheless.

That is a good point, although I think it also would be good to avoid the respondsToSelector call. I went ahead and landed as-is, but please let me know if you still think this should be changed, and I can follow up in a new patch :)

webkit-early-warning-system · 2023-12-03T20:32:30Z

EWS run on previous version of this PR (hash c45ea31)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt		✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	❌ 🧪 api-gtk
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-12-04T14:08:46Z

EWS run on current version of this PR (hash 7fc0483)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	❌ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~		✅ 🛠 gtk
	✅ 🧪 api-ios	~~🧪 mac-wk2~~	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=265324 rdar://118776213 Reviewed by Brent Fulgham. Move some WebKit code related to WebKit process extensions to WebKit framework. This change enables us to use new assertion API to take out an assertion on the Networking process when holding locked files, which is also included in this patch. * Source/WebKit/Configurations/BaseExtension.xcconfig: * Source/WebKit/Configurations/WebKit.xcconfig: * Source/WebKit/Modules/iOS_Private.modulemap: * Source/WebKit/NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::setIsHoldingLockedFiles): * Source/WebKit/NetworkProcess/NetworkProcess.h: * Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm: (WebKit::NetworkProcess::aqcuireLockedFileGrant): (WebKit::NetworkProcess::invalidateGrant): (WebKit::NetworkProcess::hasAcquiredGrant const): * Source/WebKit/Shared/AuxiliaryProcessExtensions/AuxiliaryProcessExtensionBridge.h: * Source/WebKit/Shared/AuxiliaryProcessExtensions/NetworkingProcessExtension.swift: (Grant.invalidate): (NetworkingProcessExtension.grant(_:name:)): * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/271478@main

webkit-commit-queue · 2023-12-04T16:04:57Z

Committed 271478@main (676f48d): https://commits.webkit.org/271478@main

Reviewed commits have been landed. Closing PR #21140 and removing active labels.

pvollan requested a review from cdumez as a code owner December 1, 2023 03:54

pvollan self-assigned this Dec 1, 2023

pvollan added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Dec 1, 2023

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 1, 2023

pvollan removed the merging-blocked Applied to prevent a change from being merged label Dec 1, 2023

pvollan force-pushed the eng/Move-some-WebKit-code-to-WebKit-framework branch from 409ec4b to 11531db Compare December 1, 2023 05:15

pvollan requested a review from emw-apple as a code owner December 1, 2023 05:15

pvollan force-pushed the eng/Move-some-WebKit-code-to-WebKit-framework branch from 11531db to f51acb3 Compare December 1, 2023 14:44

brentfulgham approved these changes Dec 1, 2023

View reviewed changes

pvollan force-pushed the eng/Move-some-WebKit-code-to-WebKit-framework branch from 42987e4 to 183187d Compare December 1, 2023 20:18

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 1, 2023

pvollan removed the merging-blocked Applied to prevent a change from being merged label Dec 1, 2023

pvollan force-pushed the eng/Move-some-WebKit-code-to-WebKit-framework branch from 183187d to 70e275a Compare December 1, 2023 20:46

pvollan force-pushed the eng/Move-some-WebKit-code-to-WebKit-framework branch from 70e275a to e2df860 Compare December 1, 2023 20:51

pvollan force-pushed the eng/Move-some-WebKit-code-to-WebKit-framework branch from e2df860 to 876f446 Compare December 1, 2023 21:02

pvollan force-pushed the eng/Move-some-WebKit-code-to-WebKit-framework branch from 876f446 to 49019d9 Compare December 1, 2023 21:29

pvollan force-pushed the eng/Move-some-WebKit-code-to-WebKit-framework branch from 49019d9 to b7d9f6d Compare December 1, 2023 21:58

pvollan force-pushed the eng/Move-some-WebKit-code-to-WebKit-framework branch from b7d9f6d to 7421567 Compare December 1, 2023 22:04

pvollan force-pushed the eng/Move-some-WebKit-code-to-WebKit-framework branch from 7421567 to e376dd9 Compare December 1, 2023 22:15

emw-apple reviewed Dec 1, 2023

View reviewed changes

pvollan force-pushed the eng/Move-some-WebKit-code-to-WebKit-framework branch from e376dd9 to c45ea31 Compare December 3, 2023 20:32

pvollan force-pushed the eng/Move-some-WebKit-code-to-WebKit-framework branch from c45ea31 to 7fc0483 Compare December 4, 2023 14:08

pvollan added the merge-queue Applied to send a pull request to merge-queue label Dec 4, 2023

webkit-commit-queue force-pushed the eng/Move-some-WebKit-code-to-WebKit-framework branch from 7fc0483 to 676f48d Compare December 4, 2023 16:04

webkit-commit-queue merged commit 676f48d into WebKit:main Dec 4, 2023

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Dec 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move some WebKit code to WebKit framework #21140

Move some WebKit code to WebKit framework #21140

pvollan commented Dec 1, 2023 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Dec 1, 2023 •

edited

webkit-early-warning-system commented Dec 1, 2023 •

edited

webkit-early-warning-system commented Dec 1, 2023 •

edited

webkit-early-warning-system commented Dec 1, 2023 •

edited

webkit-early-warning-system commented Dec 1, 2023 •

edited

brentfulgham left a comment

brentfulgham Dec 1, 2023

emw-apple Dec 1, 2023

webkit-early-warning-system commented Dec 1, 2023 •

edited

webkit-early-warning-system commented Dec 1, 2023 •

edited

webkit-early-warning-system commented Dec 1, 2023 •

edited

webkit-early-warning-system commented Dec 1, 2023 •

edited

webkit-early-warning-system commented Dec 1, 2023 •

edited

webkit-early-warning-system commented Dec 1, 2023 •

edited

webkit-early-warning-system commented Dec 1, 2023 •

edited

webkit-early-warning-system commented Dec 1, 2023 •

edited

emw-apple Dec 1, 2023

emw-apple Dec 1, 2023

pvollan Dec 4, 2023

emw-apple Dec 1, 2023

pvollan Dec 4, 2023

webkit-early-warning-system commented Dec 3, 2023 •

edited

webkit-early-warning-system commented Dec 4, 2023 •

edited

webkit-commit-queue commented Dec 4, 2023

Move some WebKit code to WebKit framework #21140

Move some WebKit code to WebKit framework #21140

Conversation

pvollan commented Dec 1, 2023 • edited by webkit-early-warning-system

webkit-early-warning-system commented Dec 1, 2023 • edited

webkit-early-warning-system commented Dec 1, 2023 • edited

webkit-early-warning-system commented Dec 1, 2023 • edited

webkit-early-warning-system commented Dec 1, 2023 • edited

webkit-early-warning-system commented Dec 1, 2023 • edited

brentfulgham left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

webkit-early-warning-system commented Dec 1, 2023 • edited

webkit-early-warning-system commented Dec 1, 2023 • edited

webkit-early-warning-system commented Dec 1, 2023 • edited

webkit-early-warning-system commented Dec 1, 2023 • edited

webkit-early-warning-system commented Dec 1, 2023 • edited

webkit-early-warning-system commented Dec 1, 2023 • edited

webkit-early-warning-system commented Dec 1, 2023 • edited

webkit-early-warning-system commented Dec 1, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

webkit-early-warning-system commented Dec 3, 2023 • edited

webkit-early-warning-system commented Dec 4, 2023 • edited

webkit-commit-queue commented Dec 4, 2023

pvollan commented Dec 1, 2023 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Dec 1, 2023 •

edited

webkit-early-warning-system commented Dec 1, 2023 •

edited

webkit-early-warning-system commented Dec 1, 2023 •

edited

webkit-early-warning-system commented Dec 1, 2023 •

edited

webkit-early-warning-system commented Dec 1, 2023 •

edited

webkit-early-warning-system commented Dec 1, 2023 •

edited

webkit-early-warning-system commented Dec 1, 2023 •

edited

webkit-early-warning-system commented Dec 1, 2023 •

edited

webkit-early-warning-system commented Dec 1, 2023 •

edited

webkit-early-warning-system commented Dec 1, 2023 •

edited

webkit-early-warning-system commented Dec 1, 2023 •

edited

webkit-early-warning-system commented Dec 1, 2023 •

edited

webkit-early-warning-system commented Dec 1, 2023 •

edited

webkit-early-warning-system commented Dec 3, 2023 •

edited

webkit-early-warning-system commented Dec 4, 2023 •

edited