Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the binding test case for variadic methods take (Element or Text) #2119

Merged
merged 1 commit into from Jul 10, 2022
Merged

Add the binding test case for variadic methods take (Element or Text) #2119

merged 1 commit into from Jul 10, 2022

Conversation

tetsuharuohzeki
Copy link
Member

@tetsuharuohzeki tetsuharuohzeki commented Jul 6, 2022 •
edited by webkit-commit-queue

af16b0f

Add the binding test case for variadic methods take (Element or Text)
https://bugs.webkit.org/show_bug.cgi?id=242379

Reviewed by Ryosuke Niwa.

* Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjDOMConstructor::construct):
(WebCore::jsTestObjPrototypeFunction_variadicUnionElementOrTextMethodBody):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
* Source/WebCore/bindings/scripts/test/TestObj.idl:

Canonical link: https://commits.webkit.org/252325@main

@tetsuharuohzeki tetsuharuohzeki self-assigned this Jul 6, 2022
@tetsuharuohzeki tetsuharuohzeki added DOM For bugs specific to XML/HTML DOM elements (including parsing). WebKit Nightly Build labels Jul 6, 2022
rniwa
rniwa approved these changes Jul 10, 2022
View reviewed changes
Copy link
Member

@rniwa rniwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@rniwa rniwa added the merge-queue Applied to send a pull request to merge-queue label Jul 10, 2022
@tetsuharuohzeki @rniwa
Add the binding test case for variadic methods take (Element or Text)
af16b0f 
https://bugs.webkit.org/show_bug.cgi?id=242379

Reviewed by Ryosuke Niwa.

* Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjDOMConstructor::construct):
(WebCore::jsTestObjPrototypeFunction_variadicUnionElementOrTextMethodBody):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
* Source/WebCore/bindings/scripts/test/TestObj.idl:

Canonical link: https://commits.webkit.org/252325@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the bug-242379-add-test-case-variadic-method branch from 2da9204 to af16b0f Compare July 10, 2022 05:55
@webkit-early-warning-system webkit-early-warning-system merged commit af16b0f into WebKit:main Jul 10, 2022
@webkit-commit-queue
Copy link
Collaborator

Committed 252325@main (af16b0f): https://commits.webkit.org/252325@main

Reviewed commits have been landed. Closing PR #2119 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 10, 2022
@tetsuharuohzeki
Copy link
Member Author

tetsuharuohzeki commented Jul 10, 2022 •
edited

@rniwa Thank you!

@tetsuharuohzeki tetsuharuohzeki deleted the bug-242379-add-test-case-variadic-method branch July 22, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rniwa rniwa rniwa approved these changes

Assignees

@tetsuharuohzeki tetsuharuohzeki

Labels
DOM For bugs specific to XML/HTML DOM elements (including parsing).
Projects
None yet
Milestone
No milestone
4 participants
@tetsuharuohzeki @webkit-commit-queue @rniwa @webkit-early-warning-system