[iOS 15.4] Fix unused variables #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonWBedard
requested review from
graouts,
litherum,
cdumez,
aproskuryakov and
emw-apple
and removed request for
graouts and
litherum
aproskuryakov
approved these changes
Mar 18, 2022
| @@ -444,6 +444,7 @@ - (void)setIsSelected:(BOOL)isSelected; | |||
|
|
|||
| #if PLATFORM(IOS_FAMILY) | |||
| [[[m_webView _UIKitDelegateForwarder] asyncForwarder] webView:m_webView addMessageToConsole:dictionary withSource:messageSource]; | |||
| UNUSED_PARAM(respondsToNewSelector); | |||
There was a problem hiding this comment.
This should be UNUSED_VARIABLE.
| @@ -221,10 +221,12 @@ void FontCascade::drawGlyphs(GraphicsContext& context, const Font& font, const G | |||
| break; | |||
| } | |||
|
|
|||
| #if PLATFORM(IOS_FAMILY) | |||
| UNUSED_PARAM(shouldSmoothFonts); | |||
There was a problem hiding this comment.
This should be UNUSED_VARIABLE.
| @@ -1319,7 +1319,9 @@ static Class _WebMessageDocumentClass() | |||
| NSRange rangeToReplace = NSMakeRange(textLength, 0); | |||
| NSDictionary *attrs; | |||
| if (fileWrapper) { | |||
| #if !PLATFORM(IOS_FAMILY) | |||
| #if PLATFORM(IOS_FAMILY) | |||
| UNUSED_PARAM(ignoreOrientation); | |||
There was a problem hiding this comment.
This should be UNUSED_VARIABLE.
| @@ -388,6 +388,7 @@ static AccessibilityPreferences accessibilityPreferences() | |||
| } | |||
| #else | |||
| UNUSED_PARAM(mediaDevicesEnabled); | |||
| UNUSED_PARAM(isSafari); | |||
There was a problem hiding this comment.
This should be UNUSED_VARIABLE (and existing code has this issue of course).
emw-apple
approved these changes
Mar 18, 2022
| @@ -2374,7 +2374,7 @@ VisiblePosition AccessibilityRenderObject::visiblePositionForPoint(const IntPoin | |||
| if (!renderView) | |||
| return VisiblePosition(); | |||
|
|
|||
| #if PLATFORM(COCOA) | |||
| #if PLATFORM(MAC) | |||
| FrameView* frameView = &renderView->frameView(); | |||
There was a problem hiding this comment.
There's no real chance of a meaningful side effect here, is there?
There was a problem hiding this comment.
I don't think so, unless frameView() changes state. @cdumez, any thoughts?
JonWBedard
force-pushed
the
eng/iOS-15-4-Fix-unused-variables
branch
from
af51a2e
to
edf2de8
Compare
cdumez
approved these changes
Mar 18, 2022
| @@ -2374,7 +2374,7 @@ VisiblePosition AccessibilityRenderObject::visiblePositionForPoint(const IntPoin | |||
| if (!renderView) | |||
| return VisiblePosition(); | |||
|
|
|||
| #if PLATFORM(COCOA) | |||
| #if PLATFORM(MAC) | |||
| FrameView* frameView = &renderView->frameView(); | |||
|
Since @aproskuryakov asked for this, here is the build output of the first error being fixed here: |
JonWBedard
force-pushed
the
eng/iOS-15-4-Fix-unused-variables
branch
from
edf2de8
to
bc487e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bc487e0