Web Inspector: CSS autocomplete: property usage counts should ignore variables #2124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcrousso
added
Web Inspector
webkit-early-warning-system
added
the
merging-blocked
dcrousso
removed
the
merging-blocked
patrickangle
approved these changes
Jul 6, 2022
dcrousso
added
unsafe-merge-queue
dcrousso
added
the
unsafe-merge-queue
…variables https://bugs.webkit.org/show_bug.cgi?id=242397 Reviewed by Patrick Angle. CSS variables are probably pretty unlikely to have the same named across multiple sites, and it's also somewhat unlikely they'll be used that often (plus many sites have a gazillion of them). * Source/WebInspectorUI/UserInterface/Models/CSSProperty.js: (WI.CSSProperty.isVariable): Added. (WI.CSSProperty.isInheritedPropertyName): (WI.CSSProperty.prototype.update): (WI.CSSProperty.prototype._updateName): * LayoutTests/inspector/css/css-property.html: * LayoutTests/inspector/css/css-property-expected.txt: * Source/WebInspectorUI/UserInterface/Models/CSSStyleDeclaration.js: (WI.CSSStyleDeclaration.prototype.resolveVariableValue): * Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js: (WI.SpreadsheetStyleProperty.prototype._addVariableTokens): Drive-by: Use the new utility `WI.CSSProperty.isVariable` instead of repeating the logic. Canonical link: https://commits.webkit.org/252195@main
webkit-early-warning-system
force-pushed
the
eng/242397
branch
from
f27e5fd
to
714fd40
Compare
|
Committed 252195@main (714fd40): https://commits.webkit.org/252195@main Reviewed commits have been landed. Closing PR #2124 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
714fd40