Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable imported/w3c/html-templates/parsing-html-templates/creating-an-element-for-the-token/template-owner-document.html and friends #21265

Merged
merged 1 commit into from Dec 4, 2023
Merged

Re-enable imported/w3c/html-templates/parsing-html-templates/creating-an-element-for-the-token/template-owner-document.html and friends #21265

merged 1 commit into from Dec 4, 2023

Conversation

annevk
Copy link
Contributor

@annevk annevk commented Dec 4, 2023 •
edited by webkit-early-warning-system

4b191bd

Re-enable imported/w3c/html-templates/parsing-html-templates/creating-an-element-for-the-token/template-owner-document.html and friends
https://bugs.webkit.org/show_bug.cgi?id=151469
rdar://23622739

Reviewed by Tim Nguyen.

See if enough time has passed for the crasher to "disappear" as we
should not have an active HTML parser crasher.

Also remove some likely bogus iOS skips.

* LayoutTests/platform/ios-device/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/271486@main

1823099

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@annevk annevk self-assigned this Dec 4, 2023
@annevk annevk added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Dec 4, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 1823099)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@annevk annevk marked this pull request as ready for review December 4, 2023 12:00
@annevk annevk added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 4, 2023
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Re-enable-importedw3chtml-templatesparsing-html-templatescreating-an-element-for-the-tokentemplate-owner-document-html-and-friends branch from 1823099 to 5c53d19 Compare December 4, 2023 17:13
@annevk
Re-enable imported/w3c/html-templates/parsing-html-templates/creating…
4b191bd 
…-an-element-for-the-token/template-owner-document.html and friends

https://bugs.webkit.org/show_bug.cgi?id=151469
rdar://23622739

Reviewed by Tim Nguyen.

See if enough time has passed for the crasher to "disappear" as we
should not have an active HTML parser crasher.

Also remove some likely bogus iOS skips.

* LayoutTests/platform/ios-device/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/271486@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Re-enable-importedw3chtml-templatesparsing-html-templatescreating-an-element-for-the-tokentemplate-owner-document-html-and-friends branch from 5c53d19 to 4b191bd Compare December 4, 2023 17:15
@webkit-commit-queue webkit-commit-queue merged commit 4b191bd into WebKit:main Dec 4, 2023
@webkit-commit-queue
Copy link
Collaborator

Committed 271486@main (4b191bd): https://commits.webkit.org/271486@main

Reviewed commits have been landed. Closing PR #21265 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 4, 2023
@annevk annevk deleted the eng/Re-enable-importedw3chtml-templatesparsing-html-templatescreating-an-element-for-the-tokentemplate-owner-document-html-and-friends branch December 4, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nt1m nt1m nt1m approved these changes

Assignees

@annevk annevk

Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Milestone
No milestone
4 participants
@annevk @webkit-early-warning-system @webkit-commit-queue @nt1m