[WebGPU] Invalid bind group should be returned if the bind group layout is not compatible with the bind group descriptor #21369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash fe9caff)
|
mwyrzykowski
commented
Dec 6, 2023
| @@ -554,9 +558,7 @@ static MTLResourceUsage resourceUsageForBindingAcccess(BindGroupLayout::BindingA | |||
| constexpr auto maxResourceUsageValue = MTLResourceUsageRead | MTLResourceUsageWrite; | |||
| static_assert(maxResourceUsageValue == 3, "Code path assumes MTLResourceUsageRead | MTLResourceUsageWrite == 3"); | |||
| Vector<id<MTLResource>> stageResources[stageCount][maxResourceUsageValue]; | |||
| // FIXME: https://bugs.webkit.org/show_bug.cgi?id=257190 The bind group layout determines the layout of what gets put into the bind group. | |||
There was a problem hiding this comment.
That FIXME bug link was already completed, removing stale comment
mwyrzykowski
force-pushed
the
eng/WebGPU-Invalid-bind-group-should-be-returned-if-the-bind-group-layout-is-not-compatible-with-the-bind-group-descriptor
branch
from
fe9caff
to
20f9b2f
Compare
|
EWS run on current version of this PR (hash 20f9b2f)
|
tadeuzagallo
approved these changes
Dec 6, 2023
mwyrzykowski
added
safe-merge-queue
…ut is not compatible with the bind group descriptor https://bugs.webkit.org/show_bug.cgi?id=265918 <radar://119225289> Reviewed by Tadeu Zagallo. If the BindGroupLayout is not compatible with the BindGroup, an invalid BindGroup should be returned. * Source/WebGPU/WebGPU/BindGroup.mm: (WebGPU::hasBinding): (WebGPU::Device::createBindGroup): * LayoutTests/http/tests/webgpu/webgpu/api/validation/getBindGroupLayout-expected.txt: getBindGroupLayout test is now passing locally. Canonical link: https://commits.webkit.org/271624@main
webkit-commit-queue
force-pushed
the
eng/WebGPU-Invalid-bind-group-should-be-returned-if-the-bind-group-layout-is-not-compatible-with-the-bind-group-descriptor
branch
from
20f9b2f
to
f418211
Compare
|
Committed 271624@main (f418211): https://commits.webkit.org/271624@main Reviewed commits have been landed. Closing PR #21369 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f418211
20f9b2f
🧪 wpe-wk2🧪 api-gtk