Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebGPU] validation/query_set expectations are missing yet the tests pass locally #21398

Merged
merged 1 commit into from
Dec 7, 2023
Merged

[WebGPU] validation/query_set expectations are missing yet the tests pass locally #21398

merged 1 commit into from
Dec 7, 2023

Conversation

mwyrzykowski
Copy link
Contributor

@mwyrzykowski mwyrzykowski commented Dec 6, 2023 •
edited by webkit-early-warning-system
Loading

c93da6b

[WebGPU] validation/query_set expectations are missing yet the tests pass locally
https://bugs.webkit.org/show_bug.cgi?id=265945
<radar://119261886>

Reviewed by Dan Glastonbury.

These tests pass locally, so add their expectations.

* LayoutTests/http/tests/webgpu/webgpu/api/validation/query_set/create-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/query_set/destroy-expected.txt:

Canonical link: https://commits.webkit.org/271654@main

4941d66

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ❌ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@mwyrzykowski mwyrzykowski self-assigned this Dec 6, 2023
@mwyrzykowski mwyrzykowski added the WebGPU For bugs in WebGPU label Dec 6, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 6, 2023 •
edited
Loading

EWS run on current version of this PR (hash 4941d66)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ❌ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@mwyrzykowski mwyrzykowski requested review from grorg and heycam and removed request for grorg and heycam December 6, 2023 20:21
djg
djg approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@djg djg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mwyrzykowski mwyrzykowski added the merge-queue Applied to send a pull request to merge-queue label Dec 7, 2023
@mwyrzykowski
[WebGPU] validation/query_set expectations are missing yet the tests …
c93da6b 
…pass locally

https://bugs.webkit.org/show_bug.cgi?id=265945
<radar://119261886>

Reviewed by Dan Glastonbury.

These tests pass locally, so add their expectations.

* LayoutTests/http/tests/webgpu/webgpu/api/validation/query_set/create-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/validation/query_set/destroy-expected.txt:

Canonical link: https://commits.webkit.org/271654@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebGPU-validationquery_set-expectations-are-missing-yet-the-tests-pass-locally branch from 4941d66 to c93da6b Compare December 7, 2023 03:03
@webkit-commit-queue
Copy link
Collaborator

Committed 271654@main (c93da6b): https://commits.webkit.org/271654@main

Reviewed commits have been landed. Closing PR #21398 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit c93da6b into WebKit:main Dec 7, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djg djg djg approved these changes

@tadeuzagallo tadeuzagallo Awaiting requested review from tadeuzagallo

Assignees

@mwyrzykowski mwyrzykowski

Labels
WebGPU For bugs in WebGPU
Projects
None yet
Milestone
No milestone
4 participants
@mwyrzykowski @webkit-early-warning-system @webkit-commit-queue @djg