Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build issue after rename #21465

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Fix build issue after rename #21465

merged 1 commit into from
Dec 15, 2023

Conversation

pvollan
Copy link
Contributor

@pvollan pvollan commented Dec 7, 2023 •
edited by webkit-early-warning-system
Loading

@pvollan pvollan self-assigned this Dec 7, 2023
@pvollan pvollan added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Dec 7, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 7, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 2e34859)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 8, 2023
@pvollan pvollan removed the merging-blocked Applied to prevent a change from being merged label Dec 13, 2023
@pvollan pvollan force-pushed the eng/Fix-build-issue-after-rename branch from 2e34859 to 0778fd5 Compare December 14, 2023 23:10
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 14, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 0778fd5)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 gtk
💥 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ❌ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

brentfulgham
brentfulgham approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@brentfulgham brentfulgham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a clean typo correction. r=me

@pvollan pvollan force-pushed the eng/Fix-build-issue-after-rename branch from 0778fd5 to aacc62a Compare December 15, 2023 09:35
@webkit-early-warning-system
Copy link
Collaborator

Starting EWS tests for aacc62a. Live statuses available at the PR page, #21465

@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 15, 2023 •
edited
Loading

EWS run on previous version of this PR (hash aacc62a)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
❌ 🛠 🧪 merge ✅ 🛠 watch
❌ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@pvollan pvollan added merge-queue Applied to send a pull request to merge-queue unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Dec 15, 2023
@webkit-commit-queue
Copy link
Collaborator

Commit message contains (OOPS!), blocking PR #21465

@webkit-commit-queue webkit-commit-queue added merging-blocked Applied to prevent a change from being merged and removed merge-queue Applied to send a pull request to merge-queue unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Dec 15, 2023
@webkit-commit-queue
Copy link
Collaborator

Commit message contains (OOPS!), blocking PR #21465

@pvollan pvollan removed the merging-blocked Applied to prevent a change from being merged label Dec 15, 2023
@pvollan pvollan force-pushed the eng/Fix-build-issue-after-rename branch from aacc62a to 26be3be Compare December 15, 2023 11:51
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 15, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 26be3be)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ❌ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2   🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
❌ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@pvollan pvollan added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 15, 2023
@webkit-commit-queue
Copy link
Collaborator

Commit message contains (OOPS!), blocking PR #21465

@webkit-commit-queue webkit-commit-queue added merging-blocked Applied to prevent a change from being merged and removed unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Dec 15, 2023
@pvollan pvollan removed the merging-blocked Applied to prevent a change from being merged label Dec 15, 2023
@pvollan pvollan force-pushed the eng/Fix-build-issue-after-rename branch from 26be3be to 30bd0f5 Compare December 15, 2023 13:43
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 15, 2023 •
edited
Loading

EWS run on current version of this PR (hash 30bd0f5)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim   🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🛠 gtk
  🧪 api-ios   🧪 mac-wk2   🧪 gtk-wk2
  🛠 tv   🧪 mac-AS-debug-wk2   🧪 api-gtk
  🛠 tv-sim
  🛠 🧪 merge   🛠 watch
✅ 🛠 🧪 unsafe-merge   🛠 watch-sim

@pvollan pvollan added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 15, 2023
@pvollan
Fix build issue after rename
29cbe4a 
https://bugs.webkit.org/show_bug.cgi?id=266020
rdar://problem/119339780

Reviewed by Brent Fulgham.

* Source/WebKit/Shared/AuxiliaryProcessExtensions/NetworkingProcessExtension.swift:
(NetworkingProcessExtension.grant(_:name:)):

Canonical link: https://commits.webkit.org/272110@main
@webkit-commit-queue
Copy link
Collaborator

Committed 272110@main (29cbe4a): https://commits.webkit.org/272110@main

Reviewed commits have been landed. Closing PR #21465 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 29cbe4a into WebKit:main Dec 15, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentfulgham brentfulgham brentfulgham approved these changes

@cdumez cdumez Awaiting requested review from cdumez

@aestes aestes Awaiting requested review from aestes

Assignees

@pvollan pvollan

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
5 participants
@pvollan @webkit-early-warning-system @webkit-commit-queue @brentfulgham @webkit-ews-buildbot