Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REGRESSION(271529@main): Volatility timer stops before all surfaces are made volatile and never completes. #21477

Merged
merged 1 commit into from
Dec 8, 2023
Merged

REGRESSION(271529@main): Volatility timer stops before all surfaces are made volatile and never completes. #21477

merged 1 commit into from
Dec 8, 2023

Conversation

mattwoodrow
Copy link
Contributor

@mattwoodrow mattwoodrow commented Dec 8, 2023 •
edited by webkit-early-warning-system
Loading

052b3e1

REGRESSION(271529@main): Volatility timer stops before all surfaces are made volatile and never completes.
https://bugs.webkit.org/show_bug.cgi?id=266034
<rdar://119344111>

Reviewed by Dan Glastonbury.

If `identifiers` is empty it means we didn't collect any right now, not that
there weren't any to be collected.

We should only stop the timer if `collectedAllRemoteRenderingBuffers` is true
(as well as `successfullyMadeBackingStoreVolatile`).

* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm:
(WebKit::RemoteLayerBackingStoreCollection::markAllBackingStoreVolatileFromTimer):

Canonical link: https://commits.webkit.org/271704@main

95af4d8

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2   🧪 gtk-wk2
  🛠 tv ✅ 🧪 mac-AS-debug-wk2   🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
  🛠 watch-sim

@mattwoodrow mattwoodrow self-assigned this Dec 8, 2023
@mattwoodrow mattwoodrow added the Layout and Rendering For bugs with layout and rendering of Web pages. label Dec 8, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 8, 2023 •
edited
Loading

EWS run on current version of this PR (hash 95af4d8)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2   🧪 gtk-wk2
  🛠 tv ✅ 🧪 mac-AS-debug-wk2   🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
  🛠 watch-sim

djg
djg approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@djg djg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mattwoodrow mattwoodrow added the merge-queue Applied to send a pull request to merge-queue label Dec 8, 2023
@mattwoodrow
REGRESSION(271529@main): Volatility timer stops before all surfaces a…
052b3e1 
…re made volatile and never completes.

https://bugs.webkit.org/show_bug.cgi?id=266034
<rdar://119344111>

Reviewed by Dan Glastonbury.

If `identifiers` is empty it means we didn't collect any right now, not that
there weren't any to be collected.

We should only stop the timer if `collectedAllRemoteRenderingBuffers` is true
(as well as `successfullyMadeBackingStoreVolatile`).

* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm:
(WebKit::RemoteLayerBackingStoreCollection::markAllBackingStoreVolatileFromTimer):

Canonical link: https://commits.webkit.org/271704@main
@webkit-commit-queue
Copy link
Collaborator

Committed 271704@main (052b3e1): https://commits.webkit.org/271704@main

Reviewed commits have been landed. Closing PR #21477 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 052b3e1 into WebKit:main Dec 8, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djg djg djg approved these changes

Assignees

@mattwoodrow mattwoodrow

Labels
Layout and Rendering For bugs with layout and rendering of Web pages.
Projects
None yet
Milestone
No milestone
4 participants
@mattwoodrow @webkit-early-warning-system @webkit-commit-queue @djg