Port FilterEffect to the new IPC serialization format #21480

cdumez · 2023-12-08T00:30:36Z

`edea595`

Port FilterEffect to the new IPC serialization format
https://bugs.webkit.org/show_bug.cgi?id=266037

Reviewed by Brady Eidson.

* Source/WebCore/platform/graphics/filters/FEBlend.cpp:
(WebCore::FEBlend::create):
* Source/WebCore/platform/graphics/filters/FEBlend.h:
* Source/WebCore/platform/graphics/filters/FEColorMatrix.cpp:
(WebCore::FEColorMatrix::create):
* Source/WebCore/platform/graphics/filters/FEColorMatrix.h:
* Source/WebCore/platform/graphics/filters/FEComponentTransfer.cpp:
(WebCore::FEComponentTransfer::create):
* Source/WebCore/platform/graphics/filters/FEComponentTransfer.h:
* Source/WebCore/platform/graphics/filters/FEComposite.cpp:
(WebCore::FEComposite::create):
* Source/WebCore/platform/graphics/filters/FEComposite.h:
* Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp:
(WebCore::FEConvolveMatrix::create):
* Source/WebCore/platform/graphics/filters/FEConvolveMatrix.h:
* Source/WebCore/platform/graphics/filters/FEDiffuseLighting.cpp:
(WebCore::FEDiffuseLighting::create):
* Source/WebCore/platform/graphics/filters/FEDiffuseLighting.h:
* Source/WebCore/platform/graphics/filters/FEDisplacementMap.cpp:
(WebCore::FEDisplacementMap::create):
* Source/WebCore/platform/graphics/filters/FEDisplacementMap.h:
* Source/WebCore/platform/graphics/filters/FEDropShadow.cpp:
(WebCore::FEDropShadow::create):
* Source/WebCore/platform/graphics/filters/FEDropShadow.h:
* Source/WebCore/platform/graphics/filters/FEFlood.cpp:
(WebCore::FEFlood::create):
* Source/WebCore/platform/graphics/filters/FEFlood.h:
* Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::create):
* Source/WebCore/platform/graphics/filters/FEGaussianBlur.h:
* Source/WebCore/platform/graphics/filters/FEImage.cpp:
(WebCore::FEImage::create):
* Source/WebCore/platform/graphics/filters/FEImage.h:
* Source/WebCore/platform/graphics/filters/FEMerge.cpp:
(WebCore::FEMerge::create):
* Source/WebCore/platform/graphics/filters/FEMerge.h:
* Source/WebCore/platform/graphics/filters/FEMorphology.cpp:
(WebCore::FEMorphology::create):
* Source/WebCore/platform/graphics/filters/FEMorphology.h:
* Source/WebCore/platform/graphics/filters/FEOffset.cpp:
(WebCore::FEOffset::create):
* Source/WebCore/platform/graphics/filters/FEOffset.h:
* Source/WebCore/platform/graphics/filters/FESpecularLighting.cpp:
(WebCore::FESpecularLighting::create):
* Source/WebCore/platform/graphics/filters/FESpecularLighting.h:
* Source/WebCore/platform/graphics/filters/FETile.cpp:
(WebCore::FETile::create):
* Source/WebCore/platform/graphics/filters/FETile.h:
* Source/WebCore/platform/graphics/filters/FETurbulence.cpp:
(WebCore::FETurbulence::create):
* Source/WebCore/platform/graphics/filters/FETurbulence.h:
* Source/WebCore/platform/graphics/filters/SourceAlpha.cpp:
(WebCore::SourceAlpha::create):
(WebCore::SourceAlpha::SourceAlpha):
* Source/WebCore/platform/graphics/filters/SourceAlpha.h:
* Source/WebCore/platform/graphics/filters/SourceGraphic.cpp:
(WebCore::SourceGraphic::create):
* Source/WebCore/platform/graphics/filters/SourceGraphic.h:
* Source/WebKit/Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<FilterEffect>::encode): Deleted.
(IPC::ArgumentCoder<FilterEffect>::decode): Deleted.
* Source/WebKit/Shared/WebCoreArgumentCoders.h:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/271793@main

a4da401

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	~~🧪 api-gtk~~
	✅ 🛠 tv-sim
~~🛠 🧪 merge~~	✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-12-08T00:32:32Z

EWS run on previous version of this PR (hash 7369945)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

achristensen07 · 2023-12-08T05:53:57Z

Source/WebCore/platform/graphics/filters/FEBlend.cpp

 {
-    return adoptRef(*new FEBlend(mode));
+    Ref effect = adoptRef(*new FEBlend(mode));
+    effect->setOperatingColorSpace(colorSpace);


I think we should pass all the parameters into the constructor. I think we should make a FilterEffect constructor that requires a DestinationColorSpace and sets it in the constructor instead of requiring all the objects to modify after construction.

It is a little annoying because setOperatingColorSpace() is a virtual function but I'll look into it.

webkit-early-warning-system · 2023-12-08T16:27:55Z

EWS run on previous version of this PR (hash 74bb3eb)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 wincairo
❌ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
❌ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	⏳ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🛠 gtk
⏳ 🛠 🧪 jsc	❌ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc-arm64	⏳ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 api-gtk
	⏳ 🛠 tv-sim	❌ 🧪 mac-wk2-stress
	⏳ 🛠 watch
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2023-12-08T17:15:20Z

Starting EWS tests for 03bf0fb. Live statuses available at the PR page, #21480

webkit-early-warning-system · 2023-12-08T17:15:20Z

EWS run on previous version of this PR (hash 03bf0fb)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	❌ 🧪 api-wpe
	⏳ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	❌ 🛠 gtk
⏳ 🛠 🧪 jsc	✅ 🧪 api-ios	~~🧪 mac-wk2~~	❌ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc-arm64	⏳ 🛠 tv	~~🧪 mac-AS-debug-wk2~~	❌ 🧪 api-gtk
	❌ 🛠 tv-sim
	⏳ 🛠 watch
	⏳ 🛠 watch-sim

shallawa · 2023-12-08T17:23:53Z

@cdumez Nice! Thanks for cleaning this part of the filters.

webkit-early-warning-system · 2023-12-08T18:23:22Z

EWS run on previous version of this PR (hash f7e80c7)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	~~🧪 gtk-wk2~~
	✅ 🛠 tv	~~🧪 mac-AS-debug-wk2~~	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

cdumez · 2023-12-08T21:12:31Z

Weird, I have some iOS-only failures it seems. I don't think I had those in my previous iteration. Not quite sure what I messed up.

webkit-early-warning-system · 2023-12-08T21:18:41Z

EWS run on current version of this PR (hash 1e82bfd)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
🧪 style	🛠 ios	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 wincairo
🧪 bindings	⏳ 🛠 ios-sim	⏳ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🧪 api-mac	⏳ 🧪 api-wpe
	⏳ 🧪 ios-wk2-wpt	⏳ 🧪 mac-wk1	⏳ 🛠 gtk
⏳ 🛠 🧪 jsc	⏳ 🧪 api-ios	⏳ 🧪 mac-wk2	⏳ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc-arm64	⏳ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2	⏳ 🧪 api-gtk
	⏳ 🛠 tv-sim	⏳ 🧪 mac-wk2-stress	🛠 jsc-armv7
	⏳ 🛠 watch		🧪 jsc-armv7-tests
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2023-12-08T21:18:41Z

EWS run on previous version of this PR (hash 1e82bfd)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 wincairo~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	~~🧪 api-wpe~~
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
⏳ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	~~🧪 gtk-wk2~~
	~~🛠 tv~~	~~🧪 mac-AS-debug-wk2~~	~~🧪 api-gtk~~
	✅ 🛠 tv-sim
	✅ 🛠 watch
	~~🛠 watch-sim~~

cdumez · 2023-12-09T00:14:21Z

Weird, I have some iOS-only failures it seems. I don't think I had those in my previous iteration. Not quite sure what I messed up.

I believe I figured it out.

webkit-early-warning-system · 2023-12-09T01:14:44Z

EWS run on previous version of this PR (hash db33cfa)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	❌ 🧪 api-wpe
	⏳ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	❌ 🛠 gtk
⏳ 🛠 🧪 jsc	~~🧪 api-ios~~	~~🧪 mac-wk2~~	❌ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc-arm64	⏳ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	❌ 🧪 api-gtk
	~~🛠 tv-sim~~
	⏳ 🛠 watch
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2023-12-09T02:22:07Z

EWS run on current version of this PR (hash a4da401)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
⏳ 🧪 style	⏳ 🛠 ios	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 wincairo
🧪 bindings	⏳ 🛠 ios-sim	⏳ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🧪 api-mac	⏳ 🧪 api-wpe
	⏳ 🧪 ios-wk2-wpt	⏳ 🧪 mac-wk1	⏳ 🛠 gtk
⏳ 🛠 🧪 jsc	⏳ 🧪 api-ios	⏳ 🧪 mac-wk2	⏳ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc-arm64	⏳ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2	⏳ 🧪 api-gtk
🧪 services	⏳ 🛠 tv-sim	⏳ 🧪 mac-wk2-stress	⏳ 🛠 jsc-armv7
	⏳ 🛠 watch		⏳ 🧪 jsc-armv7-tests
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2023-12-09T02:22:08Z

EWS run on current version of this PR (hash a4da401)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	~~🧪 api-gtk~~
	✅ 🛠 tv-sim
~~🛠 🧪 merge~~	✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge	✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=266037 Reviewed by Brady Eidson. * Source/WebCore/platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::create): * Source/WebCore/platform/graphics/filters/FEBlend.h: * Source/WebCore/platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::create): * Source/WebCore/platform/graphics/filters/FEColorMatrix.h: * Source/WebCore/platform/graphics/filters/FEComponentTransfer.cpp: (WebCore::FEComponentTransfer::create): * Source/WebCore/platform/graphics/filters/FEComponentTransfer.h: * Source/WebCore/platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::create): * Source/WebCore/platform/graphics/filters/FEComposite.h: * Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp: (WebCore::FEConvolveMatrix::create): * Source/WebCore/platform/graphics/filters/FEConvolveMatrix.h: * Source/WebCore/platform/graphics/filters/FEDiffuseLighting.cpp: (WebCore::FEDiffuseLighting::create): * Source/WebCore/platform/graphics/filters/FEDiffuseLighting.h: * Source/WebCore/platform/graphics/filters/FEDisplacementMap.cpp: (WebCore::FEDisplacementMap::create): * Source/WebCore/platform/graphics/filters/FEDisplacementMap.h: * Source/WebCore/platform/graphics/filters/FEDropShadow.cpp: (WebCore::FEDropShadow::create): * Source/WebCore/platform/graphics/filters/FEDropShadow.h: * Source/WebCore/platform/graphics/filters/FEFlood.cpp: (WebCore::FEFlood::create): * Source/WebCore/platform/graphics/filters/FEFlood.h: * Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::create): * Source/WebCore/platform/graphics/filters/FEGaussianBlur.h: * Source/WebCore/platform/graphics/filters/FEImage.cpp: (WebCore::FEImage::create): * Source/WebCore/platform/graphics/filters/FEImage.h: * Source/WebCore/platform/graphics/filters/FEMerge.cpp: (WebCore::FEMerge::create): * Source/WebCore/platform/graphics/filters/FEMerge.h: * Source/WebCore/platform/graphics/filters/FEMorphology.cpp: (WebCore::FEMorphology::create): * Source/WebCore/platform/graphics/filters/FEMorphology.h: * Source/WebCore/platform/graphics/filters/FEOffset.cpp: (WebCore::FEOffset::create): * Source/WebCore/platform/graphics/filters/FEOffset.h: * Source/WebCore/platform/graphics/filters/FESpecularLighting.cpp: (WebCore::FESpecularLighting::create): * Source/WebCore/platform/graphics/filters/FESpecularLighting.h: * Source/WebCore/platform/graphics/filters/FETile.cpp: (WebCore::FETile::create): * Source/WebCore/platform/graphics/filters/FETile.h: * Source/WebCore/platform/graphics/filters/FETurbulence.cpp: (WebCore::FETurbulence::create): * Source/WebCore/platform/graphics/filters/FETurbulence.h: * Source/WebCore/platform/graphics/filters/SourceAlpha.cpp: (WebCore::SourceAlpha::create): (WebCore::SourceAlpha::SourceAlpha): * Source/WebCore/platform/graphics/filters/SourceAlpha.h: * Source/WebCore/platform/graphics/filters/SourceGraphic.cpp: (WebCore::SourceGraphic::create): * Source/WebCore/platform/graphics/filters/SourceGraphic.h: * Source/WebKit/Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder<FilterEffect>::encode): Deleted. (IPC::ArgumentCoder<FilterEffect>::decode): Deleted. * Source/WebKit/Shared/WebCoreArgumentCoders.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/271793@main

webkit-commit-queue · 2023-12-09T06:48:27Z

Committed 271793@main (edea595): https://commits.webkit.org/271793@main

Reviewed commits have been landed. Closing PR #21480 and removing active labels.

cdumez self-assigned this Dec 8, 2023

cdumez added the WebKit2 Bugs relating to the WebKit2 API layer label Dec 8, 2023

cdumez marked this pull request as ready for review December 8, 2023 03:30

cdumez requested review from achristensen07, shallawa, smfr and beidson December 8, 2023 03:31

achristensen07 requested changes Dec 8, 2023

View reviewed changes

cdumez force-pushed the 266037_FilterEffect_IPC branch from 7369945 to 74bb3eb Compare December 8, 2023 16:27

cdumez force-pushed the 266037_FilterEffect_IPC branch from 74bb3eb to 03bf0fb Compare December 8, 2023 17:15

cdumez requested a review from achristensen07 December 8, 2023 17:31

cdumez force-pushed the 266037_FilterEffect_IPC branch from 03bf0fb to f7e80c7 Compare December 8, 2023 18:20

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 8, 2023

cdumez removed the merging-blocked Applied to prevent a change from being merged label Dec 8, 2023

cdumez force-pushed the 266037_FilterEffect_IPC branch from f7e80c7 to 1e82bfd Compare December 8, 2023 21:18

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 8, 2023

cdumez removed the merging-blocked Applied to prevent a change from being merged label Dec 9, 2023

cdumez force-pushed the 266037_FilterEffect_IPC branch from 1e82bfd to 0c25c69 Compare December 9, 2023 00:09

cdumez force-pushed the 266037_FilterEffect_IPC branch from 0c25c69 to e8a5f47 Compare December 9, 2023 00:49

beidson approved these changes Dec 9, 2023

View reviewed changes

cdumez force-pushed the 266037_FilterEffect_IPC branch from e8a5f47 to db33cfa Compare December 9, 2023 01:13

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 9, 2023

cdumez removed the merging-blocked Applied to prevent a change from being merged label Dec 9, 2023

cdumez force-pushed the 266037_FilterEffect_IPC branch from db33cfa to a4da401 Compare December 9, 2023 02:21

webkit-commit-queue force-pushed the 266037_FilterEffect_IPC branch from a4da401 to edea595 Compare December 9, 2023 06:48

webkit-commit-queue merged commit edea595 into WebKit:main Dec 9, 2023

webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port FilterEffect to the new IPC serialization format #21480

Port FilterEffect to the new IPC serialization format #21480

cdumez commented Dec 8, 2023 •

edited by webkit-early-warning-system

Loading

webkit-early-warning-system commented Dec 8, 2023 •

edited

Loading

achristensen07 Dec 8, 2023

cdumez Dec 8, 2023

webkit-early-warning-system commented Dec 8, 2023 •

edited

Loading

webkit-early-warning-system commented Dec 8, 2023

webkit-early-warning-system commented Dec 8, 2023 •

edited

Loading

shallawa commented Dec 8, 2023

webkit-early-warning-system commented Dec 8, 2023 •

edited

Loading

cdumez commented Dec 8, 2023

webkit-early-warning-system commented Dec 8, 2023 •

edited

Loading

webkit-early-warning-system commented Dec 8, 2023 •

edited

Loading

cdumez commented Dec 9, 2023

webkit-early-warning-system commented Dec 9, 2023 •

edited

Loading

webkit-early-warning-system commented Dec 9, 2023 •

edited

Loading

webkit-early-warning-system commented Dec 9, 2023 •

edited

Loading

webkit-commit-queue commented Dec 9, 2023

Port FilterEffect to the new IPC serialization format #21480

Port FilterEffect to the new IPC serialization format #21480

Conversation

cdumez commented Dec 8, 2023 • edited by webkit-early-warning-system Loading

edea595

webkit-early-warning-system commented Dec 8, 2023 • edited Loading

achristensen07 Dec 8, 2023

Choose a reason for hiding this comment

cdumez Dec 8, 2023

Choose a reason for hiding this comment

webkit-early-warning-system commented Dec 8, 2023 • edited Loading

webkit-early-warning-system commented Dec 8, 2023

webkit-early-warning-system commented Dec 8, 2023 • edited Loading

shallawa commented Dec 8, 2023

webkit-early-warning-system commented Dec 8, 2023 • edited Loading

cdumez commented Dec 8, 2023

webkit-early-warning-system commented Dec 8, 2023 • edited Loading

webkit-early-warning-system commented Dec 8, 2023 • edited Loading

cdumez commented Dec 9, 2023

webkit-early-warning-system commented Dec 9, 2023 • edited Loading

webkit-early-warning-system commented Dec 9, 2023 • edited Loading

webkit-early-warning-system commented Dec 9, 2023 • edited Loading

webkit-commit-queue commented Dec 9, 2023

cdumez commented Dec 8, 2023 •

edited by webkit-early-warning-system

Loading

`edea595`

webkit-early-warning-system commented Dec 8, 2023 •

edited

Loading

webkit-early-warning-system commented Dec 8, 2023 •

edited

Loading

webkit-early-warning-system commented Dec 8, 2023 •

edited

Loading

webkit-early-warning-system commented Dec 8, 2023 •

edited

Loading

webkit-early-warning-system commented Dec 8, 2023 •

edited

Loading

webkit-early-warning-system commented Dec 8, 2023 •

edited

Loading

webkit-early-warning-system commented Dec 9, 2023 •

edited

Loading

webkit-early-warning-system commented Dec 9, 2023 •

edited

Loading

webkit-early-warning-system commented Dec 9, 2023 •

edited

Loading