-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename resourceRequest to originalRequest in NavigationAction #21489
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
szewai:eng/Rename-resourceRequest-to-originalRequest-in-NavigationAction
Dec 13, 2023
Merged
Rename resourceRequest to originalRequest in NavigationAction #21489
webkit-commit-queue
merged 1 commit into
WebKit:main
from
szewai:eng/Rename-resourceRequest-to-originalRequest-in-NavigationAction
Dec 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EWS run on previous version of this PR (hash e9cac03) |
achristensen07
approved these changes
Dec 8, 2023
e9cac03
to
b429214
Compare
b429214
to
9a88ead
Compare
EWS run on current version of this PR (hash 9a88ead) |
https://bugs.webkit.org/show_bug.cgi?id=266054 rdar://119354060 Reviewed by Alex Christensen. The resourceRequest in NavigationAction is the original request of the action, which is not necessarily the ongoing or final request of the action (for example, server redirection will change request of the navigation), so this patch updates the name for clarity. * Source/WebCore/loader/NavigationAction.cpp: (WebCore::NavigationAction::NavigationAction): * Source/WebCore/loader/NavigationAction.h: (WebCore::NavigationAction::isEmpty const): (WebCore::NavigationAction::url const): (WebCore::NavigationAction::originalRequest const): (WebCore::NavigationAction::resourceRequest const): Deleted. * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::createWindow): * Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): * Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp: (WebKit::WebRemoteFrameClient::changeLocation): Canonical link: https://commits.webkit.org/271994@main
9a88ead
to
e64e4c4
Compare
Committed 271994@main (e64e4c4): https://commits.webkit.org/271994@main Reviewed commits have been landed. Closing PR #21489 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
New Bugs
Unclassified bugs are placed in this component until the correct component can be determined.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e64e4c4
9a88ead