[UIAsyncTextInput] Release assertion after selecting "Translate" when async text input is enabled #21578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whsieh
added
the
Platform
|
EWS run on current version of this PR (hash a85fbe3)
|
whsieh
requested review from
hortont424,
pxlcoder,
rr-codes,
aprotyas and
megangardner
megangardner
approved these changes
Dec 9, 2023
whsieh
added
the
unsafe-merge-queue
… async text input is enabled https://bugs.webkit.org/show_bug.cgi?id=266157 rdar://119434259 Reviewed by Megan Gardner. After the UIKit changes in rdar://119283621, the default commands corresponding to these 3 actions: ``` _define: define: _translate: translate: _lookup: lookup: ``` ...now follow an inverted model for dispatching fallback actions, where the primary action selector is the legacy private action, and the fallback selector is the new selector on `UIAsyncTextInput`. This means that UIKit ends up calling into private selectors on the content view instead of their non-underscore-prefixed counterparts even when `UIKit/async_text_input` is enabled, causing us to hit release assertions under these three methods. To avoid this, we adjust the default behavior of `-targetForActionForWebView:withSender:` to always return `nil` for these three private selectors, in order to force UIKit to fall back to calling into the new action selectors. Changes covered by the layout test `editing/selection/ios/look-up-selected-text.html`, when async text input is enabled. * Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView targetForActionForWebView:withSender:]): Canonical link: https://commits.webkit.org/271817@main
webkit-commit-queue
force-pushed
the
eng/266157
branch
from
a85fbe3
to
161dbc0
Compare
|
Committed 271817@main (161dbc0): https://commits.webkit.org/271817@main Reviewed commits have been landed. Closing PR #21578 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
161dbc0
a85fbe3
🧪 wpe-wk2🧪 api-mac🧪 ios-wk2-wpt🧪 gtk-wk2🧪 mac-AS-debug-wk2🧪 api-gtk