Use enumToUnderlyingType more in WebCore #21588

fujii · 2023-12-10T10:42:46Z

`776f4b7`

Use enumToUnderlyingType more in WebCore
https://bugs.webkit.org/show_bug.cgi?id=266173

Reviewed by Chris Dumez.

* Source/WebCore/accessibility/AXObjectCache.cpp:
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
* Source/WebCore/animation/AcceleratedTimeline.cpp:
* Source/WebCore/bindings/js/JSDOMMapLike.cpp:
* Source/WebCore/bindings/js/JSDOMSetLike.cpp:
* Source/WebCore/bindings/js/JSDOMWindowBase.cpp:
* Source/WebCore/bindings/js/JSDOMWindowProperties.cpp:
* Source/WebCore/bindings/js/JSLocalDOMWindowCustom.cpp:
* Source/WebCore/bindings/js/JSObservableArray.cpp:
* Source/WebCore/bindings/js/JSPluginElementFunctions.cpp:
* Source/WebCore/bindings/js/JSRemoteDOMWindowCustom.cpp:
* Source/WebCore/bindings/js/ScriptModuleLoader.cpp:
* Source/WebCore/bridge/runtime_array.cpp:
* Source/WebCore/bridge/runtime_object.cpp:
* Source/WebCore/crypto/CryptoAlgorithmRegistry.cpp:
* Source/WebCore/css/CSSPrimitiveValue.h:
* Source/WebCore/css/CSSRule.cpp:
* Source/WebCore/css/CSSSelector.cpp:
* Source/WebCore/css/CSSSelector.h:
* Source/WebCore/css/CSSValuePool.cpp:
* Source/WebCore/css/DeprecatedCSSOMValue.h:
* Source/WebCore/css/ImmutableStyleProperties.cpp:
* Source/WebCore/css/MutableStyleProperties.cpp:
* Source/WebCore/css/calc/CSSCalcOperationNode.cpp:
* Source/WebCore/dom/Document.h:
* Source/WebCore/dom/DocumentMarkerController.cpp:
* Source/WebCore/dom/Element.cpp:
* Source/WebCore/dom/EventTarget.h:
* Source/WebCore/dom/Node.cpp:
* Source/WebCore/dom/Node.h:
* Source/WebCore/dom/make_names.pl:
* Source/WebCore/html/HTMLInputElement.cpp:
* Source/WebCore/html/HTMLInputElement.h:
* Source/WebCore/inspector/agents/InspectorDOMAgent.cpp:
* Source/WebCore/platform/graphics/FontCascadeDescription.cpp:
* Source/WebCore/platform/graphics/FontDescription.cpp:
* Source/WebCore/platform/graphics/FontDescription.h:
* Source/WebCore/rendering/RenderGrid.cpp:
* Source/WebCore/rendering/style/NinePieceImage.h:
* Source/WebCore/rendering/style/RenderStyle.cpp:
* Source/WebCore/rendering/style/StyleContentAlignmentData.h:
* Source/WebCore/rendering/style/StyleSelfAlignmentData.h:
* Source/WebCore/style/RuleFeature.h:
* Source/WebCore/style/StyleScopeOrdinal.h:
* Source/WebCore/svg/SVGPathByteStreamBuilder.h:
* Source/WebCore/workers/service/server/SWRegistrationDatabase.cpp:

Canonical link: https://commits.webkit.org/272145@main

01a524c

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-12-10T10:42:53Z

EWS run on previous version of this PR (hash 71257af)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

Source/WebCore/dom/Document.h

Source/WebCore/dom/Node.h

webkit-early-warning-system · 2023-12-11T06:45:43Z

EWS run on current version of this PR (hash 48c4255)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
⏳ 🧪 style	🛠 ios	🛠 mac	🛠 wpe	⏳ 🛠 wincairo
🧪 bindings	🛠 ios-sim	⏳ 🛠 mac-AS-debug	🧪 wpe-wk2
🧪 webkitperl	🧪 ios-wk2	🧪 api-mac	🧪 api-wpe
	🧪 ios-wk2-wpt	🧪 mac-wk1	🛠 gtk
⏳ 🛠 🧪 jsc	🧪 api-ios	🧪 mac-wk2	🧪 gtk-wk2
⏳ 🛠 🧪 jsc-arm64	⏳ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2	🧪 api-gtk
	⏳ 🛠 tv-sim	🧪 mac-wk2-stress	🛠 jsc-armv7
	⏳ 🛠 watch		🧪 jsc-armv7-tests
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2023-12-11T06:45:44Z

EWS run on previous version of this PR (hash 48c4255)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🛠 gtk
	❌ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🧪 gtk-wk2
	❌ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 api-gtk
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2-stress
	❌ 🛠 watch
	❌ 🛠 watch-sim

webkit-early-warning-system · 2023-12-15T02:48:20Z

Starting EWS tests for 0fe72ca. Live statuses available at the PR page, #21588

webkit-early-warning-system · 2023-12-15T02:48:20Z

EWS run on previous version of this PR (hash 0fe72ca)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	~~🛠 gtk~~
	❌ 🧪 api-ios	❌ 🧪 mac-wk2	~~🧪 gtk-wk2~~
	❌ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	~~🧪 api-gtk~~
	⏳ 🛠 tv-sim	❌ 🧪 mac-wk2-stress
	⏳ 🛠 watch
	❌ 🛠 watch-sim

webkit-early-warning-system · 2023-12-15T03:27:53Z

Starting EWS tests for 01a524c. Live statuses available at the PR page, #21588

webkit-early-warning-system · 2023-12-15T03:27:54Z

EWS run on current version of this PR (hash 01a524c)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=266173 Reviewed by Chris Dumez. * Source/WebCore/accessibility/AXObjectCache.cpp: * Source/WebCore/accessibility/AccessibilityNodeObject.cpp: * Source/WebCore/accessibility/AccessibilityObject.cpp: * Source/WebCore/animation/AcceleratedTimeline.cpp: * Source/WebCore/bindings/js/JSDOMMapLike.cpp: * Source/WebCore/bindings/js/JSDOMSetLike.cpp: * Source/WebCore/bindings/js/JSDOMWindowBase.cpp: * Source/WebCore/bindings/js/JSDOMWindowProperties.cpp: * Source/WebCore/bindings/js/JSLocalDOMWindowCustom.cpp: * Source/WebCore/bindings/js/JSObservableArray.cpp: * Source/WebCore/bindings/js/JSPluginElementFunctions.cpp: * Source/WebCore/bindings/js/JSRemoteDOMWindowCustom.cpp: * Source/WebCore/bindings/js/ScriptModuleLoader.cpp: * Source/WebCore/bridge/runtime_array.cpp: * Source/WebCore/bridge/runtime_object.cpp: * Source/WebCore/crypto/CryptoAlgorithmRegistry.cpp: * Source/WebCore/css/CSSPrimitiveValue.h: * Source/WebCore/css/CSSRule.cpp: * Source/WebCore/css/CSSSelector.cpp: * Source/WebCore/css/CSSSelector.h: * Source/WebCore/css/CSSValuePool.cpp: * Source/WebCore/css/DeprecatedCSSOMValue.h: * Source/WebCore/css/ImmutableStyleProperties.cpp: * Source/WebCore/css/MutableStyleProperties.cpp: * Source/WebCore/css/calc/CSSCalcOperationNode.cpp: * Source/WebCore/dom/Document.h: * Source/WebCore/dom/DocumentMarkerController.cpp: * Source/WebCore/dom/Element.cpp: * Source/WebCore/dom/EventTarget.h: * Source/WebCore/dom/Node.cpp: * Source/WebCore/dom/Node.h: * Source/WebCore/dom/make_names.pl: * Source/WebCore/html/HTMLInputElement.cpp: * Source/WebCore/html/HTMLInputElement.h: * Source/WebCore/inspector/agents/InspectorDOMAgent.cpp: * Source/WebCore/platform/graphics/FontCascadeDescription.cpp: * Source/WebCore/platform/graphics/FontDescription.cpp: * Source/WebCore/platform/graphics/FontDescription.h: * Source/WebCore/rendering/RenderGrid.cpp: * Source/WebCore/rendering/style/NinePieceImage.h: * Source/WebCore/rendering/style/RenderStyle.cpp: * Source/WebCore/rendering/style/StyleContentAlignmentData.h: * Source/WebCore/rendering/style/StyleSelfAlignmentData.h: * Source/WebCore/style/RuleFeature.h: * Source/WebCore/style/StyleScopeOrdinal.h: * Source/WebCore/svg/SVGPathByteStreamBuilder.h: * Source/WebCore/workers/service/server/SWRegistrationDatabase.cpp: Canonical link: https://commits.webkit.org/272145@main

webkit-commit-queue · 2023-12-15T22:53:57Z

Committed 272145@main (776f4b7): https://commits.webkit.org/272145@main

Reviewed commits have been landed. Closing PR #21588 and removing active labels.

fujii requested review from rniwa and cdumez as code owners December 10, 2023 10:42

fujii self-assigned this Dec 10, 2023

fujii added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Dec 10, 2023

fujii marked this pull request as draft December 10, 2023 10:43

cdumez approved these changes Dec 10, 2023

View reviewed changes

Source/WebCore/dom/Document.h Outdated Show resolved Hide resolved

Source/WebCore/dom/Document.h Outdated Show resolved Hide resolved

Source/WebCore/dom/Node.h Outdated Show resolved Hide resolved

fujii force-pushed the eng/more-enumToUnderlyingType-in-WebCore branch from 71257af to 48c4255 Compare December 11, 2023 06:45

fujii marked this pull request as ready for review December 11, 2023 06:46

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 11, 2023

fujii marked this pull request as draft December 12, 2023 04:42

fujii removed the merging-blocked Applied to prevent a change from being merged label Dec 15, 2023

fujii force-pushed the eng/more-enumToUnderlyingType-in-WebCore branch from 48c4255 to 0fe72ca Compare December 15, 2023 02:45

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 15, 2023

fujii removed the merging-blocked Applied to prevent a change from being merged label Dec 15, 2023

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 15, 2023

fujii force-pushed the eng/more-enumToUnderlyingType-in-WebCore branch from 0fe72ca to 01a524c Compare December 15, 2023 03:27

fujii marked this pull request as ready for review December 15, 2023 04:03

fujii requested review from zdobersek, graouts, dcrousso and patrickangle as code owners December 15, 2023 04:03

fujii added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Dec 15, 2023

webkit-commit-queue force-pushed the eng/more-enumToUnderlyingType-in-WebCore branch from 01a524c to 776f4b7 Compare December 15, 2023 22:52

webkit-commit-queue merged commit 776f4b7 into WebKit:main Dec 15, 2023

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Dec 15, 2023

fujii deleted the eng/more-enumToUnderlyingType-in-WebCore branch January 11, 2024 22:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use enumToUnderlyingType more in WebCore #21588

Use enumToUnderlyingType more in WebCore #21588

fujii commented Dec 10, 2023 •

edited by webkit-early-warning-system

Loading

webkit-early-warning-system commented Dec 10, 2023 •

edited

Loading

webkit-early-warning-system commented Dec 11, 2023 •

edited

Loading

webkit-early-warning-system commented Dec 11, 2023 •

edited

Loading

webkit-early-warning-system commented Dec 15, 2023

webkit-early-warning-system commented Dec 15, 2023 •

edited

Loading

webkit-early-warning-system commented Dec 15, 2023

webkit-early-warning-system commented Dec 15, 2023 •

edited

Loading

webkit-commit-queue commented Dec 15, 2023

Use enumToUnderlyingType more in WebCore #21588

Use enumToUnderlyingType more in WebCore #21588

Conversation

fujii commented Dec 10, 2023 • edited by webkit-early-warning-system Loading

776f4b7

webkit-early-warning-system commented Dec 10, 2023 • edited Loading

webkit-early-warning-system commented Dec 11, 2023 • edited Loading

webkit-early-warning-system commented Dec 11, 2023 • edited Loading

webkit-early-warning-system commented Dec 15, 2023

webkit-early-warning-system commented Dec 15, 2023 • edited Loading

webkit-early-warning-system commented Dec 15, 2023

webkit-early-warning-system commented Dec 15, 2023 • edited Loading

webkit-commit-queue commented Dec 15, 2023

fujii commented Dec 10, 2023 •

edited by webkit-early-warning-system

Loading

`776f4b7`

webkit-early-warning-system commented Dec 10, 2023 •

edited

Loading

webkit-early-warning-system commented Dec 11, 2023 •

edited

Loading

webkit-early-warning-system commented Dec 11, 2023 •

edited

Loading

webkit-early-warning-system commented Dec 15, 2023 •

edited

Loading

webkit-early-warning-system commented Dec 15, 2023 •

edited

Loading