Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nullptr crash in RemoteLayerBackingStoreCollection::prepareBackingStoresForDisplay. #21662

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Nullptr crash in RemoteLayerBackingStoreCollection::prepareBackingStoresForDisplay. #21662

merged 1 commit into from
Dec 12, 2023

Conversation

mattwoodrow
Copy link
Contributor

@mattwoodrow mattwoodrow commented Dec 12, 2023 •
edited by webkit-early-warning-system
Loading

5061d1d

Nullptr crash in RemoteLayerBackingStoreCollection::prepareBackingStoresForDisplay.
https://bugs.webkit.org/show_bug.cgi?id=266263
<rdar://119526173>

Reviewed by Jean-Yves Avenard.

'backingStore' is a WeakPtr& and might be null, so we need to check it.

* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm:
(WebKit::RemoteLayerBackingStoreCollection::prepareBackingStoresForDisplay):

Canonical link: https://commits.webkit.org/271911@main

45f6916

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@mattwoodrow mattwoodrow self-assigned this Dec 12, 2023
@mattwoodrow mattwoodrow added the Layout and Rendering For bugs with layout and rendering of Web pages. label Dec 12, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 12, 2023 •
edited
Loading

EWS run on current version of this PR (hash 45f6916)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@mattwoodrow mattwoodrow added the merge-queue Applied to send a pull request to merge-queue label Dec 12, 2023
@mattwoodrow
Nullptr crash in RemoteLayerBackingStoreCollection::prepareBackingSto…
5061d1d 
…resForDisplay.

https://bugs.webkit.org/show_bug.cgi?id=266263
<rdar://119526173>

Reviewed by Jean-Yves Avenard.

'backingStore' is a WeakPtr& and might be null, so we need to check it.

* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm:
(WebKit::RemoteLayerBackingStoreCollection::prepareBackingStoresForDisplay):

Canonical link: https://commits.webkit.org/271911@main
@webkit-commit-queue
Copy link
Collaborator

Committed 271911@main (5061d1d): https://commits.webkit.org/271911@main

Reviewed commits have been landed. Closing PR #21662 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 5061d1d into WebKit:main Dec 12, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyavenard jyavenard jyavenard approved these changes

Assignees

@mattwoodrow mattwoodrow

Labels
Layout and Rendering For bugs with layout and rendering of Web pages.
Projects
None yet
Milestone
No milestone
4 participants
@mattwoodrow @webkit-early-warning-system @webkit-commit-queue @jyavenard