Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upload-file-to-url should print file size in MB #21673

Merged
merged 1 commit into from
Dec 12, 2023
Merged

upload-file-to-url should print file size in MB #21673

merged 1 commit into from
Dec 12, 2023

Conversation

aj062
Copy link
Member

@aj062 aj062 commented Dec 12, 2023 •
edited by webkit-early-warning-system
Loading

952dc0f

upload-file-to-url should print file size in MB
https://bugs.webkit.org/show_bug.cgi?id=266142

Reviewed by Jonathan Bedard.

Files being uploaded are several hundred MBs, so better to print the size in MB.

* Tools/Scripts/upload-file-to-url:

Canonical link: https://commits.webkit.org/271937@main

0bd835c

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style   🛠 ios   🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings   🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 gtk
  🧪 api-ios   🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv   🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim   🧪 mac-wk2-stress
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@aj062 aj062 self-assigned this Dec 12, 2023
@aj062 aj062 added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Dec 12, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 12, 2023 •
edited
Loading

EWS run on current version of this PR (hash 0bd835c)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style   🛠 ios   🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings   🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 gtk
  🧪 api-ios   🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv   🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim   🧪 mac-wk2-stress
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@aj062 aj062 added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 12, 2023
@webkit-commit-queue webkit-commit-queue force-pushed the eng/upload-file-to-url-should-print-file-size-in-MB branch from 0bd835c to defc720 Compare December 12, 2023 16:37
@aj062
upload-file-to-url should print file size in MB
952dc0f 
https://bugs.webkit.org/show_bug.cgi?id=266142

Reviewed by Jonathan Bedard.

Files being uploaded are several hundred MBs, so better to print the size in MB.

* Tools/Scripts/upload-file-to-url:

Canonical link: https://commits.webkit.org/271937@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/upload-file-to-url-should-print-file-size-in-MB branch from defc720 to 952dc0f Compare December 12, 2023 16:39
@webkit-commit-queue
Copy link
Collaborator

Committed 271937@main (952dc0f): https://commits.webkit.org/271937@main

Reviewed commits have been landed. Closing PR #21673 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 952dc0f into WebKit:main Dec 12, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 12, 2023
@aj062 aj062 deleted the eng/upload-file-to-url-should-print-file-size-in-MB branch December 12, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonWBedard JonWBedard JonWBedard approved these changes

@ryanhaddad ryanhaddad Awaiting requested review from ryanhaddad

Assignees

@aj062 aj062

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
4 participants
@aj062 @webkit-early-warning-system @webkit-commit-queue @JonWBedard