Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable building WebKit extensions for visionOS #21933

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Disable building WebKit extensions for visionOS #21933

merged 1 commit into from
Dec 18, 2023

Conversation

pvollan
Copy link
Contributor

@pvollan pvollan commented Dec 17, 2023 •
edited by webkit-early-warning-system
Loading

c63b681

Disable building WebKit extensions for visionOS
https://bugs.webkit.org/show_bug.cgi?id=266546

Reviewed by Tim Horton.

Disable building WebKit extensions for visionOS due to SDK issue.

* Source/WebKit/Configurations/BaseExtension.xcconfig:
* Source/WebKit/Configurations/WebKit.xcconfig:

Canonical link: https://commits.webkit.org/272202@main

c36419e

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🛠 gtk
  🧪 api-ios   🧪 mac-wk2   🧪 gtk-wk2
✅ 🛠 tv   🧪 mac-AS-debug-wk2   🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@pvollan pvollan self-assigned this Dec 17, 2023
@pvollan pvollan added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Dec 17, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 17, 2023 •
edited
Loading

EWS run on previous version of this PR (hash e7381eb)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 17, 2023
@pvollan pvollan removed the merging-blocked Applied to prevent a change from being merged label Dec 18, 2023
@pvollan pvollan force-pushed the eng/Disable-building-WebKit-extensions-for-visionOS branch from e7381eb to 48d74e1 Compare December 18, 2023 06:45
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 18, 2023 •
edited
Loading

EWS run on current version of this PR (hash 48d74e1)

Misc iOS, tvOS & watchOS macOS Linux Windows
⏳ 🧪 style ⏳ 🛠 ios loading 🛠 mac loading 🛠 wpe ⏳ 🛠 wincairo
loading 🛠 ios-sim loading 🛠 mac-AS-debug loading 🧪 wpe-wk2
loading 🧪 webkitperl loading 🧪 ios-wk2 loading 🧪 api-mac loading 🧪 api-wpe
loading 🧪 ios-wk2-wpt loading 🧪 mac-wk1 loading 🛠 gtk
loading 🧪 api-ios loading 🧪 mac-wk2 loading 🧪 gtk-wk2
⏳ 🛠 tv loading 🧪 mac-AS-debug-wk2 loading 🧪 api-gtk
loading 🧪 services ⏳ 🛠 tv-sim loading 🧪 mac-wk2-stress ⏳ 🛠 jsc-armv7
loading 🛠 watch ⏳ 🧪 jsc-armv7-tests
⏳ 🛠 watch-sim

@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 18, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 48d74e1)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2   🧪 gtk-wk2
✅ 🛠 tv   🧪 mac-AS-debug-wk2   🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@pvollan pvollan force-pushed the eng/Disable-building-WebKit-extensions-for-visionOS branch from 48d74e1 to c36419e Compare December 18, 2023 06:51
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 18, 2023 •
edited
Loading

EWS run on current version of this PR (hash c36419e)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🛠 gtk
  🧪 api-ios   🧪 mac-wk2   🧪 gtk-wk2
✅ 🛠 tv   🧪 mac-AS-debug-wk2   🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@pvollan pvollan added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 18, 2023
@pvollan
Copy link
Contributor Author

pvollan commented Dec 18, 2023

Thanks for reviewing!

@pvollan
Disable building WebKit extensions for visionOS
c63b681 
https://bugs.webkit.org/show_bug.cgi?id=266546

Reviewed by Tim Horton.

Disable building WebKit extensions for visionOS due to SDK issue.

* Source/WebKit/Configurations/BaseExtension.xcconfig:
* Source/WebKit/Configurations/WebKit.xcconfig:

Canonical link: https://commits.webkit.org/272202@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Disable-building-WebKit-extensions-for-visionOS branch from c36419e to c63b681 Compare December 18, 2023 06:54
@webkit-commit-queue
Copy link
Collaborator

Committed 272202@main (c63b681): https://commits.webkit.org/272202@main

Reviewed commits have been landed. Closing PR #21933 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit c63b681 into WebKit:main Dec 18, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hortont424 hortont424 hortont424 approved these changes

@emw-apple emw-apple Awaiting requested review from emw-apple emw-apple is a code owner

Assignees

@pvollan pvollan

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
5 participants
@pvollan @webkit-early-warning-system @webkit-commit-queue @hortont424 @webkit-ews-buildbot